From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A91CBC369CB for ; Tue, 22 Apr 2025 06:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:From:Cc:To:Subject: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=Laie5l5n1gZd3SgsdQRm+GoNG+cwyXhcD6E7w6EkYHA=; b=U+eF/B9wtRD3Pwh8R+eAqvvP/s /DjlJb3YWMvDhMe8WeoBue9iAogXV94/lA3EBML2ZuDX+n5FyUztVDgDHCse4Lvv6aCxvBkUbxHV2 WYUuVnDaXk/qNtFTQtcjdVchEoRnJ6slxseW8hYHdw4fRhU3TSWwc6g7AX8DlOdO8VCl0hg2nu4fP cj8yy5iAnIJhd9WIRSjCHkf1IBc2UXg8YGIV2P6s8AwhjqtXtnbmYxjGfrLBQkEXGvOlYZ2GGyTV6 lA3wKJNEBNVr2yuQcvIm9JkDPo7mHTsdXDr5uCILuhT9saoJ+SvsDdbeGUb5SKcx/mjiM/Un86HT0 A+Ai19cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u77R9-000000061sb-1YJ3; Tue, 22 Apr 2025 06:48:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u77MT-00000006150-12a5 for linux-arm-kernel@lists.infradead.org; Tue, 22 Apr 2025 06:44:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8A6F85C0F8E; Tue, 22 Apr 2025 06:41:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D360CC4CEEA; Tue, 22 Apr 2025 06:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745304244; bh=YGq+Wojbrkku/t87C5s2nrNXW8jF0yCSvTcDlnpXzFs=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=nKXhphFczzoIjo+sGBICqQKXZG5Jnl6VGHgDssXTTEi907Ql/hcAZov4lI9sBqYAA YcwsTXskArbJ0dDk3fBP1qDlFw1C0Riyzyp6xDtlIBc40qDLMrZNjSL+WxwdqHP76t XpVM+xAURK2ooTqa2c30DtfvxlyLFf8hfkyKD+N0= Subject: Patch "arm64/fpsimd: Stop using TIF_SVE to manage register saving in KVM" has been added to the 6.1-stable tree To: broonie@kernel.org,catalin.marinas@arm.com,gregkh@linuxfoundation.org,james.morse@arm.com,kvmarm@lists.cs.columbia.edu,kvmarm@lists.linux.dev,linux-arm-kernel@lists.infradead.org,mark.rutland@arm.com,maz@kernel.org,oleg@redhat.com,oliver.upton@linux.dev,suzuki.poulose@arm.com,will@kernel.org Cc: From: Date: Tue, 22 Apr 2025 08:43:53 +0200 In-Reply-To: <20250404-stable-sve-6-1-v1-4-cd5c9eb52d49@kernel.org> Message-ID: <2025042253-follicle-credibly-3c4b@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250421_234405_381775_19EBD78F X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled arm64/fpsimd: Stop using TIF_SVE to manage register saving in KVM to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: arm64-fpsimd-stop-using-tif_sve-to-manage-register-saving-in-kvm.patch and it can be found in the queue-6.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From stable+bounces-128303-greg=kroah.com@vger.kernel.org Fri Apr 4 15:28:32 2025 From: Mark Brown Date: Fri, 04 Apr 2025 14:23:37 +0100 Subject: arm64/fpsimd: Stop using TIF_SVE to manage register saving in KVM To: Catalin Marinas , Will Deacon , Marc Zyngier , James Morse , Suzuki K Poulose , Oliver Upton , Oleg Nesterov , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, Mark Brown , stable@vger.kernel.org, Mark Rutland Message-ID: <20250404-stable-sve-6-1-v1-4-cd5c9eb52d49@kernel.org> From: Mark Brown [ Upstream commit 62021cc36add7b2c015b837f7893f2fb4b8c2586 ] Now that we are explicitly telling the host FP code which register state it needs to save we can remove the manipulation of TIF_SVE from the KVM code, simplifying it and allowing us to optimise our handling of normal tasks. Remove the manipulation of TIF_SVE from KVM and instead rely on to_save to ensure we save the correct data for it. There should be no functional or performance impact from this change. Signed-off-by: Mark Brown Reviewed-by: Catalin Marinas Reviewed-by: Marc Zyngier Link: https://lore.kernel.org/r/20221115094640.112848-5-broonie@kernel.org Signed-off-by: Will Deacon [ Mark: trivial backport ] Signed-off-by: Mark Rutland Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- arch/arm64/kernel/fpsimd.c | 22 ++++------------------ arch/arm64/kvm/fpsimd.c | 3 --- 2 files changed, 4 insertions(+), 21 deletions(-) --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -439,8 +439,8 @@ static void task_fpsimd_load(void) * last, if KVM is involved this may be the guest VM context rather * than the host thread for the VM pointed to by current. This means * that we must always reference the state storage via last rather - * than via current, other than the TIF_ flags which KVM will - * carefully maintain for us. + * than via current, if we are saving KVM state then it will have + * ensured that the type of registers to save is set in last->to_save. */ static void fpsimd_save(void) { @@ -457,27 +457,13 @@ static void fpsimd_save(void) if (test_thread_flag(TIF_FOREIGN_FPSTATE)) return; - if (test_thread_flag(TIF_SVE)) { + if ((last->to_save == FP_STATE_CURRENT && test_thread_flag(TIF_SVE)) || + last->to_save == FP_STATE_SVE) { save_sve_regs = true; save_ffr = true; vl = last->sve_vl; } - /* - * Validate that an explicitly specified state to save is - * consistent with the task state. - */ - switch (last->to_save) { - case FP_STATE_CURRENT: - break; - case FP_STATE_FPSIMD: - WARN_ON_ONCE(save_sve_regs); - break; - case FP_STATE_SVE: - WARN_ON_ONCE(!save_sve_regs); - break; - } - if (system_supports_sme()) { u64 *svcr = last->svcr; --- a/arch/arm64/kvm/fpsimd.c +++ b/arch/arm64/kvm/fpsimd.c @@ -151,7 +151,6 @@ void kvm_arch_vcpu_ctxsync_fp(struct kvm &vcpu->arch.fp_type, fp_type); clear_thread_flag(TIF_FOREIGN_FPSTATE); - update_thread_flag(TIF_SVE, vcpu_has_sve(vcpu)); } } @@ -208,7 +207,5 @@ void kvm_arch_vcpu_put_fp(struct kvm_vcp sysreg_clear_set(CPACR_EL1, CPACR_EL1_ZEN_EL0EN, 0); } - update_thread_flag(TIF_SVE, 0); - local_irq_restore(flags); } Patches currently in stable-queue which might be from broonie@kernel.org are queue-6.1/kvm-arm64-remove-host-fpsimd-saving-for-non-protected-kvm.patch queue-6.1/spi-cadence-qspi-fix-probe-on-am62a-lp-sk.patch queue-6.1/asoc-qdsp6-q6asm-dai-fix-q6asm_dai_compr_set_params-error-path.patch queue-6.1/asoc-qdsp6-q6apm-dai-fix-capture-pipeline-overruns.patch queue-6.1/kvm-arm64-mark-some-header-functions-as-inline.patch queue-6.1/kvm-arm64-eagerly-switch-zcr_el-1-2.patch queue-6.1/kvm-arm64-unconditionally-save-flush-host-fpsimd-sve-sme-state.patch queue-6.1/asoc-amd-add-dmi-quirk-for-acp6x-mic-support.patch queue-6.1/kvm-arm64-refactor-exit-handlers.patch queue-6.1/asoc-qdsp6-q6apm-dai-set-10-ms-period-and-buffer-alignment.patch queue-6.1/asoc-codecs-lpass-wsa-macro-fix-vi-feedback-rate.patch queue-6.1/arm64-fpsimd-track-the-saved-fpsimd-state-type-separately-to-tif_sve.patch queue-6.1/kvm-arm64-remove-vhe-host-restore-of-cpacr_el1.zen.patch queue-6.1/kvm-arm64-remove-vhe-host-restore-of-cpacr_el1.smen.patch queue-6.1/asoc-fsl_audmix-register-card-device-depends-on-dais.patch queue-6.1/arm64-fpsimd-have-kvm-explicitly-say-which-fp-registers-to-save.patch queue-6.1/kvm-arm64-discard-any-sve-state-when-entering-kvm-guests.patch queue-6.1/arm64-fpsimd-stop-using-tif_sve-to-manage-register-saving-in-kvm.patch queue-6.1/asoc-codecs-lpass-wsa-macro-fix-logic-of-enabling-vi-channels.patch queue-6.1/kvm-arm64-calculate-cptr_el2-traps-on-activating-traps.patch