From: Rob Herring <robh@kernel.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Olivia Wen <olivia.wen@mediatek.com>,
kernel@collabora.com, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195
Date: Wed, 23 Apr 2025 10:49:30 -0500 [thread overview]
Message-ID: <20250423154930.GA579807-robh@kernel.org> (raw)
In-Reply-To: <20250421-scp-dual-core-mt8390-v2-1-c84117a959a9@collabora.com>
On Mon, Apr 21, 2025 at 04:49:04PM -0400, Nícolas F. R. A. Prado wrote:
> Both MT8192 and MT8195 have an L1TCM memory, so it should be described
> in reg, and therefore reg's minItems should be 3, as is already implicit
> by reg-names being three entries long. However minItems is currently
> unset for mt8192/mt8195, resulting in it being equal to 2, from the base
> schema. Fix reg minItems for MT8192 and MT8195 by setting it to 3.
>
> Fixes: 6b55b1e2fd7f ("dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index adc6b3f36fde49eb3fa7ed3f08b0fa9e7f331162..ee33c233e44f3d51f0851b35697a24208c87f68a 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -185,6 +185,7 @@ allOf:
> then:
> properties:
> reg:
> + minItems: 3
> maxItems: 3
As the max is already 3 at the top-level, you should drop maxItems here.
> reg-names:
> items:
>
> --
> 2.49.0
>
next prev parent reply other threads:[~2025-04-23 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 20:49 [PATCH v2 0/5] Describe MT8188's SCP as dual-core Nícolas F. R. A. Prado
2025-04-21 20:49 ` [PATCH v2 1/5] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195 Nícolas F. R. A. Prado
2025-04-22 13:44 ` AngeloGioacchino Del Regno
2025-04-23 15:49 ` Rob Herring [this message]
2025-04-21 20:49 ` [PATCH v2 2/5] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP Nícolas F. R. A. Prado
2025-04-21 20:49 ` [PATCH v2 3/5] dt-bindings: remoteproc: mediatek: Drop redundant maxItems for mt8192/95 Nícolas F. R. A. Prado
2025-04-23 15:51 ` Rob Herring
2025-04-21 20:49 ` [PATCH v2 4/5] arm64: dts: mediatek: mt8188: Describe SCP as a cluster with two cores Nícolas F. R. A. Prado
2025-04-21 20:49 ` [PATCH v2 5/5] arm64: dts: mediatek: mt8390-genio-common: Add firmware-name for scp0 Nícolas F. R. A. Prado
2025-04-22 13:47 ` (subset) [PATCH v2 0/5] Describe MT8188's SCP as dual-core AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423154930.GA579807-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=olivia.wen@mediatek.com \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).