From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06597C369CB for ; Thu, 24 Apr 2025 01:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9F/DHK7/mJX9NL8Mzb4O1oxuz6OKqITzeD7cg3jj8F0=; b=bOUzaMX15jVsUALtWNBDP1ra60 z2FPMZPugOEtIymUA5ZeOMwKrhw5v3YwMnoqD5Vc16mv0qjmOdmdE+aH+7Mq2ZUbt+1BrvSpoRtq6 SqxH64d0Z3MiP+TqN3TwH2HFCMdOottFAbGV1/dOXDwRoPi2VtCbXgabf8ui+xjCLqe1XnQi4u6jc wT78Wzz9hnoTlo8Xx3wsqSh84TYnH+079npESb86CZSKtTASuJM0ZPg/mq9DzBdFxxPngKnHhHxHp QzqM4vagXB6MwDcosV7Q8PHqhfIrEpFgaKHh8dNQBxy0rRvuR60kQ3fsMMhT0E3S4KVaD1QpCnisX kwlGlLKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7l51-0000000CToa-3AyC; Thu, 24 Apr 2025 01:08:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7kht-0000000CQkn-0BY2 for linux-arm-kernel@lists.infradead.org; Thu, 24 Apr 2025 00:44:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F01E106F; Wed, 23 Apr 2025 17:44:43 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2DF73F59E; Wed, 23 Apr 2025 17:44:45 -0700 (PDT) Date: Thu, 24 Apr 2025 01:43:41 +0100 From: Andre Przywara To: Yixun Lan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/5] arm64: dts: allwinner: a527: add EMAC0 to Radxa A5E board Message-ID: <20250424014341.7006ea65@minigeek.lan> In-Reply-To: <20250423-01-sun55i-emac0-v1-4-46ee4c855e0a@gentoo.org> References: <20250423-01-sun55i-emac0-v1-0-46ee4c855e0a@gentoo.org> <20250423-01-sun55i-emac0-v1-4-46ee4c855e0a@gentoo.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250423_174449_131187_8D6E515B X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 23 Apr 2025 22:03:25 +0800 Yixun Lan wrote: Hi Yixun, > On Radxa A5E board, the EMAC0 connect to an external YT8531C PHY, > which features a 25MHz crystal, and using PH8 pin as PHY reset. > > Tested on A5E board with schematic V1.20. Can you please add a name to the /aliases node, to make U-Boot add a MAC address? ethernet0 = &emac0; > > Signed-off-by: Yixun Lan > --- > arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts b/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts > index 912e1bda974ce5f64c425e371357b1a78b7c13dd..b3399a28badb5172801e47b8a45d5b753fc56ef1 100644 > --- a/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts > @@ -54,6 +54,23 @@ &ehci1 { > status = "okay"; > }; > > +&emac0 { > + phy-mode = "rgmii"; > + phy-handle = <&ext_rgmii_phy>; Can you please add the phy-supply here, which should be CLDO3? It's referenced by other nodes, so would be enabled already,but each node should be self-contained. Cheers, Andre > + > + allwinner,tx-delay-ps = <300>; > + allwinner,rx-delay-ps = <400>; > + > + status = "okay"; > +}; > + > +&mdio0 { > + ext_rgmii_phy: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + }; > +}; > + > &mmc0 { > vmmc-supply = <®_cldo3>; > cd-gpios = <&pio 5 6 (GPIO_ACTIVE_LOW | GPIO_PULL_DOWN)>; /* PF6 */ >