* [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
@ 2025-04-25 19:48 Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 1/6] arm64: dts: imx8qxp: " Krzysztof Kozlowski
` (7 more replies)
0 siblings, 8 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Not tested on hardware.
Ethernet interface, like other exposed interfaces, aliases depend on
actual board configuration, e.g. its labeling, thus aliases should be
defined per each board or each SoM.
Some boards (e.g. Gateworks) follow this convention but many do not.
This is continuation of my comments from:
https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
Best regards,
Krzysztof
---
Krzysztof Kozlowski (6):
arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI
arm64: dts: imx8dxl: Move Ethernet aliases out of SoC DTSI
arm64: dts: imx8mm: Move Ethernet aliases out of SoC DTSI
arm64: dts: imx8mn: Move Ethernet aliases out of SoC DTSI
arm64: dts: imx8mq: Move Ethernet aliases out of SoC DTSI
arm64: dts: imx8qm: Add Ethernet aliases
arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 2 ++
arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 1 +
arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 2 --
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-phg.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 -
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 -
arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 -
arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 5 +++++
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 1 +
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 --
arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi | 6 ++++++
arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi | 1 +
arch/arm64/boot/dts/freescale/mba8mx.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/mba8xx.dtsi | 2 ++
56 files changed, 143 insertions(+), 7 deletions(-)
---
base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc
change-id: 20250425-dts-imx-aliases-ethernet-37d8552939de
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/6] arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
@ 2025-04-25 19:48 ` Krzysztof Kozlowski
2025-04-28 6:46 ` Alexander Stein
2025-04-25 19:48 ` [PATCH 2/6] arm64: dts: imx8dxl: " Krzysztof Kozlowski
` (6 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Ethernet interface, like other exposed interfaces, aliases depend on
actual board configuration, e.g. its labeling, thus aliases should be
defined per each board or each SoM.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 1 +
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 --
arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi | 6 ++++++
arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi | 1 +
arch/arm64/boot/dts/freescale/mba8xx.dtsi | 2 ++
7 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
index 50bf7919c86305403dc9fe2d75ee312dead03b40..2586cabad31ef61594fbe74247d3868639095320 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
@@ -13,6 +13,7 @@ / {
compatible = "einfochips,imx8qxp-ai_ml", "fsl,imx8qxp";
aliases {
+ ethernet0 = &fec1;
serial1 = &lpuart1;
serial2 = &lpuart2;
serial3 = &lpuart3;
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 4ba8ddd472234704d05db51fb5fb0929e6b15567..b5b14cb20cbef9a67a7661531031fafc702dcbcd 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -12,6 +12,10 @@ / {
model = "Freescale i.MX8QXP MEK";
compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
bt_sco_codec: audio-codec-bt {
compatible = "linux,bt-sco";
#sound-dai-cells = <1>;
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 05138326f0a572f45122f5ee425089f945fdc656..6d8386bdac00d150d272b62ad68c136c0da6ba2d 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -20,8 +20,6 @@ / {
#size-cells = <2>;
aliases {
- ethernet0 = &fec1;
- ethernet1 = &fec2;
gpio0 = &lsio_gpio0;
gpio1 = &lsio_gpio1;
gpio2 = &lsio_gpio2;
diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
index f7bbb2153ae01a2e97f1e28be0c23f9de4172102..7be0b9ecc8aab1f271c1b658babdb316bae41cc6 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
@@ -3,6 +3,12 @@
* Copyright 2018-2021 Toradex
*/
+/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+};
+
/* Colibri Analogue Inputs */
&adc0 {
status = "okay";
diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
index f75499765d85dc78808af9ddadc92e133b0c3499..a7159a842d74306f372db793959cdc8e2555eb3e 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
@@ -7,6 +7,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc_i2c;
rtc1 = &rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
index 54393a0c5cbfcd55dae080a9f07879748bbd4486..1e588d76a6ddb1bd7f94f444d72e2819f267c490 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
@@ -5,6 +5,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc_i2c;
rtc1 = &rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
index c4b5663949ade617fe9b7be20a3aebf0b322623a..a64ae67ef70cc6a624b06f4ab1f3a8ab03ffd1f6 100644
--- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
@@ -16,6 +16,8 @@ adc {
};
aliases {
+ ethernet0 = &fec1;
+ ethernet1 = &fec2;
rtc0 = &pcf85063;
rtc1 = &rtc;
};
--
2.45.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/6] arm64: dts: imx8dxl: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 1/6] arm64: dts: imx8qxp: " Krzysztof Kozlowski
@ 2025-04-25 19:48 ` Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 3/6] arm64: dts: imx8mm: " Krzysztof Kozlowski
` (5 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Ethernet interface, like other exposed interfaces, aliases depend on
actual board configuration, e.g. its labeling, thus aliases should be
defined per each board or each SoM.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 1 +
arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
index 5f3b4014e1521eb2e226797c77d15951cfde3187..1e23ed3a3f396f65e11fb0e5f575f35aa3b1728a 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
@@ -12,6 +12,7 @@ / {
compatible = "fsl,imx8dxl-evk", "fsl,imx8dxl";
aliases {
+ ethernet0 = &fec1;
i2c2 = &i2c2;
mmc0 = &usdhc1;
mmc1 = &usdhc2;
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl.dtsi
index a71d8b32c1920bf9d73020ef48eb98fdbe9adc6f..a14cfcc15cd538c387bbdd325a8b951b00fa712a 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl.dtsi
@@ -19,8 +19,6 @@ / {
#size-cells = <2>;
aliases {
- ethernet0 = &fec1;
- ethernet1 = &eqos;
gpio0 = &lsio_gpio0;
gpio1 = &lsio_gpio1;
gpio2 = &lsio_gpio2;
--
2.45.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/6] arm64: dts: imx8mm: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 1/6] arm64: dts: imx8qxp: " Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 2/6] arm64: dts: imx8dxl: " Krzysztof Kozlowski
@ 2025-04-25 19:48 ` Krzysztof Kozlowski
2025-04-28 6:47 ` Alexander Stein
2025-04-25 19:48 ` [PATCH 4/6] arm64: dts: imx8mn: " Krzysztof Kozlowski
` (4 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Ethernet interface, like other exposed interfaces, aliases depend on
actual board configuration, e.g. its labeling, thus aliases should be
defined per each board or each SoM.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-phg.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 -
arch/arm64/boot/dts/freescale/mba8mx.dtsi | 4 ++++
26 files changed, 70 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index 62ed64663f49521a9c14927886018058e489c914..ffe1d18c5b626253323e45aa1ba2c27e3742ef1e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -7,6 +7,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc;
rtc1 = &snvs_rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
index 472c584fb3bd294dce18341ce1afc277be1c3825..5dd685ffc9825329f739cda32274cb223e88bf15 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
@@ -14,6 +14,7 @@ / {
compatible = "dmo,imx8mm-data-modul-edm-sbc", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc;
rtc1 = &snvs_rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
index af7dc8d1f5f10d5e2eac677af60c7926e95fdac6..ffee784539ffd0e8cdcdfeb97bac817e4c128fba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
@@ -9,6 +9,10 @@
#include "imx8mm.dtsi"
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart1;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
index 90e638b8e92a95214d8c3c719dd2a6db2630ebac..a98316b7dc443cf9bbf7c45ec8d1d8b3847ddd70 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
@@ -15,6 +15,10 @@ / {
compatible = "ees,imx8mm-emtop-baseboard", "ees,imx8mm-emtop-som",
"fsl,imx8mm";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
connector {
compatible = "usb-c-connector";
label = "USB-C";
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index 5f8336217bb88b1d0501e6208c936c51ce23b312..48a76f656fd4302218a430bebc08afb0bc3d09b7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -10,6 +10,10 @@
#include "imx8mm.dtsi"
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart2;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
index 502745402847ea16ea0e53415a9063c6ba9dbffa..5c340bb01a7afc342650f7ea652e281cf0906a2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
@@ -14,6 +14,10 @@ / {
compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
"fsl,imx8mm";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart2;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
index ddac8bc7ae65159314c2f8a9d41eafb51ae4f863..9f70bafcaa4bedcb71d8c467146c92535b23c149 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
@@ -14,6 +14,10 @@ / {
compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm",
"fsl,imx8mm";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart2;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts
index 055faae79930cbdc347f849cfae7ef3b24746b12..e7af6ea80ebc886df82281ae3912b17dbbcb5dbc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts
@@ -12,6 +12,10 @@ / {
model = "InnoComm WB15-EVK";
compatible = "innocomm,wb15-evk", "fsl,imx8mm";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart2;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts
index 33f8d7d1970e0b165c159a788fa0a96cbefb0d82..23fc653a3a45474b2fa1df620fe0f568a8a6fca1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts
@@ -12,6 +12,7 @@ / {
compatible = "kontron,imx8mm-bl-osm-s", "kontron,imx8mm-osm-s", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
ethernet1 = &usbnet;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
index d16490d876874b7bfc9066efdd724bbb52f518b7..5d6a09322f2750b8b1c6dc93b995dac7cabe35a2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
@@ -12,6 +12,7 @@ / {
compatible = "kontron,imx8mm-bl", "kontron,imx8mm-sl", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
ethernet1 = &usbnet;
rtc0 = &rx8900;
rtc1 = &snvs_rtc;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
index 0b123a84018b2978291ccff845332d55022c7c75..ba5f85454d1c78c635363f13f508f363a4aa53aa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
@@ -14,6 +14,10 @@ / {
"toradex,verdin-imx8mm",
"fsl,imx8mm";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
/delete-node/ gpio-keys;
leds {
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
index 12fb79d20b29e21c1984a7077c61803875523c7e..21649620aac4cd32eeae08758cd80eb8be1db2f8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
@@ -10,6 +10,10 @@ / {
model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
reg_vref_1v8: regulator-vref-1v8 {
compatible = "regulator-fixed";
regulator-name = "vref-1v8";
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phg.dts b/arch/arm64/boot/dts/freescale/imx8mm-phg.dts
index a134b183364961afdaca057655dff6a7e248e51f..c3a7435201d9c0f8c5469c1339e3a39ac81e4ffe 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phg.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phg.dts
@@ -12,6 +12,7 @@ / {
compatible = "cloos,imx8mm-phg", "tq,imx8mm-tqma8mqml", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
mmc0 = &usdhc3;
mmc1 = &usdhc2;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
index 672baba4c8d0527f2de002d49aa96d30a6ae2373..db8a8022e86d0671296b202b125446e7856581bc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
@@ -12,6 +12,7 @@ / {
compatible = "phytec,imx8mm-phycore-som", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
rtc0 = &rv3028;
rtc1 = &snvs_rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi
index d3b21203c5f49e9bb697c602d49e3f8ac9c9f603..18f4b30d7e41e8e7ecabc4c0b9fede0ec6376d7a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi
@@ -9,6 +9,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc_i2c;
rtc1 = &snvs_rtc;
mmc0 = &usdhc3;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
index cdfacbc35db57b654f7b965a513cf04cb4a697b9..9d207dc75cf9322c68e5c7032fe5cab58f0f2ad9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
@@ -9,6 +9,10 @@
/ {
model = "Variscite VAR-SOM-MX8MM module";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart4;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
index 5a3b1142ddf4b7d31db2e6e2723e86cc089a96db..1d03e9a32da2d5ec40a751d10cfefae4eefd71e7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
@@ -10,6 +10,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &gsc_rtc;
rtc1 = &snvs_rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 46d1ee0a4ee86b025d94453460770e08b5dd8d32..1f7cc6310d61c98523f0fda92dc1cd060a26c2a2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -18,6 +18,7 @@ / {
compatible = "gw,imx8mm-gw7902", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
ethernet1 = ð1;
rtc0 = &gsc_rtc;
rtc1 = &snvs_rtc;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts
index 86a610de84fe2348554354f838e1d824a24a4322..b1f83f84e7e11446fcfefdc1c7f20a5fdf3e3338 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts
@@ -17,6 +17,7 @@ / {
compatible = "gateworks,imx8mm-gw7904", "fsl,imx8mm";
aliases {
+ ethernet0 = &fec1;
rtc0 = &gsc_rtc;
rtc1 = &snvs_rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
index 3d0b14968131049b15fea3f52d10f60c006f341b..440678d8e933bf60325fea1ca340441451e8e93e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
@@ -4,6 +4,10 @@
*/
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
sound_card: sound-card {
compatible = "simple-audio-card";
simple-audio-card,bitclock-master = <&dailink_master>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
index 1d8d146d9eebad32de81c0f7860be52a4b6d7ef2..570091dded8446cf14fcc1869105f513abef6651 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
@@ -4,6 +4,10 @@
*/
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
sound_card: sound-card {
compatible = "simple-audio-card";
simple-audio-card,bitclock-master = <&dailink_master>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
index 29075ff5eda63b50bc008ad501e96333c6d07325..9c27dab2668defe2bcab46686d2e83433e846665 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
@@ -12,6 +12,10 @@
#include <dt-bindings/leds/common.h>
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
/* AIN1 Voltage w/o AIN1_MODE gpio control */
ain1_voltage_unmanaged: voltage-divider-ain1 {
compatible = "voltage-divider";
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
index 4a0799d63446cdaa0a404091386ce8a4164d5aca..285eb0ba87e53f9adf9e102aac9329146b047a27 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
@@ -11,6 +11,10 @@
#include <dt-bindings/leds/common.h>
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi
index 763f069e8405442f2af7491ff810b8b2375248f2..7df5f44c5f5f438ac28376d1dfb3caa04a077f0d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi
@@ -6,6 +6,10 @@
#include <dt-bindings/leds/common.h>
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
leds {
compatible = "gpio-leds";
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index cfebaa01217eb02b9514c51ae7dabc6cd7b7245a..67c57c071c8ab8d55ef1c93ae155ed08c7c6af30 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -19,7 +19,6 @@ / {
#size-cells = <2>;
aliases {
- ethernet0 = &fec1;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
diff --git a/arch/arm64/boot/dts/freescale/mba8mx.dtsi b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
index 7ee1228a50f4f9bfa46edc62d956b47b906326f5..1b24dfc36c8340b8f5852c2dc37278c8386294d8 100644
--- a/arch/arm64/boot/dts/freescale/mba8mx.dtsi
+++ b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
@@ -8,6 +8,10 @@
/* TQ-Systems GmbH MBa8Mx baseboard */
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
backlight_lvds: backlight {
compatible = "pwm-backlight";
pwms = <&pwm3 0 5000000 0>;
--
2.45.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/6] arm64: dts: imx8mn: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
` (2 preceding siblings ...)
2025-04-25 19:48 ` [PATCH 3/6] arm64: dts: imx8mm: " Krzysztof Kozlowski
@ 2025-04-25 19:48 ` Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 5/6] arm64: dts: imx8mq: " Krzysztof Kozlowski
` (3 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Ethernet interface, like other exposed interfaces, aliases depend on
actual board configuration, e.g. its labeling, thus aliases should be
defined per each board or each SoM.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 -
6 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
index 2a64115eebf1c68b69eb0076aa08558eface5705..625a647e1e8d603ad9399d87d74159da33cb013a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
@@ -7,6 +7,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc;
rtc1 = &snvs_rtc;
spi0 = &flexspi;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
index bbb07c650da9c273a540976142197d9ff1bd5389..d34d37a4a09f328ca19ded10c36aae740196eeef 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi
@@ -10,6 +10,10 @@
#include "imx8mn-bsh-smm-s2-display.dtsi"
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart4;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
index 33d73f3dc18759295207fae76d67100387b86461..f91ce0d9b015f49422aeac9517b4e486e44e4956 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
@@ -7,6 +7,10 @@
#include "imx8mn.dtsi"
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart2;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
index b364307868f25eb05507c651afa6fee8d0c8423f..59fc9ae613bd3aa047c30776ff1bc1f556a53562 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
@@ -11,6 +11,10 @@ / {
model = "Variscite VAR-SOM-MX8MN module";
compatible = "variscite,var-som-mx8mn", "fsl,imx8mn";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart4;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
index 30c286b34aa535e1ac7ef5affd3b9bcb6a81b633..ed91f73802379d63c4b302c7b1d6baf91b8e962a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
@@ -17,6 +17,7 @@ / {
compatible = "gw,imx8mn-gw7902", "fsl,imx8mn";
aliases {
+ ethernet0 = &fec1;
rtc0 = &gsc_rtc;
rtc1 = &snvs_rtc;
usb0 = &usbotg1;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 848ba5e46ee679166e96327f089904f317b0cf95..93a78b40dd41b804707dfce53ed2abd8586b0312 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -19,7 +19,6 @@ / {
#size-cells = <2>;
aliases {
- ethernet0 = &fec1;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
--
2.45.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/6] arm64: dts: imx8mq: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
` (3 preceding siblings ...)
2025-04-25 19:48 ` [PATCH 4/6] arm64: dts: imx8mn: " Krzysztof Kozlowski
@ 2025-04-25 19:48 ` Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 6/6] arm64: dts: imx8qm: Add Ethernet aliases Krzysztof Kozlowski
` (2 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Ethernet interface, like other exposed interfaces, aliases depend on
actual board configuration, e.g. its labeling, thus aliases should be
defined per each board or each SoM.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 +
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ++++
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 -
11 files changed, 34 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
index a87d0692c3bb372f77c04d5190e3741f93a142ec..1d11ebf1c8449541331aea51a6b2841f6e6c790a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -12,6 +12,10 @@ / {
model = "NXP i.MX8MQ EVK";
compatible = "fsl,imx8mq-evk", "fsl,imx8mq";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart1;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
index d8cf1f27c3ec8a33b7ad527c1fc2b489747a2d84..6ab8e2e07b8d403f1fa00ebe2e381e8e7ac5699a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
@@ -15,6 +15,7 @@ / {
compatible = "kontron,pitx-imx8m", "fsl,imx8mq";
aliases {
+ ethernet0 = &fec1;
i2c0 = &i2c1;
i2c1 = &i2c2;
i2c2 = &i2c3;
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index d9f203c795197a8d02e6bfa831df6eacdefdc4b3..b1726e0a46bc591f617f25f9fa3ea39509657aba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -16,6 +16,10 @@ / {
model = "Purism Librem 5 devkit";
compatible = "purism,librem5-devkit", "fsl,imx8mq";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
backlight_dsi: backlight-dsi {
compatible = "pwm-backlight";
/* 200 Hz for the PAM2841 */
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
index 3ae3824be0271f8c5804faf63eaf51aafde9875f..0794abfcb8ac78d7487bde8b2d7008f1b602bd31 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
@@ -14,6 +14,10 @@ / {
compatible = "mntre,reform2", "boundary,imx8mq-nitrogen8m-som", "fsl,imx8mq";
chassis-type = "laptop";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
backlight: backlight {
compatible = "pwm-backlight";
pinctrl-names = "default";
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
index 767819cce886cea8828fff68150f64fd21ad8f89..d84f566b85fd6918052040a71b9915b44c7cb846 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
@@ -12,6 +12,10 @@ / {
model = "Boundary Devices i.MX8MQ Nitrogen8M";
compatible = "boundary,imx8mq-nitrogen8m", "fsl,imx8mq";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = "serial0:115200n8";
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
index e34045d10a12fd8060b0bb5e512ca7d4eae95695..bd9e41e09a03cc692a2228dbee8cc6c51a7cc0c0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
@@ -12,6 +12,10 @@ / {
model = "Google i.MX8MQ Phanbell";
compatible = "google,imx8mq-phanbell", "fsl,imx8mq";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart1;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts b/arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts
index ec89b5adeb93d4a0ae4f8338117c196039961241..e9e54558d77e86744954fa55c9b3f562bfa3c7fc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts
@@ -15,6 +15,10 @@ / {
model = "TechNexion PICO-PI-8M";
compatible = "technexion,pico-pi-imx8m", "fsl,imx8mq";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart1;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi
index efc00f4abeb12ce41325ecc04b50349106a56337..915d14e9961830f181298c9cc394b42ec2f71a62 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi
@@ -6,6 +6,10 @@
#include "imx8mq.dtsi"
/ {
+ aliases {
+ ethernet0 = &fec1;
+ };
+
reg_vdd_3v3: regulator-vdd-3v3 {
compatible = "regulator-fixed";
regulator-always-on;
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
index eaa9d0c0fcc180b42301be5641f33b1ecb6649b5..9b3d9d235ee114b147322e6f7d9cc55fb4e90ba4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
@@ -12,6 +12,10 @@ / {
model = "Einfochips i.MX8MQ Thor96";
compatible = "einfochips,imx8mq-thor96", "fsl,imx8mq";
+ aliases {
+ ethernet0 = &fec1;
+ };
+
chosen {
stdout-path = &uart1;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index c7bbba45f368525e0afa3e22e10bd76b5cf372ac..04dee72be03757abc997a4856c13e778ba5ec056 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -7,6 +7,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
mdio-gpio0 = &mdio0;
rtc0 = &ds1341;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 07925b387677b35766fd0e7ee4b8aff99b587c55..c3cecbf60d8276bb41c58d7f2bc71a3b5d2d97d6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -21,7 +21,6 @@ / {
#size-cells = <2>;
aliases {
- ethernet0 = &fec1;
gpio0 = &gpio1;
gpio1 = &gpio2;
gpio2 = &gpio3;
--
2.45.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 6/6] arm64: dts: imx8qm: Add Ethernet aliases
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
` (4 preceding siblings ...)
2025-04-25 19:48 ` [PATCH 5/6] arm64: dts: imx8mq: " Krzysztof Kozlowski
@ 2025-04-25 19:48 ` Krzysztof Kozlowski
2025-04-29 13:37 ` Oliver Graute
2025-04-29 9:39 ` [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Lucas Stach
2025-04-29 11:59 ` Peng Fan
7 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Add Ethernet aliases for predictable names and for firmware or
bootloader to fill up MAC address.
Suggested-by: Francesco Dolcini <francesco@dolcini.it>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 2 ++
arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 5 +++++
4 files changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi
index dc127298715b3cf73ad93d25aff7b7b56e4049ab..8f976124053e196a556cb9ddf8ff8768ca332099 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi
@@ -5,6 +5,8 @@
/ {
aliases {
+ ethernet0 = &fec1;
+ ethernet1 = &fec2;
rtc0 = &rtc_i2c;
rtc1 = &rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
index d4a1ad528f650d16e9de22e2e21d2e2cc684163e..28e64cc63e644f249b16c37d4a555667bea2f5c2 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi
@@ -7,6 +7,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc_i2c;
rtc1 = &rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
index 5e132c83e1b26b19840aac12d2c1014811c75c78..1f10f31e1e4d40d489e41cc8e65e8673330af07e 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi
@@ -7,6 +7,7 @@
/ {
aliases {
+ ethernet0 = &fec1;
rtc0 = &rtc_i2c;
rtc1 = &rtc;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
index 353f825a8ac5db1ac70d1560318c134d188ae7ef..f0bc77cf07b7da73cbb7b438a045fd56ca921d9b 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
@@ -13,6 +13,11 @@ / {
model = "Freescale i.MX8QM MEK";
compatible = "fsl,imx8qm-mek", "fsl,imx8qm";
+ aliases {
+ ethernet0 = &fec1;
+ ethernet1 = &fec2;
+ };
+
chosen {
stdout-path = &lpuart0;
};
--
2.45.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/6] arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 ` [PATCH 1/6] arm64: dts: imx8qxp: " Krzysztof Kozlowski
@ 2025-04-28 6:46 ` Alexander Stein
0 siblings, 0 replies; 17+ messages in thread
From: Alexander Stein @ 2025-04-28 6:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Krzysztof Kozlowski
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Am Freitag, 25. April 2025, 21:48:24 CEST schrieb Krzysztof Kozlowski:
> Ethernet interface, like other exposed interfaces, aliases depend on
> actual board configuration, e.g. its labeling, thus aliases should be
> defined per each board or each SoM.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> #MBa8Xx
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 --
> arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi | 6 ++++++
> arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi | 1 +
> arch/arm64/boot/dts/freescale/mba8xx.dtsi | 2 ++
> 7 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
> index 50bf7919c86305403dc9fe2d75ee312dead03b40..2586cabad31ef61594fbe74247d3868639095320 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
> @@ -13,6 +13,7 @@ / {
> compatible = "einfochips,imx8qxp-ai_ml", "fsl,imx8qxp";
>
> aliases {
> + ethernet0 = &fec1;
> serial1 = &lpuart1;
> serial2 = &lpuart2;
> serial3 = &lpuart3;
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index 4ba8ddd472234704d05db51fb5fb0929e6b15567..b5b14cb20cbef9a67a7661531031fafc702dcbcd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -12,6 +12,10 @@ / {
> model = "Freescale i.MX8QXP MEK";
> compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> bt_sco_codec: audio-codec-bt {
> compatible = "linux,bt-sco";
> #sound-dai-cells = <1>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 05138326f0a572f45122f5ee425089f945fdc656..6d8386bdac00d150d272b62ad68c136c0da6ba2d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -20,8 +20,6 @@ / {
> #size-cells = <2>;
>
> aliases {
> - ethernet0 = &fec1;
> - ethernet1 = &fec2;
> gpio0 = &lsio_gpio0;
> gpio1 = &lsio_gpio1;
> gpio2 = &lsio_gpio2;
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
> index f7bbb2153ae01a2e97f1e28be0c23f9de4172102..7be0b9ecc8aab1f271c1b658babdb316bae41cc6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
> @@ -3,6 +3,12 @@
> * Copyright 2018-2021 Toradex
> */
>
> +/ {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +};
> +
> /* Colibri Analogue Inputs */
> &adc0 {
> status = "okay";
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> index f75499765d85dc78808af9ddadc92e133b0c3499..a7159a842d74306f372db793959cdc8e2555eb3e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> @@ -7,6 +7,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc_i2c;
> rtc1 = &rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
> index 54393a0c5cbfcd55dae080a9f07879748bbd4486..1e588d76a6ddb1bd7f94f444d72e2819f267c490 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
> @@ -5,6 +5,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc_i2c;
> rtc1 = &rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index c4b5663949ade617fe9b7be20a3aebf0b322623a..a64ae67ef70cc6a624b06f4ab1f3a8ab03ffd1f6 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -16,6 +16,8 @@ adc {
> };
>
> aliases {
> + ethernet0 = &fec1;
> + ethernet1 = &fec2;
> rtc0 = &pcf85063;
> rtc1 = &rtc;
> };
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 3/6] arm64: dts: imx8mm: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 ` [PATCH 3/6] arm64: dts: imx8mm: " Krzysztof Kozlowski
@ 2025-04-28 6:47 ` Alexander Stein
0 siblings, 0 replies; 17+ messages in thread
From: Alexander Stein @ 2025-04-28 6:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Krzysztof Kozlowski
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux, Krzysztof Kozlowski
Am Freitag, 25. April 2025, 21:48:26 CEST schrieb Krzysztof Kozlowski:
> Ethernet interface, like other exposed interfaces, aliases depend on
> actual board configuration, e.g. its labeling, thus aliases should be
> defined per each board or each SoM.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> #MBa8Mx
> ---
> arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-phg.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 -
> arch/arm64/boot/dts/freescale/mba8mx.dtsi | 4 ++++
> 26 files changed, 70 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> index 62ed64663f49521a9c14927886018058e489c914..ffe1d18c5b626253323e45aa1ba2c27e3742ef1e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> @@ -7,6 +7,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc;
> rtc1 = &snvs_rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index 472c584fb3bd294dce18341ce1afc277be1c3825..5dd685ffc9825329f739cda32274cb223e88bf15 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -14,6 +14,7 @@ / {
> compatible = "dmo,imx8mm-data-modul-edm-sbc", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc;
> rtc1 = &snvs_rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> index af7dc8d1f5f10d5e2eac677af60c7926e95fdac6..ffee784539ffd0e8cdcdfeb97bac817e4c128fba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> @@ -9,6 +9,10 @@
> #include "imx8mm.dtsi"
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> chosen {
> stdout-path = &uart1;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
> index 90e638b8e92a95214d8c3c719dd2a6db2630ebac..a98316b7dc443cf9bbf7c45ec8d1d8b3847ddd70 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
> @@ -15,6 +15,10 @@ / {
> compatible = "ees,imx8mm-emtop-baseboard", "ees,imx8mm-emtop-som",
> "fsl,imx8mm";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> connector {
> compatible = "usb-c-connector";
> label = "USB-C";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index 5f8336217bb88b1d0501e6208c936c51ce23b312..48a76f656fd4302218a430bebc08afb0bc3d09b7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -10,6 +10,10 @@
> #include "imx8mm.dtsi"
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> chosen {
> stdout-path = &uart2;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
> index 502745402847ea16ea0e53415a9063c6ba9dbffa..5c340bb01a7afc342650f7ea652e281cf0906a2e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts
> @@ -14,6 +14,10 @@ / {
> compatible = "engicam,icore-mx8mm-ctouch2", "engicam,icore-mx8mm",
> "fsl,imx8mm";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> chosen {
> stdout-path = &uart2;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> index ddac8bc7ae65159314c2f8a9d41eafb51ae4f863..9f70bafcaa4bedcb71d8c467146c92535b23c149 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts
> @@ -14,6 +14,10 @@ / {
> compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm",
> "fsl,imx8mm";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> chosen {
> stdout-path = &uart2;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts
> index 055faae79930cbdc347f849cfae7ef3b24746b12..e7af6ea80ebc886df82281ae3912b17dbbcb5dbc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts
> @@ -12,6 +12,10 @@ / {
> model = "InnoComm WB15-EVK";
> compatible = "innocomm,wb15-evk", "fsl,imx8mm";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> chosen {
> stdout-path = &uart2;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts
> index 33f8d7d1970e0b165c159a788fa0a96cbefb0d82..23fc653a3a45474b2fa1df620fe0f568a8a6fca1 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts
> @@ -12,6 +12,7 @@ / {
> compatible = "kontron,imx8mm-bl-osm-s", "kontron,imx8mm-osm-s", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> ethernet1 = &usbnet;
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
> index d16490d876874b7bfc9066efdd724bbb52f518b7..5d6a09322f2750b8b1c6dc93b995dac7cabe35a2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
> @@ -12,6 +12,7 @@ / {
> compatible = "kontron,imx8mm-bl", "kontron,imx8mm-sl", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> ethernet1 = &usbnet;
> rtc0 = &rx8900;
> rtc1 = &snvs_rtc;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> index 0b123a84018b2978291ccff845332d55022c7c75..ba5f85454d1c78c635363f13f508f363a4aa53aa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts
> @@ -14,6 +14,10 @@ / {
> "toradex,verdin-imx8mm",
> "fsl,imx8mm";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> /delete-node/ gpio-keys;
>
> leds {
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> index 12fb79d20b29e21c1984a7077c61803875523c7e..21649620aac4cd32eeae08758cd80eb8be1db2f8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> @@ -10,6 +10,10 @@ / {
> model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
> compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> reg_vref_1v8: regulator-vref-1v8 {
> compatible = "regulator-fixed";
> regulator-name = "vref-1v8";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phg.dts b/arch/arm64/boot/dts/freescale/imx8mm-phg.dts
> index a134b183364961afdaca057655dff6a7e248e51f..c3a7435201d9c0f8c5469c1339e3a39ac81e4ffe 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phg.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phg.dts
> @@ -12,6 +12,7 @@ / {
> compatible = "cloos,imx8mm-phg", "tq,imx8mm-tqma8mqml", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> mmc0 = &usdhc3;
> mmc1 = &usdhc2;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> index 672baba4c8d0527f2de002d49aa96d30a6ae2373..db8a8022e86d0671296b202b125446e7856581bc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> @@ -12,6 +12,7 @@ / {
> compatible = "phytec,imx8mm-phycore-som", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rv3028;
> rtc1 = &snvs_rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi
> index d3b21203c5f49e9bb697c602d49e3f8ac9c9f603..18f4b30d7e41e8e7ecabc4c0b9fede0ec6376d7a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi
> @@ -9,6 +9,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc_i2c;
> rtc1 = &snvs_rtc;
> mmc0 = &usdhc3;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> index cdfacbc35db57b654f7b965a513cf04cb4a697b9..9d207dc75cf9322c68e5c7032fe5cab58f0f2ad9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> @@ -9,6 +9,10 @@
> / {
> model = "Variscite VAR-SOM-MX8MM module";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> chosen {
> stdout-path = &uart4;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> index 5a3b1142ddf4b7d31db2e6e2723e86cc089a96db..1d03e9a32da2d5ec40a751d10cfefae4eefd71e7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> @@ -10,6 +10,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &gsc_rtc;
> rtc1 = &snvs_rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> index 46d1ee0a4ee86b025d94453460770e08b5dd8d32..1f7cc6310d61c98523f0fda92dc1cd060a26c2a2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> @@ -18,6 +18,7 @@ / {
> compatible = "gw,imx8mm-gw7902", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> ethernet1 = ð1;
> rtc0 = &gsc_rtc;
> rtc1 = &snvs_rtc;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts
> index 86a610de84fe2348554354f838e1d824a24a4322..b1f83f84e7e11446fcfefdc1c7f20a5fdf3e3338 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts
> @@ -17,6 +17,7 @@ / {
> compatible = "gateworks,imx8mm-gw7904", "fsl,imx8mm";
>
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &gsc_rtc;
> rtc1 = &snvs_rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
> index 3d0b14968131049b15fea3f52d10f60c006f341b..440678d8e933bf60325fea1ca340441451e8e93e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
> @@ -4,6 +4,10 @@
> */
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> sound_card: sound-card {
> compatible = "simple-audio-card";
> simple-audio-card,bitclock-master = <&dailink_master>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
> index 1d8d146d9eebad32de81c0f7860be52a4b6d7ef2..570091dded8446cf14fcc1869105f513abef6651 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
> @@ -4,6 +4,10 @@
> */
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> sound_card: sound-card {
> compatible = "simple-audio-card";
> simple-audio-card,bitclock-master = <&dailink_master>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
> index 29075ff5eda63b50bc008ad501e96333c6d07325..9c27dab2668defe2bcab46686d2e83433e846665 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi
> @@ -12,6 +12,10 @@
> #include <dt-bindings/leds/common.h>
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> /* AIN1 Voltage w/o AIN1_MODE gpio control */
> ain1_voltage_unmanaged: voltage-divider-ain1 {
> compatible = "voltage-divider";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
> index 4a0799d63446cdaa0a404091386ce8a4164d5aca..285eb0ba87e53f9adf9e102aac9329146b047a27 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
> @@ -11,6 +11,10 @@
> #include <dt-bindings/leds/common.h>
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi
> index 763f069e8405442f2af7491ff810b8b2375248f2..7df5f44c5f5f438ac28376d1dfb3caa04a077f0d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi
> @@ -6,6 +6,10 @@
> #include <dt-bindings/leds/common.h>
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> leds {
> compatible = "gpio-leds";
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index cfebaa01217eb02b9514c51ae7dabc6cd7b7245a..67c57c071c8ab8d55ef1c93ae155ed08c7c6af30 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -19,7 +19,6 @@ / {
> #size-cells = <2>;
>
> aliases {
> - ethernet0 = &fec1;
> gpio0 = &gpio1;
> gpio1 = &gpio2;
> gpio2 = &gpio3;
> diff --git a/arch/arm64/boot/dts/freescale/mba8mx.dtsi b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
> index 7ee1228a50f4f9bfa46edc62d956b47b906326f5..1b24dfc36c8340b8f5852c2dc37278c8386294d8 100644
> --- a/arch/arm64/boot/dts/freescale/mba8mx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8mx.dtsi
> @@ -8,6 +8,10 @@
> /* TQ-Systems GmbH MBa8Mx baseboard */
>
> / {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> backlight_lvds: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm3 0 5000000 0>;
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
` (5 preceding siblings ...)
2025-04-25 19:48 ` [PATCH 6/6] arm64: dts: imx8qm: Add Ethernet aliases Krzysztof Kozlowski
@ 2025-04-29 9:39 ` Lucas Stach
2025-04-29 11:49 ` Francesco Dolcini
2025-04-29 14:30 ` Krzysztof Kozlowski
2025-04-29 11:59 ` Peng Fan
7 siblings, 2 replies; 17+ messages in thread
From: Lucas Stach @ 2025-04-29 9:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: devicetree, Francesco Dolcini, imx, linux-kernel,
linux-arm-kernel, linux
Hi Krzysztof,
Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski:
> Not tested on hardware.
>
> Ethernet interface, like other exposed interfaces, aliases depend on
> actual board configuration, e.g. its labeling, thus aliases should be
> defined per each board or each SoM.
>
> Some boards (e.g. Gateworks) follow this convention but many do not.
>
> This is continuation of my comments from:
> https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
>
The i.MX boards have traditionally listed aliases for many hardware
peripherals with the same numbering that's used in the SoC reference
manual. Boards always have the option to override those aliases if they
have a good reason to do so, e.g. labeling on the physical device.
Other users besides Linux rely on fixed numbering provided by the
aliases. Both barebox and U-Boot number their ethernet interfaces
according to the alias.
While you seem to add back aliases for in-tree boards, this breaks the
majority of boards that include the kernel DTSI from an out-of-tree
board. I can understand that we can't always accommodate these users,
but I simply don't see the strong benefit of this patch to justify
creating churn and possible regressions with those OOT users.
Having those aliases in the DTSI has been common practice on the i.MX
platform since 2012, long before there was any strong consensus on how
those aliases should be used. Breaking existing users for the sake of
aligning the i.MX platform with more idiomatic DT usage does not seem
to be a worthwhile trade-off to me.
Regards,
Lucas
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (6):
> arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8dxl: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8mm: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8mn: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8mq: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8qm: Add Ethernet aliases
>
> arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 2 ++
> arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 2 --
> arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-phg.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 -
> arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 -
> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 -
> arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 5 +++++
> arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 --
> arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi | 6 ++++++
> arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi | 1 +
> arch/arm64/boot/dts/freescale/mba8mx.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/mba8xx.dtsi | 2 ++
> 56 files changed, 143 insertions(+), 7 deletions(-)
> ---
> base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc
> change-id: 20250425-dts-imx-aliases-ethernet-37d8552939de
>
> Best regards,
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-29 9:39 ` [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Lucas Stach
@ 2025-04-29 11:49 ` Francesco Dolcini
2025-04-29 14:30 ` Krzysztof Kozlowski
1 sibling, 0 replies; 17+ messages in thread
From: Francesco Dolcini @ 2025-04-29 11:49 UTC (permalink / raw)
To: Lucas Stach, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Rob Herring, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
Francesco Dolcini, imx, linux-kernel, linux-arm-kernel, linux
Hello,
On Tue, Apr 29, 2025 at 11:39:20AM +0200, Lucas Stach wrote:
> Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski:
> > Ethernet interface, like other exposed interfaces, aliases depend on
> > actual board configuration, e.g. its labeling, thus aliases should be
> > defined per each board or each SoM.
> >
> Breaking existing users for the sake of aligning the i.MX platform with more
> idiomatic DT usage does not seem to be a worthwhile trade-off to me.
FWIW, I agree with Lucas.
Francesco
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
` (6 preceding siblings ...)
2025-04-29 9:39 ` [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Lucas Stach
@ 2025-04-29 11:59 ` Peng Fan
7 siblings, 0 replies; 17+ messages in thread
From: Peng Fan @ 2025-04-29 11:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux
On Fri, Apr 25, 2025 at 09:48:23PM +0200, Krzysztof Kozlowski wrote:
>Not tested on hardware.
>
>Ethernet interface, like other exposed interfaces, aliases depend on
>actual board configuration, e.g. its labeling, thus aliases should be
>defined per each board or each SoM.
>
>Some boards (e.g. Gateworks) follow this convention but many do not.
>
>This is continuation of my comments from:
>https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
>
>Best regards,
>Krzysztof
>
>---
>Krzysztof Kozlowski (6):
> arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8dxl: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8mm: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8mn: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8mq: Move Ethernet aliases out of SoC DTSI
> arm64: dts: imx8qm: Add Ethernet aliases
>
For the patchset:
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 6/6] arm64: dts: imx8qm: Add Ethernet aliases
2025-04-25 19:48 ` [PATCH 6/6] arm64: dts: imx8qm: Add Ethernet aliases Krzysztof Kozlowski
@ 2025-04-29 13:37 ` Oliver Graute
0 siblings, 0 replies; 17+ messages in thread
From: Oliver Graute @ 2025-04-29 13:37 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel, linux
On 25/04/25, Krzysztof Kozlowski wrote:
> Add Ethernet aliases for predictable names and for firmware or
> bootloader to fill up MAC address.
>
> Suggested-by: Francesco Dolcini <francesco@dolcini.it>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-29 9:39 ` [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Lucas Stach
2025-04-29 11:49 ` Francesco Dolcini
@ 2025-04-29 14:30 ` Krzysztof Kozlowski
2025-04-29 15:13 ` Lucas Stach
1 sibling, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-29 14:30 UTC (permalink / raw)
To: Lucas Stach, Krzysztof Kozlowski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, Francesco Dolcini, imx, linux-kernel,
linux-arm-kernel, linux
On 29/04/2025 11:39, Lucas Stach wrote:
> Hi Krzysztof,
>
> Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski:
>> Not tested on hardware.
>>
>> Ethernet interface, like other exposed interfaces, aliases depend on
>> actual board configuration, e.g. its labeling, thus aliases should be
>> defined per each board or each SoM.
>>
>> Some boards (e.g. Gateworks) follow this convention but many do not.
>>
>> This is continuation of my comments from:
>> https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
>>
> The i.MX boards have traditionally listed aliases for many hardware
> peripherals with the same numbering that's used in the SoC reference
... which is not correct. Aliases should represent how boards are really
labeled, not how reference manual labels them.
> manual. Boards always have the option to override those aliases if they
> have a good reason to do so, e.g. labeling on the physical device.
>
> Other users besides Linux rely on fixed numbering provided by the
> aliases. Both barebox and U-Boot number their ethernet interfaces
> according to the alias.
And?
>
> While you seem to add back aliases for in-tree boards, this breaks the
> majority of boards that include the kernel DTSI from an out-of-tree
> board. I can understand that we can't always accommodate these users,
This is not ABI, so every out of tree user is on their own.
> but I simply don't see the strong benefit of this patch to justify
> creating churn and possible regressions with those OOT users.
They should mainline their code.
It is not only a "churn", but way to stop people from repeating the same
mistake. Every time you bring new soc, people will copy old code thus
this will never change.
>
> Having those aliases in the DTSI has been common practice on the i.MX
> platform since 2012, long before there was any strong consensus on how
Many previous practices were poor practices and decent SoC platforms
fixed and changed it.
We made big cleanups - since ~2 years Samsung is warning free. Since
similar time all Qcom boards use phandle/label override. All of them
were significant effort and quite a shuffling of code. Such effort is
necessary if you want to code to be maintainable and in best shape for
future development.
Unless you claim NXP SoCs are a legacy platform and we should not do
such cleanups.
> those aliases should be used. Breaking existing users for the sake of
> aligning the i.MX platform with more idiomatic DT usage does not seem
> to be a worthwhile trade-off to me.
No existing users are broken. Everyone who decided to stay out of tree
is on their own, but this was their choice. We are not talking here
about ABI.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-29 14:30 ` Krzysztof Kozlowski
@ 2025-04-29 15:13 ` Lucas Stach
2025-04-29 15:17 ` Krzysztof Kozlowski
0 siblings, 1 reply; 17+ messages in thread
From: Lucas Stach @ 2025-04-29 15:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, Francesco Dolcini, imx, linux-kernel,
linux-arm-kernel, linux
Am Dienstag, dem 29.04.2025 um 16:30 +0200 schrieb Krzysztof Kozlowski:
> On 29/04/2025 11:39, Lucas Stach wrote:
> > Hi Krzysztof,
> >
> > Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski:
> > > Not tested on hardware.
> > >
> > > Ethernet interface, like other exposed interfaces, aliases depend on
> > > actual board configuration, e.g. its labeling, thus aliases should be
> > > defined per each board or each SoM.
> > >
> > > Some boards (e.g. Gateworks) follow this convention but many do not.
> > >
> > > This is continuation of my comments from:
> > > https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
> > >
> > The i.MX boards have traditionally listed aliases for many hardware
> > peripherals with the same numbering that's used in the SoC reference
>
> ... which is not correct. Aliases should represent how boards are really
> labeled, not how reference manual labels them.
>
While that is the commonly agreed interpretation today, I do not see
any language in the DT spec itself or kernel Documentation/devicetree
that would mandate aliases to be used in this way.
In fact there are examples to the contrary like
Documentation/devicetree/bindings/serial/samsung_uart.yaml which says:
"Each Samsung UART should have an alias [...] as specified by User's
Manual of respective SoC."
So I would argue that there is no hard line between correct/incorrect
for the historical usage of the alias nodes on the i.MX platform.
> > manual. Boards always have the option to override those aliases if they
> > have a good reason to do so, e.g. labeling on the physical device.
> >
> > Other users besides Linux rely on fixed numbering provided by the
> > aliases. Both barebox and U-Boot number their ethernet interfaces
> > according to the alias.
>
> And?
>
Some usecases depend on the aliases being the same between kernel and
bootloader. Historically that has been guaranteed on the i.MX platform
by the aliases in the SoC DTSI, when the board didn't have a need to
change them. With this series applied some other users may now end up
with missing aliases if the only include the DTSI.
> >
> > While you seem to add back aliases for in-tree boards, this breaks the
> > majority of boards that include the kernel DTSI from an out-of-tree
> > board. I can understand that we can't always accommodate these users,
>
> This is not ABI, so every out of tree user is on their own.
I am not too sympathetic about out-of-tree users myself, but I don't
think we should make their life harder deliberately.
>
> > but I simply don't see the strong benefit of this patch to justify
> > creating churn and possible regressions with those OOT users.
>
> They should mainline their code.
>
> It is not only a "churn", but way to stop people from repeating the same
> mistake. Every time you bring new soc, people will copy old code thus
> this will never change.
>
In this specific case I don't see a need to change the existing code.
If new SoCs should change the alias use, this is something that can be
implemented on the SoC maintainer level. No need to introduce churn on
the existing platforms to enforce a new rule for newly introduced SoCs.
> >
> > Having those aliases in the DTSI has been common practice on the i.MX
> > platform since 2012, long before there was any strong consensus on how
>
> Many previous practices were poor practices and decent SoC platforms
> fixed and changed it.
>
> We made big cleanups - since ~2 years Samsung is warning free. Since
> similar time all Qcom boards use phandle/label override. All of them
> were significant effort and quite a shuffling of code. Such effort is
> necessary if you want to code to be maintainable and in best shape for
> future development.
>
> Unless you claim NXP SoCs are a legacy platform and we should not do
> such cleanups.
>
As I don't see the current usage as objectively wrong, I don't see the
need to do this cleanup/rework to the existing SoC DTSIs.
> > those aliases should be used. Breaking existing users for the sake of
> > aligning the i.MX platform with more idiomatic DT usage does not seem
> > to be a worthwhile trade-off to me.
>
> No existing users are broken. Everyone who decided to stay out of tree
> is on their own, but this was their choice. We are not talking here
> about ABI.
Yes, there is no formal ABI guarantee with this anywhere, so we can
break out-of-tree user when needed. However, I don't think the
improvements in this patchset justify such breakage.
Regards,
Lucas
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-29 15:13 ` Lucas Stach
@ 2025-04-29 15:17 ` Krzysztof Kozlowski
2025-04-29 15:43 ` Lucas Stach
0 siblings, 1 reply; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-29 15:17 UTC (permalink / raw)
To: Lucas Stach, Krzysztof Kozlowski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, Francesco Dolcini, imx, linux-kernel,
linux-arm-kernel, linux
On 29/04/2025 17:13, Lucas Stach wrote:
> Am Dienstag, dem 29.04.2025 um 16:30 +0200 schrieb Krzysztof Kozlowski:
>> On 29/04/2025 11:39, Lucas Stach wrote:
>>> Hi Krzysztof,
>>>
>>> Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski:
>>>> Not tested on hardware.
>>>>
>>>> Ethernet interface, like other exposed interfaces, aliases depend on
>>>> actual board configuration, e.g. its labeling, thus aliases should be
>>>> defined per each board or each SoM.
>>>>
>>>> Some boards (e.g. Gateworks) follow this convention but many do not.
>>>>
>>>> This is continuation of my comments from:
>>>> https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
>>>>
>>> The i.MX boards have traditionally listed aliases for many hardware
>>> peripherals with the same numbering that's used in the SoC reference
>>
>> ... which is not correct. Aliases should represent how boards are really
>> labeled, not how reference manual labels them.
>>
> While that is the commonly agreed interpretation today, I do not see
> any language in the DT spec itself or kernel Documentation/devicetree
> that would mandate aliases to be used in this way.
>
> In fact there are examples to the contrary like
> Documentation/devicetree/bindings/serial/samsung_uart.yaml which says:
> "Each Samsung UART should have an alias [...] as specified by User's
> Manual of respective SoC."
And that is an ABI. Did I affect ABI here?
>
> So I would argue that there is no hard line between correct/incorrect
> for the historical usage of the alias nodes on the i.MX platform.
There is. ABI is documented. There are things which turn out ABI, even
though they are not documented, like node names. Was there a problem
with refactoring these in NXP?
No.
>
>>> manual. Boards always have the option to override those aliases if they
>>> have a good reason to do so, e.g. labeling on the physical device.
>>>
>>> Other users besides Linux rely on fixed numbering provided by the
>>> aliases. Both barebox and U-Boot number their ethernet interfaces
>>> according to the alias.
>>
>> And?
>>
> Some usecases depend on the aliases being the same between kernel and
> bootloader. Historically that has been guaranteed on the i.MX platform
> by the aliases in the SoC DTSI, when the board didn't have a need to
I know.
> change them. With this series applied some other users may now end up
> with missing aliases if the only include the DTSI.
Bring actual case, what is broken by this changeset.
>
>>>
>>> While you seem to add back aliases for in-tree boards, this breaks the
>>> majority of boards that include the kernel DTSI from an out-of-tree
>>> board. I can understand that we can't always accommodate these users,
>>
>> This is not ABI, so every out of tree user is on their own.
>
> I am not too sympathetic about out-of-tree users myself, but I don't
> think we should make their life harder deliberately.
We are making our life easier by maintaining and improving source code:
e.g. not creating fake aliases for devices which do not exist on given
board.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI
2025-04-29 15:17 ` Krzysztof Kozlowski
@ 2025-04-29 15:43 ` Lucas Stach
0 siblings, 0 replies; 17+ messages in thread
From: Lucas Stach @ 2025-04-29 15:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, Francesco Dolcini, imx, linux-kernel,
linux-arm-kernel, linux
Am Dienstag, dem 29.04.2025 um 17:17 +0200 schrieb Krzysztof Kozlowski:
> On 29/04/2025 17:13, Lucas Stach wrote:
> > Am Dienstag, dem 29.04.2025 um 16:30 +0200 schrieb Krzysztof Kozlowski:
> > > On 29/04/2025 11:39, Lucas Stach wrote:
> > > > Hi Krzysztof,
> > > >
> > > > Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski:
> > > > > Not tested on hardware.
> > > > >
> > > > > Ethernet interface, like other exposed interfaces, aliases depend on
> > > > > actual board configuration, e.g. its labeling, thus aliases should be
> > > > > defined per each board or each SoM.
> > > > >
> > > > > Some boards (e.g. Gateworks) follow this convention but many do not.
> > > > >
> > > > > This is continuation of my comments from:
> > > > > https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org
> > > > >
> > > > The i.MX boards have traditionally listed aliases for many hardware
> > > > peripherals with the same numbering that's used in the SoC reference
> > >
> > > ... which is not correct. Aliases should represent how boards are really
> > > labeled, not how reference manual labels them.
> > >
> > While that is the commonly agreed interpretation today, I do not see
> > any language in the DT spec itself or kernel Documentation/devicetree
> > that would mandate aliases to be used in this way.
> >
> > In fact there are examples to the contrary like
> > Documentation/devicetree/bindings/serial/samsung_uart.yaml which says:
> > "Each Samsung UART should have an alias [...] as specified by User's
> > Manual of respective SoC."
>
> And that is an ABI. Did I affect ABI here?
>
> >
> > So I would argue that there is no hard line between correct/incorrect
> > for the historical usage of the alias nodes on the i.MX platform.
>
> There is. ABI is documented. There are things which turn out ABI, even
> though they are not documented, like node names. Was there a problem
> with refactoring these in NXP?
>
> No.
>
In fact there was significant fallout from the node name changes, as
assumptions in bootloader code on how to fix up DTs passed to the
kernel were invalidated. We did not make a fuzz about those cases and
just fixed the breakage in the bootloader, because we agreed with the
overall benefit of those changes to the i.MX ecosystem.
>
> >
> > > > manual. Boards always have the option to override those aliases if they
> > > > have a good reason to do so, e.g. labeling on the physical device.
> > > >
> > > > Other users besides Linux rely on fixed numbering provided by the
> > > > aliases. Both barebox and U-Boot number their ethernet interfaces
> > > > according to the alias.
> > >
> > > And?
> > >
> > Some usecases depend on the aliases being the same between kernel and
> > bootloader. Historically that has been guaranteed on the i.MX platform
> > by the aliases in the SoC DTSI, when the board didn't have a need to
>
> I know.
>
> > change them. With this series applied some other users may now end up
> > with missing aliases if the only include the DTSI.
>
> Bring actual case, what is broken by this changeset.
>
> >
> > > >
> > > > While you seem to add back aliases for in-tree boards, this breaks the
> > > > majority of boards that include the kernel DTSI from an out-of-tree
> > > > board. I can understand that we can't always accommodate these users,
> > >
> > > This is not ABI, so every out of tree user is on their own.
> >
> > I am not too sympathetic about out-of-tree users myself, but I don't
> > think we should make their life harder deliberately.
>
> We are making our life easier by maintaining and improving source code:
> e.g. not creating fake aliases for devices which do not exist on given
> board.
Sorry, I disagree with this sweeping statement when looking at the
specific changes in this patchset. I simply do not see how this change
significantly improves future maintenance of existing DTs for the i.MX
platform to justify the breakage inflicted upon existing OOT users.
I'm not the one to decide whether or not to take those patches, but
IMHO the overall benefit of those patches to the i.MX ecosystem is not
a net positive.
Regards,
Lucas
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2025-04-29 16:12 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-25 19:48 [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 1/6] arm64: dts: imx8qxp: " Krzysztof Kozlowski
2025-04-28 6:46 ` Alexander Stein
2025-04-25 19:48 ` [PATCH 2/6] arm64: dts: imx8dxl: " Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 3/6] arm64: dts: imx8mm: " Krzysztof Kozlowski
2025-04-28 6:47 ` Alexander Stein
2025-04-25 19:48 ` [PATCH 4/6] arm64: dts: imx8mn: " Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 5/6] arm64: dts: imx8mq: " Krzysztof Kozlowski
2025-04-25 19:48 ` [PATCH 6/6] arm64: dts: imx8qm: Add Ethernet aliases Krzysztof Kozlowski
2025-04-29 13:37 ` Oliver Graute
2025-04-29 9:39 ` [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Lucas Stach
2025-04-29 11:49 ` Francesco Dolcini
2025-04-29 14:30 ` Krzysztof Kozlowski
2025-04-29 15:13 ` Lucas Stach
2025-04-29 15:17 ` Krzysztof Kozlowski
2025-04-29 15:43 ` Lucas Stach
2025-04-29 11:59 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).