public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Georgi Djakov <djakov@kernel.org>, Lee Jones <lee@kernel.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Leo Yan <leo.yan@linux.dev>, David Heidelberg <david@ixit.cz>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: [PATCH v3 11/11] ARM: dts: qcom: apq8064: move replicator out of soc node
Date: Fri, 25 Apr 2025 20:47:11 +0300	[thread overview]
Message-ID: <20250425-fix-nexus-4-v3-11-da4e39e86d41@oss.qualcomm.com> (raw)
In-Reply-To: <20250425-fix-nexus-4-v3-0-da4e39e86d41@oss.qualcomm.com>

The CoreSight static replicator device isn't a part of the system MMIO
bus, as such it should not be a part of the soc node. Follow the example
of other platforms and move it out of the soc bus to the top-level (and
reoder ports to follow alphabetic order).

Fixes: 7a5c275fd821 ("ARM: dts: qcom: Add apq8064 CoreSight components")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 67 ++++++++++++++++----------------
 1 file changed, 34 insertions(+), 33 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
index b6533630e347c8fc5e3f0791778cd05760b3f3c8..b02e6739ccb20a287095d8c3e212040e4ac50fdd 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
@@ -278,6 +278,40 @@ scm {
 		};
 	};
 
+	replicator {
+		compatible = "arm,coresight-static-replicator";
+
+		clocks = <&rpmcc RPM_QDSS_CLK>;
+		clock-names = "apb_pclk";
+
+		in-ports {
+			port {
+				replicator_in: endpoint {
+					remote-endpoint = <&funnel_out>;
+				};
+			};
+		};
+
+		out-ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				replicator_out0: endpoint {
+					remote-endpoint = <&etb_in>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				replicator_out1: endpoint {
+					remote-endpoint = <&tpiu_in>;
+				};
+			};
+		};
+	};
+
 	soc: soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -1529,39 +1563,6 @@ tpiu_in: endpoint {
 			};
 		};
 
-		replicator {
-			compatible = "arm,coresight-static-replicator";
-
-			clocks = <&rpmcc RPM_QDSS_CLK>;
-			clock-names = "apb_pclk";
-
-			out-ports {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				port@0 {
-					reg = <0>;
-					replicator_out0: endpoint {
-						remote-endpoint = <&etb_in>;
-					};
-				};
-				port@1 {
-					reg = <1>;
-					replicator_out1: endpoint {
-						remote-endpoint = <&tpiu_in>;
-					};
-				};
-			};
-
-			in-ports {
-				port {
-					replicator_in: endpoint {
-						remote-endpoint = <&funnel_out>;
-					};
-				};
-			};
-		};
-
 		funnel@1a04000 {
 			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
 			reg = <0x1a04000 0x1000>;

-- 
2.39.5



  parent reply	other threads:[~2025-04-25 18:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 17:47 [PATCH v3 00/11] ARM: qcom: fix APQ8064 schema warnings Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 01/11] Revert "dt-bindings: mfd: syscon: Add qcom,apq8064-mmss-sfpb" Dmitry Baryshkov
2025-04-28  7:07   ` Krzysztof Kozlowski
2025-04-28  7:09     ` Dmitry Baryshkov
2025-04-28  7:09     ` Krzysztof Kozlowski
2025-04-28 10:49       ` Dmitry Baryshkov
2025-04-28 17:50         ` Krzysztof Kozlowski
2025-04-29 12:23           ` Dmitry Baryshkov
2025-04-30  9:07   ` Lee Jones
2025-04-25 17:47 ` [PATCH v3 02/11] dt-bindings: mfd: syscon: add qcom,apq8064-mmss-sfpb Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 03/11] dt-bindings: mfd: syscon: add qcom,apq8064-sps-sic Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 04/11] dt-bindings: soc: qcom,rpm: add missing clock-controller node Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 05/11] dt-bindings: soc: qcom: qcom,rpm: add missing clock/-names properties Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 06/11] dt-bindings: arm: arm,coresight-static-replicator: add optional clocks Dmitry Baryshkov
2025-04-28  9:06   ` Suzuki K Poulose
2025-04-28 10:17     ` Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 07/11] ARM: dts: qcom: apq8064: add missing clocks to the timer node Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 08/11] ARM: dts: qcom: apq8064 merge hw splinlock into corresponding syscon device Dmitry Baryshkov
2025-04-25 17:47 ` [PATCH v3 09/11] ARM: dts: qcom: apq8064: use new compatible for SFPB device Dmitry Baryshkov
2025-04-25 19:49   ` Konrad Dybcio
2025-04-25 17:47 ` [PATCH v3 10/11] ARM: dts: qcom: apq8064: use new compatible for SPS SIC device Dmitry Baryshkov
2025-04-25 19:51   ` Konrad Dybcio
2025-04-25 17:47 ` Dmitry Baryshkov [this message]
2025-04-29 17:53 ` [PATCH v3 00/11] (subset) ARM: qcom: fix APQ8064 schema warnings Suzuki K Poulose
2025-05-01 13:17 ` (subset) [PATCH v3 00/11] " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250425-fix-nexus-4-v3-11-da4e39e86d41@oss.qualcomm.com \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=james.clark@linaro.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox