From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80755C369D1 for ; Fri, 25 Apr 2025 07:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rRsnxO+fGByVz7l/DP8ar0dvfrnHkxYBroJVEHBbQgo=; b=CzyxtpMusbVeVxwBow0a0DOExm +ziDg11hJnsZ1Dcu0Sz6nvVDGxeajq/vluTbMsHQ7QgawlicK+aGYNXJF2ttMAoH6UMdSefF2rFTB Aoc6gdskuE0c4gVEFWkPNB6L/jhZfXZE2zzyJs4PtmearPJqIZS8UnXZgAsd5pcl8nWxuBWagIeO/ woHD/FgS+kdbvmfcm0p5sn0YFRKVTy46pGCDP5en5GTJ6h7SYD4tAcYvOlp5ysJi+cXQolHucVYM6 8oqqHZlL5B48NLR6jqtC7JOca3y4QWd7SX+FhPb60QZS4NniJr20MIGm5pp744EZ505GHBNmrfyT2 5+7ED4LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u8DAb-0000000G8dG-0vy7; Fri, 25 Apr 2025 07:08:21 +0000 Received: from smtp.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u8D8k-0000000G8WJ-2uNf for linux-arm-kernel@lists.infradead.org; Fri, 25 Apr 2025 07:06:27 +0000 Received: from localhost (unknown [116.232.18.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id CE285340BEA; Fri, 25 Apr 2025 07:06:24 +0000 (UTC) Date: Fri, 25 Apr 2025 07:06:20 +0000 From: Yixun Lan To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Maxime Ripard , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andre Przywara , Corentin Labbe , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 3/5] arm64: dts: allwinner: a523: Add EMAC0 ethernet MAC Message-ID: <20250425070120-GYB50408@gentoo> References: <20250424-01-sun55i-emac0-v2-0-833f04d23e1d@gentoo.org> <20250424-01-sun55i-emac0-v2-3-833f04d23e1d@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250425_000626_763328_D3426D57 X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chen-Yu, On 13:26 Fri 25 Apr , Chen-Yu Tsai wrote: > On Thu, Apr 24, 2025 at 6:09 PM Yixun Lan wrote: > > > > Add EMAC0 ethernet MAC support which found on A523 variant SoCs, > > including the A527/T527 chips. MAC0 is compatible to the A64 chip which > > requires an external PHY. This patch only add RGMII pins for now. > > > > Signed-off-by: Yixun Lan > > --- > > arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 40 ++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > > index ee485899ba0af69f32727a53de20051a2e31be1d..c9a9b9dd479af05ba22fe9d783e32f6d61a74ef7 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > > @@ -126,6 +126,15 @@ pio: pinctrl@2000000 { > > interrupt-controller; > > #interrupt-cells = <3>; > > > > + rgmii0_pins: rgmii0-pins { > > + pins = "PH0", "PH1", "PH2", "PH3", "PH4", > > + "PH5", "PH6", "PH7", "PH9", "PH10", > > + "PH14", "PH15", "PH16", "PH17", "PH18"; > > + allwinner,pinmux = <5>; > > + function = "emac0"; > > + drive-strength = <40>; > > We should probably add > > bias-disable; > > to explicitly turn off pull-up and pull-down. > I will test this and address in v3 (saw your comment in v1, but I sent v2 too quickly) -- Yixun Lan (dlan)