[PATCH net-next v7 0/3] net: ethtool: Introduce ethnl dump helpers

Maxime Chevallier
2025-04-22T19:47:28Z

Hi everyone,

This is V7 for per-phy DUMP helpers, improving support for ->dumpit()
operations for PHY targetting commands.

This V7 simply contains a conversion from dev_hold() to netdev_hold(),
I also included a patch converting the original ->dumpit(). As this
refcounting is still a bit obscure to me, let me know if I'm getting
this wrong...

Thanks,

Maxime

Changes in V7:
- Move from dev_hold to netdev_hold()
- Add an extra patch fr dev_hold() conversion.

Changes in V6:
- Squash pse and plca patches into the first one, to avoid unused
functions (Jakub)

Changes in V5:
- Move to a less generic approach, focusing only on the PHY case.

Changes in V4:
- Don't grab rcu_read_lock when we already have a refcounter netdev on
the filtered dump path (Paolo)
- Move the dump_all stuff in a dedicated helper (Paolo)
- Added patch 1 to set the dev in ctx->req_info

Changes in V3:
- Fixed some typos and xmas tree issues
- Added a missing check for EOPNOTSUPP in patch 1
- Added missing kdoc
- Added missing comments in phy_reply_size

Changes in V2:
- Rebased on the netdev_lock work by Stanislav and the fixes from Eric
- Fixed a bissectability issue
- Fixed kdoc for the new ethnl ops and fields

V1: https://lore.kernel.org/netdev/20250305141938.319282-1-maxime.chevallier@bootlin.com/
V2: https://lore.kernel.org/netdev/20250308155440.267782-1-maxime.chevallier@bootlin.com/
V3: https://lore.kernel.org/netdev/20250313182647.250007-1-maxime.chevallier@bootlin.com/
V4: https://lore.kernel.org/netdev/20250324104012.367366-1-maxime.chevallier@bootlin.com/
V5: https://lore.kernel.org/netdev/20250410123350.174105-1-maxime.chevallier@bootlin.com/
V6: https://lore.kernel.org/netdev/20250415085155.132963-1-maxime.chevallier@bootlin.com/

Maxime Chevallier (3):
net: ethtool: Introduce per-PHY DUMP operations
net: ethtool: phy: Convert the PHY_GET command to generic phy dump
net: ethtool: netlink: Use netdev_hold for dumpit() operations

net/ethtool/netlink.c | 195 ++++++++++++++++++++++--
net/ethtool/netlink.h | 4 -
net/ethtool/phy.c | 342 ++++++++++++------------------------------
3 files changed, 276 insertions(+), 265 deletions(-)

--
2.49.0