Re: [PATCH v6 net-next 00/14] Add more features for ENETC v4 - round 2

Vladimir Oltean
2025-04-28T16:19:04Z

Hi Wei,

On Mon, Apr 28, 2025 at 06:56:43PM +0800, Wei Fang wrote:
> This patch set adds the following features.
> 1. Compared with ENETC v1, the formats of tables and command BD of ENETC
> v4 have changed significantly, and the two are not compatible. Therefore,
> in order to support the NETC Table Management Protocol (NTMP) v2.0, we
> introduced the netc-lib driver and added support for MAC address filter
> table and RSS table.
> 2. Add MAC filter and VLAN filter support for i.MX95 ENETC PF.
> 3. Add RSS support for i.MX95 ENETC PF.
> 4. Add loopback support for i.MX95 ENETC PF.

I don't see any functional issues with this set. I am also not sure
whether MAC address filtering is implemented in the simplest way, but I
suppose it can also be simplified over time.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>