Re: [PATCH v2 1/3] dt-bindings: phy: imx8mq-usb: improve some tuning properties

Krzysztof Kozlowski
2025-04-29T15:16:28Z

On 29/04/2025 05:30, Xu Yang wrote:
> Commit b2e75563dc39 ("dt-bindings: phy: imx8mq-usb: add phy tuning
> properties") add many tuning properties, but some parameter value doesn't
> match the register description. It made some changes based on the original
> value: add offset to a negative number so turn it to a non-negative number.
> However, it's not easy to find an exact tuning value from register field
> with such conversion.
>
> Because device-tree supports negative parameter number, this will improve
> some propertie's parameter.
>
> Mainly include below properties:
> - fsl,phy-tx-vref-tune-percent
> - fsl,phy-tx-rise-tune-percent
> - fsl,phy-comp-dis-tune-percent
>
> The parameter value of above 3 properties are USB PHY specific. i.MX8MP
> and i.MX95 USB PHY has different meanings. So this add restrictions for
> them.
>
> - fsl,phy-tx-vboost-level-microvolt
>
> For this property, the parameter value is wrong in register description.
> This will correct it according to true value.
>
> For detailed info, please refer to i.MX8MP and i.MX95 latest reference
> manual.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - keep widest constraints
> - use multipleOf for some properties
> ---
> .../bindings/phy/fsl,imx8mq-usb-phy.yaml | 60 +++++++++++++++----
> 1 file changed, 49 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
> index daee0c0fc915..71e5940ef4b8 100644
> --- a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
> @@ -42,16 +42,17 @@ properties:
>
> fsl,phy-tx-vref-tune-percent:
> description:
> - Tunes the HS DC level relative to the nominal level
> - minimum: 94
> - maximum: 124
> + Tunes the HS DC level relative to the nominal level. It varies
> + between different PHY versions
> + minimum: -1000
> + maximum: 875

Nothing improved here. You just sent v2 ignoring reviewers feedback.

NAK
Best regards,
Krzysztof