From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1592C369CB for ; Tue, 29 Apr 2025 07:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eyqiKFHppWJecvLWPqnoqiZIgBN9McBLLBAx3iq3BJc=; b=ZimMCfK6+ayHrDR5Os4eiXgvNb jpxHs7HbMs3A1HxgNa3UcV10PFn/X0UuK/xNUaMeE48YWa1egINPxngtujsPexQrE8r7LDqJVIIi+ npTZB3jrBkB5+R8ZNxIiyITVEWy1Setne+xFO3oy3l/suY8V0jLm6avset3EX0hGsLXgYHRjV2T/M qJLG3JjNfu6mTEBS24I7Q/R8WLn2wLd6H93xRF2qh9K+Nteh49p2I0xlFHbJKvReYwdThFUcWsyVq ncEXJYG7EspQklWFadHcRnAFgaokaiFhroL9HQeUue9+1MVIKiisrfFohGjl6orpXGA8Apwq2HaBo pTPvq6DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9fOe-00000008ks1-043p; Tue, 29 Apr 2025 07:28:52 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9fGW-00000008jH1-0JyJ for linux-arm-kernel@lists.infradead.org; Tue, 29 Apr 2025 07:20:29 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4104E43A54; Tue, 29 Apr 2025 07:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745911225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyqiKFHppWJecvLWPqnoqiZIgBN9McBLLBAx3iq3BJc=; b=AOlvZUbDeCYCofu6N6SVZm37ESGY0nMlrkfxQ5dAN84Fq2iaUrmBO4hxGrIsQgFwXG8jKs r57awTqRSW9gLM820C44Qz1M7D7XZU6f9KW4R8dL9Xf/84rIH1G3jtt2bZKdjBno9Hls6f P4AQqF7HAo4UfNJUbivJW5ZU89QK5OyBMKq5HmZXZSqsjOf2bU271p/xax7yIUknv7bfHm 235bRBUyIr7mgFAvzPiNzKEC5Ek2rVNPMtQjlIm5hdoMuyTHGlsqy0eJ6IPLTOS9nipI1K YjpjNrjhwy7LNygVeqRYRqdCSAheOXzlkDZcggURgMnTYzkbo8vbJPrt5EbYdA== Date: Tue, 29 Apr 2025 09:20:22 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Marek =?UTF-8?B?QmVow7pu?= , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Romain Gantois , Daniel Golle , Dimitri Fedrau Subject: Re: [PATCH net-next v5 03/14] net: phy: Introduce PHY ports representation Message-ID: <20250429092022.1463d5bf@device-130.home> In-Reply-To: <20250428171102.37455ad6@kernel.org> References: <20250425141511.182537-1-maxime.chevallier@bootlin.com> <20250425141511.182537-4-maxime.chevallier@bootlin.com> <20250428171102.37455ad6@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieefvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpeforgigihhmvgcuvehhvghvrghllhhivghruceomhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeevledtvdevueehhfevhfelhfekveeftdfgiedufeffieeltddtgfefuefhueeknecukfhppedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjedphhgvlhhopeguvghvihgtvgdqudeftddrhhhomhgvpdhmrghilhhfrhhomhepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedtpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhor hhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqmhhsmhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdprhgtphhtthhopegrnhgurhgvfieslhhunhhnrdgthhdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhm X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250429_002028_310778_CEE5B2C5 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jakub, On Mon, 28 Apr 2025 17:11:02 -0700 Jakub Kicinski wrote: > On Fri, 25 Apr 2025 16:14:56 +0200 Maxime Chevallier wrote: > > +/** > > + * phy_port_get_type: get the PORT_* attribut for that port. > > + */ > > +int phy_port_get_type(struct phy_port *port) > > Bunch of missing argument descriptions in the kdoc in this patch. Thanks for taking a look :) I'll address the kdoc for next time I'll wait a bit before re-spin, to get a chance to get some feedback on the whole thing from the PHY folks. Maxime