Re: [PATCH 1/6] arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI

Alexander Stein
2025-04-28T06:49:07Z

Am Freitag, 25. April 2025, 21:48:24 CEST schrieb Krzysztof Kozlowski:
> Ethernet interface, like other exposed interfaces, aliases depend on
> actual board configuration, e.g. its labeling, thus aliases should be
> defined per each board or each SoM.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> #MBa8Xx

> ---
> arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 1 +
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 ++++
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 --
> arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi | 6 ++++++
> arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi | 1 +
> arch/arm64/boot/dts/freescale/mba8xx.dtsi | 2 ++
> 7 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
> index 50bf7919c86305403dc9fe2d75ee312dead03b40..2586cabad31ef61594fbe74247d3868639095320 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
> @@ -13,6 +13,7 @@ / {
> compatible = "einfochips,imx8qxp-ai_ml", "fsl,imx8qxp";
>
> aliases {
> + ethernet0 = &fec1;
> serial1 = &lpuart1;
> serial2 = &lpuart2;
> serial3 = &lpuart3;
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index 4ba8ddd472234704d05db51fb5fb0929e6b15567..b5b14cb20cbef9a67a7661531031fafc702dcbcd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -12,6 +12,10 @@ / {
> model = "Freescale i.MX8QXP MEK";
> compatible = "fsl,imx8qxp-mek", "fsl,imx8qxp";
>
> + aliases {
> + ethernet0 = &fec1;
> + };
> +
> bt_sco_codec: audio-codec-bt {
> compatible = "linux,bt-sco";
> #sound-dai-cells = <1>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 05138326f0a572f45122f5ee425089f945fdc656..6d8386bdac00d150d272b62ad68c136c0da6ba2d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -20,8 +20,6 @@ / {
> #size-cells = <2>;
>
> aliases {
> - ethernet0 = &fec1;
> - ethernet1 = &fec2;
> gpio0 = &lsio_gpio0;
> gpio1 = &lsio_gpio1;
> gpio2 = &lsio_gpio2;
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
> index f7bbb2153ae01a2e97f1e28be0c23f9de4172102..7be0b9ecc8aab1f271c1b658babdb316bae41cc6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
> @@ -3,6 +3,12 @@
> * Copyright 2018-2021 Toradex
> */
>
> +/ {
> + aliases {
> + ethernet0 = &fec1;
> + };
> +};
> +
> /* Colibri Analogue Inputs */
> &adc0 {
> status = "okay";
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> index f75499765d85dc78808af9ddadc92e133b0c3499..a7159a842d74306f372db793959cdc8e2555eb3e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> @@ -7,6 +7,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc_i2c;
> rtc1 = &rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
> index 54393a0c5cbfcd55dae080a9f07879748bbd4486..1e588d76a6ddb1bd7f94f444d72e2819f267c490 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
> @@ -5,6 +5,7 @@
>
> / {
> aliases {
> + ethernet0 = &fec1;
> rtc0 = &rtc_i2c;
> rtc1 = &rtc;
> };
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index c4b5663949ade617fe9b7be20a3aebf0b322623a..a64ae67ef70cc6a624b06f4ab1f3a8ab03ffd1f6 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -16,6 +16,8 @@ adc {
> };
>
> aliases {
> + ethernet0 = &fec1;
> + ethernet1 = &fec2;
> rtc0 = &pcf85063;
> rtc1 = &rtc;
> };
>
>

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider