[PATCH v2 0/3] Set eMMC clock parent to default

[PATCH v2 0/3] Set eMMC clock parent to default

[Judith Mendez]

This series was split-off from "Misc MMC updates" patch series [0] and the
original patch further divided into three to help with backporting as per
review comments [1].

This series sets clock parent for eMMC to the default clock parent
MAIN_PLL0_HSDIV5_CLKOUT for am62, am62a, & am62p/j722s SoCs. Software (DM)
does not switch MMC clock parent correctly as per the Arasan IP requirement
to hold the IP in reset while clock source is switched. Since muxes to
switch clock parent are not glitch-free and the default parent is tested
and working fine, switch to the default as a preventative action.

Changes since v1:
- split original patch into three
- add cover-letter
- reword patch descriptions
- add review tags

[0] https://lore.kernel.org/linux-devicetree/20250417233040.3658761-1-jm@ti.com/
[1] https://lore.kernel.org/linux-devicetree/20250429142825.bvrbpoc5iz32wh35@garment/

Link to v1:
https://lore.kernel.org/linux-devicetree/20250429142333.4140010-1-jm@ti.com/

Judith Mendez (3):
  arm64: dts: ti: k3-am62-main: Set eMMC clock parents to default
  arm64: dts: ti: k3-am62a-main: Set eMMC clock parents to default
  arm64: dts: ti: k3-am62p-j722s-common-main: Set eMMC clock parents to
    default

 arch/arm64/boot/dts/ti/k3-am62-main.dtsi               | 2 --
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi              | 2 --
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 2 --
 3 files changed, 6 deletions(-)


base-commit: d864bb528a6725e775d564fd4430762acbb9dd0d
-- 
2.49.0

[PATCH v2 1/3] arm64: dts: ti: k3-am62-main: Set eMMC clock parent to default

[Judith Mendez]

Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
for eMMC. This change is necessary since DM is not implementing the
correct procedure to switch PLL clock source for eMMC and MMC CLK mux is
not glich-free. As a preventative action, lets switch back to the defaults.

Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Judith Mendez <jm@ti.com>
Acked-by: Udit Kumar <u-kumar1@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 7d355aa73ea2..0c286f600296 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -552,8 +552,6 @@ sdhci0: mmc@fa10000 {
 		power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
 		clocks = <&k3_clks 57 5>, <&k3_clks 57 6>;
 		clock-names = "clk_ahb", "clk_xin";
-		assigned-clocks = <&k3_clks 57 6>;
-		assigned-clock-parents = <&k3_clks 57 8>;
 		bus-width = <8>;
 		mmc-ddr-1_8v;
 		mmc-hs200-1_8v;
-- 
2.49.0

[PATCH v2 2/3] arm64: dts: ti: k3-am62a-main: Set eMMC clock parent to default

[Judith Mendez]

Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
for eMMC. This change is necessary since DM is not implementing the
correct procedure to switch PLL clock source for eMMC and MMC CLK mux is
not glich-free. As a preventative action, lets switch back to the defaults.

Fixes: d3ae4e8d8b6a ("arm64: dts: ti: k3-am62a-main: Add sdhci0 instance")
Cc: stable@vger.kernel.org
Signed-off-by: Judith Mendez <jm@ti.com>
Acked-by: Udit Kumar <u-kumar1@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index a1daba7b1fad..455ccc770f16 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -575,8 +575,6 @@ sdhci0: mmc@fa10000 {
 		power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
 		clocks = <&k3_clks 57 5>, <&k3_clks 57 6>;
 		clock-names = "clk_ahb", "clk_xin";
-		assigned-clocks = <&k3_clks 57 6>;
-		assigned-clock-parents = <&k3_clks 57 8>;
 		bus-width = <8>;
 		mmc-hs200-1_8v;
 		ti,clkbuf-sel = <0x7>;
-- 
2.49.0

[PATCH v2 3/3] arm64: dts: ti: k3-am62p-j722s-common-main: Set eMMC clock parent to default

[Judith Mendez]

Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
for eMMC. This change is necessary since DM is not implementing the
correct procedure to switch PLL clock source for eMMC and MMC CLK mux is
not glich-free. As a preventative action, lets switch back to the defaults.

Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
Cc: stable@vger.kernel.org
Signed-off-by: Judith Mendez <jm@ti.com>
Acked-by: Udit Kumar <u-kumar1@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
index 7b65538110e8..fa55c43ca28d 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
@@ -573,8 +573,6 @@ sdhci0: mmc@fa10000 {
 		power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
 		clocks = <&k3_clks 57 1>, <&k3_clks 57 2>;
 		clock-names = "clk_ahb", "clk_xin";
-		assigned-clocks = <&k3_clks 57 2>;
-		assigned-clock-parents = <&k3_clks 57 4>;
 		bus-width = <8>;
 		mmc-ddr-1_8v;
 		mmc-hs200-1_8v;
-- 
2.49.0

Re: [PATCH v2 0/3] Set eMMC clock parent to default

[Bryan Brattlof]

On April 29, 2025 thus sayeth Judith Mendez:
> This series was split-off from "Misc MMC updates" patch series [0] and the
> original patch further divided into three to help with backporting as per
> review comments [1].
> 
> This series sets clock parent for eMMC to the default clock parent
> MAIN_PLL0_HSDIV5_CLKOUT for am62, am62a, & am62p/j722s SoCs. Software (DM)
> does not switch MMC clock parent correctly as per the Arasan IP requirement
> to hold the IP in reset while clock source is switched. Since muxes to
> switch clock parent are not glitch-free and the default parent is tested
> and working fine, switch to the default as a preventative action.
> 
> Changes since v1:
> - split original patch into three
> - add cover-letter
> - reword patch descriptions
> - add review tags
> 

Acked-by: Bryan Brattlof <bb@ti.com>

~Bryan

> [0] https://lore.kernel.org/linux-devicetree/20250417233040.3658761-1-jm@ti.com/
> [1] https://lore.kernel.org/linux-devicetree/20250429142825.bvrbpoc5iz32wh35@garment/
> 
> Link to v1:
> https://lore.kernel.org/linux-devicetree/20250429142333.4140010-1-jm@ti.com/
> 
> Judith Mendez (3):
>   arm64: dts: ti: k3-am62-main: Set eMMC clock parents to default
>   arm64: dts: ti: k3-am62a-main: Set eMMC clock parents to default
>   arm64: dts: ti: k3-am62p-j722s-common-main: Set eMMC clock parents to
>     default
> 
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi               | 2 --
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi              | 2 --
>  arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 2 --
>  3 files changed, 6 deletions(-)
> 
> 
> base-commit: d864bb528a6725e775d564fd4430762acbb9dd0d
> -- 
> 2.49.0
> 

Re: [PATCH v2 0/3] Set eMMC clock parent to default

[Nishanth Menon]

Hi Judith Mendez,

On Tue, 29 Apr 2025 11:33:34 -0500, Judith Mendez wrote:
> This series was split-off from "Misc MMC updates" patch series [0] and the
> original patch further divided into three to help with backporting as per
> review comments [1].
> 
> This series sets clock parent for eMMC to the default clock parent
> MAIN_PLL0_HSDIV5_CLKOUT for am62, am62a, & am62p/j722s SoCs. Software (DM)
> does not switch MMC clock parent correctly as per the Arasan IP requirement
> to hold the IP in reset while clock source is switched. Since muxes to
> switch clock parent are not glitch-free and the default parent is tested
> and working fine, switch to the default as a preventative action.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/3] arm64: dts: ti: k3-am62-main: Set eMMC clock parent to default
      commit: 3a71cdfec94436079513d9adf4b1d4f7a7edd917
[2/3] arm64: dts: ti: k3-am62a-main: Set eMMC clock parent to default
      commit: 6af731c5de59cc4e7cce193d446f1fe872ac711b
[3/3] arm64: dts: ti: k3-am62p-j722s-common-main: Set eMMC clock parent to default
      commit: 9c6b73fc72e19c449147233587833ce20f84b660

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D