From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data struct
Date: Thu, 1 May 2025 17:41:40 -0700 [thread overview]
Message-ID: <20250501174140.6dc31b36@kernel.org> (raw)
In-Reply-To: <aBPdyn580lxUMJKz@lore-desk>
On Thu, 1 May 2025 22:47:06 +0200 Lorenzo Bianconi wrote:
> On May 01, Jakub Kicinski wrote:
> > On Tue, 29 Apr 2025 16:17:41 +0200 Lorenzo Bianconi wrote:
> > > Moreover, add __packed attribute to ppe_mbox_data struct definition and
> > > make the fw layout padding explicit in init_info struct.
> >
> > Why? everything looks naturally packed now :(
>
> What I mean here is the padding in the ppe_mbox_data struct used by the fw running
> on the NPU, not in the version used by the airoha_eth driver, got my point?
> Sorry, re-reading it, it was not so clear, I agree.
You mean adding the "u8 rsv[3];" ? that is fine.
I don't get why we also need to add the 3 __packed
next prev parent reply other threads:[~2025-05-02 0:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 14:17 [PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data struct Lorenzo Bianconi
2025-04-29 20:08 ` Jacob Keller
2025-04-29 20:09 ` Jacob Keller
2025-05-01 14:15 ` Jakub Kicinski
2025-05-01 20:47 ` Lorenzo Bianconi
2025-05-02 0:41 ` Jakub Kicinski [this message]
2025-05-02 7:24 ` Lorenzo Bianconi
2025-05-03 1:12 ` Jakub Kicinski
2025-05-03 8:39 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501174140.6dc31b36@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).