Re: [net-next v10 4/7] net: mtip: The L2 switch driver for imx287

Lukasz Majewski
2025-05-06T14:01:35Z

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

Hi Jakub,

> On Sun, 4 May 2025 08:28:11 +0200 Lukasz Majewski wrote:
> > > Now that basic build is green the series has advanced to full
> > > testing, where coccicheck says:
> > >
> > > drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c:1961:1-6:
> > > WARNING: invalid free of devm_ allocated data
> > > drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c:1237:16-19:
> > > ERROR: bus is NULL but dereferenced.
> >
> > I'm sorry for not checking the code with coccinelle.
> >
> > I do have already used sparse and checkpatch.
>
> No worries. Not testing a build W=1 is a bit of a faux pas.

Yes, I'm fully aware of them - mea culpa.

(at least now by default I will have W=1 set :-) )

> But coccinelle is finicky and slow.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]