* [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors
@ 2025-05-05 13:23 Julien Massot
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
` (4 more replies)
0 siblings, 5 replies; 18+ messages in thread
From: Julien Massot @ 2025-05-05 13:23 UTC (permalink / raw)
To: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu, Julien Massot
Hi,
This patch series addresses several dtb-check errors reported for the mt8395-genio-1200-evk.dtb and mt8395-radxa-nio-12l.dtb device trees.
The fixes include:
- Adding the missing #sound-dai-cells property in the mt6397 binding.
- Allowing up to 5 interrupts in the MediaTek IOMMU binding to support MT8395 properly.
- Defining the required compatible property in the regulators node of the mt6359.dtsi.
- Renaming the rtc node to match expected schema naming.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Julien Massot (4):
dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
arm64: dts: mt6359: Add missing 'compatible' property to regulators node
arm64: dts: mt6359: Rename RTC node to match binding expectations
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 3 +++
arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 +++-
3 files changed, 8 insertions(+), 2 deletions(-)
---
base-commit: 407f60a151df3c44397e5afc0111eb9b026c38d3
change-id: 20250505-mt8395-dtb-errors-0847ffc12f44
Best regards,
--
Julien Massot <julien.massot@collabora.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
2025-05-05 13:23 [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors Julien Massot
@ 2025-05-05 13:23 ` Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
` (2 more replies)
2025-05-05 13:23 ` [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts Julien Massot
` (3 subsequent siblings)
4 siblings, 3 replies; 18+ messages in thread
From: Julien Massot @ 2025-05-05 13:23 UTC (permalink / raw)
To: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu, Julien Massot
The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
Add the corresponding property to the binding to fix the following
dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
Fixes: 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 6a89b479d10fad3c8b61cab5a3af1453baca4d1a..86fc1b5db3b075ea0f6e35f58ecbca7956d230c4 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -53,6 +53,9 @@ properties:
"#interrupt-cells":
const: 2
+ '#sound-dai-cells':
+ const: 1
+
rtc:
type: object
$ref: /schemas/rtc/rtc.yaml#
--
2.49.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-05 13:23 [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors Julien Massot
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
@ 2025-05-05 13:23 ` Julien Massot
2025-05-06 8:34 ` AngeloGioacchino Del Regno
2025-05-08 6:03 ` Krzysztof Kozlowski
2025-05-05 13:23 ` [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node Julien Massot
` (2 subsequent siblings)
4 siblings, 2 replies; 18+ messages in thread
From: Julien Massot @ 2025-05-05 13:23 UTC (permalink / raw)
To: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu, Julien Massot
Some Mediatek IOMMU can have up to five interrupts so increase
the 'maxItems' to 5.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
[[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long
Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644
--- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
@@ -97,7 +97,8 @@ properties:
maxItems: 1
interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 5
clocks:
items:
--
2.49.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node
2025-05-05 13:23 [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors Julien Massot
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
2025-05-05 13:23 ` [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts Julien Massot
@ 2025-05-05 13:23 ` Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-05 13:23 ` [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations Julien Massot
2025-05-06 8:42 ` (subset) [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors AngeloGioacchino Del Regno
4 siblings, 1 reply; 18+ messages in thread
From: Julien Massot @ 2025-05-05 13:23 UTC (permalink / raw)
To: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu, Julien Massot
The 'compatible' property is required by the
'mfd/mediatek,mt6397.yaml' binding. Add it to fix the following
dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: regulators:
'compatible' is a required property
Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt6359.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 7b10f9c59819a9ad02319f00938f35c931091f9f..0c479404b3fe3adc9789386e34bda4dc580b5abd 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -20,6 +20,8 @@ mt6359codec: audio-codec {
};
regulators {
+ compatible = "mediatek,mt6359-regulator";
+
mt6359_vs1_buck_reg: buck_vs1 {
regulator-name = "vs1";
regulator-min-microvolt = <800000>;
--
2.49.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations
2025-05-05 13:23 [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors Julien Massot
` (2 preceding siblings ...)
2025-05-05 13:23 ` [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node Julien Massot
@ 2025-05-05 13:23 ` Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-06 8:42 ` (subset) [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors AngeloGioacchino Del Regno
4 siblings, 1 reply; 18+ messages in thread
From: Julien Massot @ 2025-05-05 13:23 UTC (permalink / raw)
To: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu, Julien Massot
Rename the node 'mt6359rtc' to 'rtc', as required by the binding.
Fix the following dtb-check error:
mediatek/mt8395-radxa-nio-12l.dtb: pmic: 'mt6359rtc' do not match
any of the regexes: 'pinctrl-[0-9]+'
Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
---
arch/arm64/boot/dts/mediatek/mt6359.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 0c479404b3fe3adc9789386e34bda4dc580b5abd..467d8a4c2aa7f16ade92a287ecdeed5089302045 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -300,7 +300,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
};
};
- mt6359rtc: mt6359rtc {
+ mt6359rtc: rtc {
compatible = "mediatek,mt6358-rtc";
};
};
--
2.49.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-05 13:23 ` [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts Julien Massot
@ 2025-05-06 8:34 ` AngeloGioacchino Del Regno
2025-05-06 10:03 ` Julien Massot
2025-05-08 6:03 ` Krzysztof Kozlowski
1 sibling, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-06 8:34 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Il 05/05/25 15:23, Julien Massot ha scritto:
> Some Mediatek IOMMU can have up to five interrupts so increase
> the 'maxItems' to 5.
>
> Fix the following dtb-check error:
>
> mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
> [[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long
>
> Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644
> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> @@ -97,7 +97,8 @@ properties:
> maxItems: 1
>
> interrupts:
> - maxItems: 1
> + minItems: 1
Isn't minItems already implicitly 1? :-)
Cheers,
Angelo
> + maxItems: 5
>
> clocks:
> items:
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations
2025-05-05 13:23 ` [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations Julien Massot
@ 2025-05-06 8:35 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-06 8:35 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Il 05/05/25 15:23, Julien Massot ha scritto:
> Rename the node 'mt6359rtc' to 'rtc', as required by the binding.
>
> Fix the following dtb-check error:
>
> mediatek/mt8395-radxa-nio-12l.dtb: pmic: 'mt6359rtc' do not match
> any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
Your S-o-B is missing....
Cheers,
Angelo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node
2025-05-05 13:23 ` [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node Julien Massot
@ 2025-05-06 8:35 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-06 8:35 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Il 05/05/25 15:23, Julien Massot ha scritto:
> The 'compatible' property is required by the
> 'mfd/mediatek,mt6397.yaml' binding. Add it to fix the following
> dtb-check error:
> mediatek/mt8395-radxa-nio-12l.dtb: pmic: regulators:
> 'compatible' is a required property
>
> Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
@ 2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-07 19:22 ` Nícolas F. R. A. Prado
2025-05-08 6:01 ` Krzysztof Kozlowski
2 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-06 8:35 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Il 05/05/25 15:23, Julien Massot ha scritto:
> The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> Add the corresponding property to the binding to fix the following
> dtb-check error:
>
> mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
>
> Fixes: 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: (subset) [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors
2025-05-05 13:23 [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors Julien Massot
` (3 preceding siblings ...)
2025-05-05 13:23 ` [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations Julien Massot
@ 2025-05-06 8:42 ` AngeloGioacchino Del Regno
4 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-06 8:42 UTC (permalink / raw)
To: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen, Julien Massot
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
On Mon, 05 May 2025 15:23:36 +0200, Julien Massot wrote:
> This patch series addresses several dtb-check errors reported for the mt8395-genio-1200-evk.dtb and mt8395-radxa-nio-12l.dtb device trees.
>
> The fixes include:
> - Adding the missing #sound-dai-cells property in the mt6397 binding.
> - Allowing up to 5 interrupts in the MediaTek IOMMU binding to support MT8395 properly.
> - Defining the required compatible property in the regulators node of the mt6359.dtsi.
> - Renaming the rtc node to match expected schema naming.
>
> [...]
Applied to v6.15-next/dts64, thanks!
[3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node
commit: 1fe38d2a19950fa6dbc384ee8967c057aef9faf4
Cheers,
Angelo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-06 8:34 ` AngeloGioacchino Del Regno
@ 2025-05-06 10:03 ` Julien Massot
2025-05-06 10:20 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 18+ messages in thread
From: Julien Massot @ 2025-05-06 10:03 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, kernel, Sen Chu, Sean Wang,
Macpaul Lin, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, Nícolas F. R. A. Prado,
Hui Liu, Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy,
Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Hi Angelo,
On Tue, 2025-05-06 at 10:34 +0200, AngeloGioacchino Del Regno wrote:
> Il 05/05/25 15:23, Julien Massot ha scritto:
> > Some Mediatek IOMMU can have up to five interrupts so increase
> > the 'maxItems' to 5.
> >
> > Fix the following dtb-check error:
> >
> > mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
> > [[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long
> >
> > Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > ---
> > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644
> > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > @@ -97,7 +97,8 @@ properties:
> > maxItems: 1
> >
> > interrupts:
> > - maxItems: 1
> > + minItems: 1
>
> Isn't minItems already implicitly 1? :-)
>
> Looks not, from my understanding if 'minItems' is omitted then
dt-schema is setting it to 'maxItems'.
https://github.com/devicetree-org/dt-schema/blob/v2025.02/dtschema/fixups.py#L129
And you will have an error for a one item interrupts:
Documentation/devicetree/bindings/iommu/mediatek,iommu.example.dtb: iommu@10205000: interrupts: [[0,
139, 8]] is too short
Regards,
Julien
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-06 10:03 ` Julien Massot
@ 2025-05-06 10:20 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-06 10:20 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Il 06/05/25 12:03, Julien Massot ha scritto:
> Hi Angelo,
>
> On Tue, 2025-05-06 at 10:34 +0200, AngeloGioacchino Del Regno wrote:
>> Il 05/05/25 15:23, Julien Massot ha scritto:
>>> Some Mediatek IOMMU can have up to five interrupts so increase
>>> the 'maxItems' to 5.
>>>
>>> Fix the following dtb-check error:
>>>
>>> mediatek/mt8395-radxa-nio-12l.dtb: infra-iommu@10315000: interrupts:
>>> [[0, 795, 4, 0], [0, 796, 4, 0], [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] is too long
>>>
>>> Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
>>> Signed-off-by: Julien Massot <julien.massot@collabora.com>
>>> ---
>>> Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>>> b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>>> index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644
>>> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>>> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>>> @@ -97,7 +97,8 @@ properties:
>>> maxItems: 1
>>>
>>> interrupts:
>>> - maxItems: 1
>>> + minItems: 1
>>
>> Isn't minItems already implicitly 1? :-)
>>
>> Looks not, from my understanding if 'minItems' is omitted then
> dt-schema is setting it to 'maxItems'.
> https://github.com/devicetree-org/dt-schema/blob/v2025.02/dtschema/fixups.py#L129
>
> And you will have an error for a one item interrupts:
> Documentation/devicetree/bindings/iommu/mediatek,iommu.example.dtb: iommu@10205000: interrupts: [[0,
> 139, 8]] is too short
>
Whoops, you're right.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
@ 2025-05-07 19:22 ` Nícolas F. R. A. Prado
2025-05-08 6:01 ` Krzysztof Kozlowski
2 siblings, 0 replies; 18+ messages in thread
From: Nícolas F. R. A. Prado @ 2025-05-07 19:22 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen, linux-pm, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, iommu
On Mon, May 05, 2025 at 03:23:37PM +0200, Julien Massot wrote:
> The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> Add the corresponding property to the binding to fix the following
> dtb-check error:
>
> mediatek/mt8395-radxa-nio-12l.dtb: pmic: '#sound-dai-cells', 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
>
> Fixes: 9bc8353be720 ("arm64: dts: mt6359: Add #sound-dai-cells property")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-07 19:22 ` Nícolas F. R. A. Prado
@ 2025-05-08 6:01 ` Krzysztof Kozlowski
2025-05-14 8:11 ` Julien Massot
2 siblings, 1 reply; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-08 6:01 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
On 05/05/2025 15:23, Julien Massot wrote:
> The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> Add the corresponding property to the binding to fix the following
> dtb-check error:
If this is a DAI, then you miss dai-common reference. If not, you need
to explain it in commit msg.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-05 13:23 ` [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts Julien Massot
2025-05-06 8:34 ` AngeloGioacchino Del Regno
@ 2025-05-08 6:03 ` Krzysztof Kozlowski
2025-05-08 8:34 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-08 6:03 UTC (permalink / raw)
To: Julien Massot, kernel, Sen Chu, Sean Wang, Macpaul Lin, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Nícolas F. R. A. Prado, Hui Liu,
Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
On 05/05/2025 15:23, Julien Massot wrote:
>
> Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644
> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> @@ -97,7 +97,8 @@ properties:
> maxItems: 1
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 5
>
Every iommu or just some (as described in commit msg) can have 5
interrupts? Looks you miss here proper constraints per variant.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-08 6:03 ` Krzysztof Kozlowski
@ 2025-05-08 8:34 ` AngeloGioacchino Del Regno
2025-05-14 8:13 ` Julien Massot
0 siblings, 1 reply; 18+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-05-08 8:34 UTC (permalink / raw)
To: Krzysztof Kozlowski, Julien Massot, kernel, Sen Chu, Sean Wang,
Macpaul Lin, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, Nícolas F. R. A. Prado,
Hui Liu, Yong Wu, Joerg Roedel, Will Deacon, Robin Murphy,
Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Il 08/05/25 08:03, Krzysztof Kozlowski ha scritto:
> On 05/05/2025 15:23, Julien Massot wrote:
>>
>> Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
>> Signed-off-by: Julien Massot <julien.massot@collabora.com>
>> ---
>> Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>> index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251 100644
>> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
>> @@ -97,7 +97,8 @@ properties:
>> maxItems: 1
>>
>> interrupts:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 5
>>
> Every iommu or just some (as described in commit msg) can have 5
> interrupts? Looks you miss here proper constraints per variant.
>
Technically, all of the IOMMUs can have more than one interrupt - but it's not
clear which one and why, as documentation is lacking.
Let's restrict this discussion to MT8195 anyway, as it's the only one declaring
those 5 interrupts...
...all of the IOMMUs declare just one, and mediatek,mt8195-iommu-infra declares 5.
P.S.: Nice catch!
Cheers,
Angelo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property
2025-05-08 6:01 ` Krzysztof Kozlowski
@ 2025-05-14 8:11 ` Julien Massot
0 siblings, 0 replies; 18+ messages in thread
From: Julien Massot @ 2025-05-14 8:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, kernel, Sen Chu, Sean Wang, Macpaul Lin,
Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Hi Krzysztof,
On Thu, 2025-05-08 at 08:01 +0200, Krzysztof Kozlowski wrote:
> On 05/05/2025 15:23, Julien Massot wrote:
> > The 'mt6359.dtsi' file already uses the '#sound-dai-cells' property.
> > Add the corresponding property to the binding to fix the following
> > dtb-check error:
> If this is a DAI, then you miss dai-common reference. If not, you need
> to explain it in commit msg.
Thanks for the review, I will add the missing dai-common reference in the v2.
Regards,
Julien
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts
2025-05-08 8:34 ` AngeloGioacchino Del Regno
@ 2025-05-14 8:13 ` Julien Massot
0 siblings, 0 replies; 18+ messages in thread
From: Julien Massot @ 2025-05-14 8:13 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Krzysztof Kozlowski, kernel, Sen Chu,
Sean Wang, Macpaul Lin, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Nícolas F. R. A. Prado, Hui Liu, Yong Wu, Joerg Roedel,
Will Deacon, Robin Murphy, Tinghan Shen
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, iommu
Hi Krzysztof, Angelo,
On Thu, 2025-05-08 at 10:34 +0200, AngeloGioacchino Del Regno wrote:
> Il 08/05/25 08:03, Krzysztof Kozlowski ha scritto:
> > On 05/05/2025 15:23, Julien Massot wrote:
> > >
> > > Fixes: 3b5838d1d82e3 ("arm64: dts: mt8195: Add iommu and smi nodes")
> > > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > > ---
> > > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > > b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > > index 75750c64157c868725c087500ac81be4e282c829..035941c2db32170e9a69a5363d8c05ef767bb251
> > > 100644
> > > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > > @@ -97,7 +97,8 @@ properties:
> > > maxItems: 1
> > >
> > > interrupts:
> > > - maxItems: 1
> > > + minItems: 1
> > > + maxItems: 5
> > >
> > Every iommu or just some (as described in commit msg) can have 5
> > interrupts? Looks you miss here proper constraints per variant.
> >
> Technically, all of the IOMMUs can have more than one interrupt - but it's not
> clear which one and why, as documentation is lacking.
>
> Let's restrict this discussion to MT8195 anyway, as it's the only one declaring
> those 5 interrupts...
> ...all of the IOMMUs declare just one, and mediatek,mt8195-iommu-infra declares 5.
Setting 5 interrupts will be restricted to mt8195 infra iommu in the v2.
Regards,
Julien
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2025-05-14 9:34 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-05 13:23 [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors Julien Massot
2025-05-05 13:23 ` [PATCH 1/4] dt-bindings: mfd: mediatek: mt6397: Add #sound-dai-cells property Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-07 19:22 ` Nícolas F. R. A. Prado
2025-05-08 6:01 ` Krzysztof Kozlowski
2025-05-14 8:11 ` Julien Massot
2025-05-05 13:23 ` [PATCH 2/4] dt-bindings: iommu: mediatek: mt8195 Accept up to 5 interrupts Julien Massot
2025-05-06 8:34 ` AngeloGioacchino Del Regno
2025-05-06 10:03 ` Julien Massot
2025-05-06 10:20 ` AngeloGioacchino Del Regno
2025-05-08 6:03 ` Krzysztof Kozlowski
2025-05-08 8:34 ` AngeloGioacchino Del Regno
2025-05-14 8:13 ` Julien Massot
2025-05-05 13:23 ` [PATCH 3/4] arm64: dts: mt6359: Add missing 'compatible' property to regulators node Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-05 13:23 ` [PATCH 4/4] arm64: dts: mt6359: Rename RTC node to match binding expectations Julien Massot
2025-05-06 8:35 ` AngeloGioacchino Del Regno
2025-05-06 8:42 ` (subset) [PATCH 0/4] mt8395/mt6359: Fix several dtb-check errors AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).