From: Nishanth Menon <nm@ti.com>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<upstream@lists.phytec.de>
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am62a: Set Critical Temp. to 105C
Date: Mon, 5 May 2025 08:12:30 -0500 [thread overview]
Message-ID: <20250505131230.3ydwgftnqbbmrt5u@opulently> (raw)
In-Reply-To: <9964aeaa-0169-4596-a33d-c56bdb6edae3@phytec.de>
On 21:11-20250502, Daniel Schultz wrote:
>
> On 5/2/25 16:49, Nishanth Menon wrote:
> > On 07:26-20250502, Daniel Schultz wrote:
> > > The AM62Ax SoC supports two temperature ranges:
> > > * A: -40 to 105C - Extended Industrial
> > > * I: -40 to 125C - Automotive
> > >
> > > By default, use the lower limit (105 °C) so that any AM62A running
> > > in Extended Industrial mode will shut down safely before overheating.
> > >
> > > If the bootloader detects an Automotive-grade device, it should
> > > override this and raise the critical trip point to 125 °C.
> > >
> > > Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> > > ---
> > > arch/arm64/boot/dts/ti/k3-am62a-thermal.dtsi | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am62a-thermal.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-thermal.dtsi
> > > index 39ff9118b6c4..40dcb9bab965 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am62a-thermal.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-am62a-thermal.dtsi
> > Why not create a separate header for industrial grade and rename this as
> > automotive grade and let the board file pick the right grade used on the
> > board?
>
> Mostly because I copied this from 10e7bfd8114c207ac and with the most recent
> temperature fixups in U-Boot, we also have the missing bootloader logic.
>
> I would also prefer an out-of-the-box solution for that.
Personally, I am not in favor of depending on U-boot (there are other
bootloaders as well in the ecosystem) monkeying with dt nodes.
I suggest renaming the dtsi and introducing a industrial dtsi. And
depending on the samples used by the board, use the correct dtsi.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2025-05-05 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 14:26 [PATCH 1/3] arm64: dts: ti: k3-am62a: Enable CPU freq throttling on thermal alert Daniel Schultz
2025-05-02 14:26 ` [PATCH 2/3] arm64: dts: ti: k3-am62a: Set Critical Temp. to 105C Daniel Schultz
2025-05-02 14:49 ` Nishanth Menon
2025-05-02 19:11 ` Daniel Schultz
2025-05-05 13:12 ` Nishanth Menon [this message]
2025-05-05 13:36 ` Daniel Schultz
2025-05-02 14:26 ` [PATCH 3/3] arm64: dts: ti: k3-am62x-phyboard-lyra-gpio-fan: Update cooling maps Daniel Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505131230.3ydwgftnqbbmrt5u@opulently \
--to=nm@ti.com \
--cc=conor+dt@kernel.org \
--cc=d.schultz@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox