* [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix
2025-05-06 11:41 [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
@ 2025-05-06 11:41 ` John Clark
2025-05-06 15:45 ` Conor Dooley
2025-05-06 11:41 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings John Clark
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: John Clark @ 2025-05-06 11:41 UTC (permalink / raw)
To: heiko
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew,
John Clark
Add vendor prefix for Shenzhen Luckfox Technology Co., Ltd., which
produces development boards like the Luckfox Omni3576.
Signed-off-by: John Clark <inindev@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 86f6a19b28ae..9391e0c31bb8 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -892,6 +892,8 @@ patternProperties:
description: Liebherr-Werk Nenzing GmbH
"^lxa,.*":
description: Linux Automation GmbH
+ "^luckfox,.*":
+ description: Shenzhen Luckfox Technology Co., Ltd.
"^m5stack,.*":
description: M5Stack
"^macnica,.*":
--
2.39.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix
2025-05-06 11:41 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
@ 2025-05-06 15:45 ` Conor Dooley
0 siblings, 0 replies; 14+ messages in thread
From: Conor Dooley @ 2025-05-06 15:45 UTC (permalink / raw)
To: John Clark
Cc: heiko, linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
On Tue, May 06, 2025 at 07:41:13AM -0400, John Clark wrote:
> Add vendor prefix for Shenzhen Luckfox Technology Co., Ltd., which
> produces development boards like the Luckfox Omni3576.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
2025-05-06 11:41 [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
2025-05-06 11:41 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
@ 2025-05-06 11:41 ` John Clark
2025-05-06 15:44 ` Conor Dooley
2025-05-06 11:41 ` [PATCH v3 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support John Clark
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: John Clark @ 2025-05-06 11:41 UTC (permalink / raw)
To: heiko
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew,
John Clark
Add device tree binding for the Luckfox Omni3576 Carrier Board with
Core3576 Module, based on the Rockchip RK3576 SoC.
Signed-off-by: John Clark <inindev@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 455fbb290b77..826dede32145 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -715,6 +715,16 @@ properties:
- const: lckfb,tspi-rk3566
- const: rockchip,rk3566
+ - description: Luckfox Core3576 Module
+ items:
+ - const: luckfox,core3576
+ - const: rockchip,rk3576
+
+ - description: Luckfox Omni3576 Carrier Board
+ items:
+ - const: luckfox,omni3576
+ - const: rockchip,rk3576
+
- description: Lunzn FastRhino R66S / R68S
items:
- enum:
--
2.39.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
2025-05-06 11:41 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings John Clark
@ 2025-05-06 15:44 ` Conor Dooley
2025-05-06 15:54 ` John Clark
0 siblings, 1 reply; 14+ messages in thread
From: Conor Dooley @ 2025-05-06 15:44 UTC (permalink / raw)
To: John Clark
Cc: heiko, linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
> Add device tree binding for the Luckfox Omni3576 Carrier Board with
> Core3576 Module, based on the Rockchip RK3576 SoC.
>
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 455fbb290b77..826dede32145 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -715,6 +715,16 @@ properties:
> - const: lckfb,tspi-rk3566
> - const: rockchip,rk3566
>
> + - description: Luckfox Core3576 Module
> + items:
> + - const: luckfox,core3576
> + - const: rockchip,rk3576
> +
> + - description: Luckfox Omni3576 Carrier Board
> + items:
> + - const: luckfox,omni3576
> + - const: rockchip,rk3576
Not sure this is correct, does the module not have to be attached to
this particular carrier to be used?
> +
> - description: Lunzn FastRhino R66S / R68S
> items:
> - enum:
> --
> 2.39.5
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
2025-05-06 15:44 ` Conor Dooley
@ 2025-05-06 15:54 ` John Clark
2025-05-06 16:34 ` Conor Dooley
2025-05-06 16:38 ` Heiko Stübner
0 siblings, 2 replies; 14+ messages in thread
From: John Clark @ 2025-05-06 15:54 UTC (permalink / raw)
To: Conor Dooley
Cc: heiko, linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew
On 5/6/25 11:44 AM, Conor Dooley wrote:
> On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
>> Add device tree binding for the Luckfox Omni3576 Carrier Board with
>> Core3576 Module, based on the Rockchip RK3576 SoC.
>>
>> Signed-off-by: John Clark <inindev@gmail.com>
>> ---
>> Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 455fbb290b77..826dede32145 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -715,6 +715,16 @@ properties:
>> - const: lckfb,tspi-rk3566
>> - const: rockchip,rk3566
>>
>> + - description: Luckfox Core3576 Module
>> + items:
>> + - const: luckfox,core3576
>> + - const: rockchip,rk3576
>> +
>> + - description: Luckfox Omni3576 Carrier Board
>> + items:
>> + - const: luckfox,omni3576
>> + - const: rockchip,rk3576
>
> Not sure this is correct, does the module not have to be attached to
> this particular carrier to be used?
The compute module and the carrier board together like the E25.
Presumably the compute module would be used in other applications
but the carrier board is not useful without it.
Is the E25 done correctly here? I can copy this format:
model = "Radxa E25 Carrier Board";
compatible = "radxa,e25", "radxa,cm3i", "rockchip,rk3568";
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts?h=v6.15-rc5
compatible = "radxa,cm3i", "rockchip,rk3568";
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi?h=v6.15-rc5
- description: Radxa Compute Module 3 (CM3)
items:
- enum:
- radxa,cm3-io
- const: radxa,cm3
- const: rockchip,rk3566
- description: Radxa CM3 Industrial
items:
- enum:
- radxa,e25
- const: radxa,cm3i
- const: rockchip,rk3568
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/rockchip.yaml?h=v6.15-rc5
>
>> +
>> - description: Lunzn FastRhino R66S / R68S
>> items:
>> - enum:
>> --
>> 2.39.5
>>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
2025-05-06 15:54 ` John Clark
@ 2025-05-06 16:34 ` Conor Dooley
2025-05-06 16:38 ` Heiko Stübner
1 sibling, 0 replies; 14+ messages in thread
From: Conor Dooley @ 2025-05-06 16:34 UTC (permalink / raw)
To: John Clark
Cc: heiko, linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew
[-- Attachment #1: Type: text/plain, Size: 2756 bytes --]
On Tue, May 06, 2025 at 11:54:10AM -0400, John Clark wrote:
> On 5/6/25 11:44 AM, Conor Dooley wrote:
> > On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
> > > Add device tree binding for the Luckfox Omni3576 Carrier Board with
> > > Core3576 Module, based on the Rockchip RK3576 SoC.
> > >
> > > Signed-off-by: John Clark <inindev@gmail.com>
> > > ---
> > > Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > index 455fbb290b77..826dede32145 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > @@ -715,6 +715,16 @@ properties:
> > > - const: lckfb,tspi-rk3566
> > > - const: rockchip,rk3566
> > > + - description: Luckfox Core3576 Module
> > > + items:
> > > + - const: luckfox,core3576
> > > + - const: rockchip,rk3576
> > > +
> > > + - description: Luckfox Omni3576 Carrier Board
> > > + items:
> > > + - const: luckfox,omni3576
> > > + - const: rockchip,rk3576
> >
> > Not sure this is correct, does the module not have to be attached to
> > this particular carrier to be used?
>
> The compute module and the carrier board together like the E25. Presumably
> the compute module would be used in other applications
> but the carrier board is not useful without it.
>
> Is the E25 done correctly here? I can copy this format:
Yeah, the format below looks good for these type of carrier situations.
>
> model = "Radxa E25 Carrier Board";
> compatible = "radxa,e25", "radxa,cm3i", "rockchip,rk3568";
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts?h=v6.15-rc5
>
> compatible = "radxa,cm3i", "rockchip,rk3568";
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi?h=v6.15-rc5
>
> - description: Radxa Compute Module 3 (CM3)
> items:
> - enum:
> - radxa,cm3-io
> - const: radxa,cm3
> - const: rockchip,rk3566
>
> - description: Radxa CM3 Industrial
> items:
> - enum:
> - radxa,e25
> - const: radxa,cm3i
> - const: rockchip,rk3568
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/rockchip.yaml?h=v6.15-rc5
>
> >
> > > +
> > > - description: Lunzn FastRhino R66S / R68S
> > > items:
> > > - enum:
> > > --
> > > 2.39.5
> > >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
2025-05-06 15:54 ` John Clark
2025-05-06 16:34 ` Conor Dooley
@ 2025-05-06 16:38 ` Heiko Stübner
1 sibling, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2025-05-06 16:38 UTC (permalink / raw)
To: Conor Dooley, John Clark
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew
Hi John,
Am Dienstag, 6. Mai 2025, 17:54:10 Mitteleuropäische Sommerzeit schrieb John Clark:
> On 5/6/25 11:44 AM, Conor Dooley wrote:
> > On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
> >> Add device tree binding for the Luckfox Omni3576 Carrier Board with
> >> Core3576 Module, based on the Rockchip RK3576 SoC.
> >>
> >> Signed-off-by: John Clark <inindev@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> index 455fbb290b77..826dede32145 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -715,6 +715,16 @@ properties:
> >> - const: lckfb,tspi-rk3566
> >> - const: rockchip,rk3566
> >>
> >> + - description: Luckfox Core3576 Module
> >> + items:
> >> + - const: luckfox,core3576
> >> + - const: rockchip,rk3576
> >> +
> >> + - description: Luckfox Omni3576 Carrier Board
> >> + items:
> >> + - const: luckfox,omni3576
> >> + - const: rockchip,rk3576
> >
> > Not sure this is correct, does the module not have to be attached to
> > this particular carrier to be used?
>
> The compute module and the carrier board together like the E25.
> Presumably the compute module would be used in other applications
> but the carrier board is not useful without it.
>
> Is the E25 done correctly here? I can copy this format:
For the baseboard + module you should always have one of those
> >> + - description: Luckfox Core3576 Module
> >> + items:
> >> + - const: luckfox,core3576
> >> + - const: rockchip,rk3576
> >> +
- description: Luckfox Core3576 based boards
items:
- enum:
- luckfox,omni3576
- const: luckfox,core3576
- const: rockchip,rk3576
I've looked at the product page [0] now and the Core3576 module itself
can't work independently without a baseboard present, so the above should
be enough, and also allows for possible future other baseboards to be
integrated.
Heiko
[0] https://www.luckfox.com/EN-Core3576
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support
2025-05-06 11:41 [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
2025-05-06 11:41 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add luckfox prefix John Clark
2025-05-06 11:41 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings John Clark
@ 2025-05-06 11:41 ` John Clark
2025-05-06 17:05 ` [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Krzysztof Kozlowski
2025-05-06 18:23 ` Rob Herring (Arm)
4 siblings, 0 replies; 14+ messages in thread
From: John Clark @ 2025-05-06 11:41 UTC (permalink / raw)
To: heiko
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh,
krzysztof.kozlowski, conor+dt, jonas, frattaroli.nicolas, andrew,
John Clark
Add device tree for the Luckfox Omni3576 Carrier Board with Core3576
Module, powered by the Rockchip RK3576 SoC with four Cortex-A72 cores,
four Cortex-A53 cores, and a Mali-G52 MC3 GPU. This initial
implementation enables essential functionality for booting Linux and
basic connectivity.
Supported and tested features:
- UART for serial console
- SD card for storage
- PCIe with NVMe SSD (detected, mounted, and fully functional)
- USB 2.0 host ports
- RK806 PMIC for power management
- RTC with timekeeping and wake-up
- GPIO-controlled LED with heartbeat trigger
- eMMC (enabled, not populated on tested board)
The device tree provides a foundation for further peripheral support, such
as WiFi, MIPI-DSI, HDMI, and Ethernet, in future updates.
Tested on Linux 6.15-rc4
Signed-off-by: John Clark <inindev@gmail.com>
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../dts/rockchip/rk3576-luckfox-core3576.dtsi | 683 ++++++++++++++++++
.../dts/rockchip/rk3576-luckfox-omni3576.dts | 53 ++
3 files changed, 737 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi
create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 7948522cb225..22d74367b7e6 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -136,6 +136,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-luckfox-omni3576.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-roc-pc.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3582-radxa-e52c.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi
new file mode 100644
index 000000000000..86f903107115
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi
@@ -0,0 +1,683 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2024 Rockchip Electronics Co., Ltd.
+ *
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3576.dtsi"
+
+/ {
+ model = "Luckfox Core3576";
+ compatible = "luckfox,core3576","rockchip,rk3576";
+
+ chosen {
+ stdout-path = "serial0:1500000n8";
+ };
+
+ hdmi-con {
+ compatible = "hdmi-connector";
+ hdmi-pwr-supply = <&vcc_5v0_hdmi>;
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
+ vcc_5v0_dcin: regulator-vcc-5v0-dcin {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc_5v0_dcin";
+ };
+
+ vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-name = "vcc_1v1_nldo_s3";
+ vin-supply = <&vcc_5v0_sys>;
+ };
+
+ vcc_2v0_pldo_s3: regulator-vcc-2v0-pldo-s3 {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-name = "vcc_2v0_pldo_s3";
+ vin-supply = <&vcc_5v0_sys>;
+ };
+
+ vcc_3v3_pcie: regulator-vcc-3v3-pcie {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpios = <&gpio4 RK_PA0 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie_pwr_en>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_3v3_pcie";
+ startup-delay-us = <1000>;
+ vin-supply = <&vcc_5v0_sys>;
+ };
+
+ vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_3v3_rtc_s5";
+ vin-supply = <&vcc_5v0_sys>;
+ };
+
+ vbus_5v0_typec: regulator-vbus-5v0-typec {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_otg0_pwr_en>;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vbus5v0_typec";
+ vin-supply = <&vcc_5v0_device>;
+ };
+
+ vcc_5v0_device: regulator-vcc-5v0-device {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc_5v0_device";
+ vin-supply = <&vcc_5v0_dcin>;
+ };
+
+ vcc_5v0_hdmi: regulator-vcc-5v0-hdmi {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpios = <&gpio4 RK_PC6 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hdmi_con_en>;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc_5v0_hdmi";
+ vin-supply = <&vcc_5v0_sys>;
+ };
+
+ vcc_5v0_host: regulator-vcc-5v0-host {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_host_pwr_en>;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc_5v0_host";
+ vin-supply = <&vcc_5v0_device>;
+ };
+
+ vcc_5v0_sys: regulator-vcc-5v0-sys {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc_5v0_sys";
+ vin-supply = <&vcc_5v0_dcin>;
+ };
+};
+
+&combphy0_ps {
+ status = "okay";
+};
+
+&combphy1_psu {
+ status = "okay";
+};
+
+&cpu_l0 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l1 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l2 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l3 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_b0 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b1 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b2 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b3 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&gpu {
+ mali-supply = <&vdd_gpu_s0>;
+ status = "okay";
+};
+
+&hdmi {
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&hdptxphy {
+ status = "okay";
+};
+
+&i2c1 {
+ status = "okay";
+
+ pmic@23 {
+ compatible = "rockchip,rk806";
+ reg = <0x23>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ interrupt-parent = <&gpio0>;
+ interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
+ <&rk806_dvs2_null>, <&rk806_dvs3_null>;
+ system-power-controller;
+
+ vcc1-supply = <&vcc_5v0_sys>;
+ vcc2-supply = <&vcc_5v0_sys>;
+ vcc3-supply = <&vcc_5v0_sys>;
+ vcc4-supply = <&vcc_5v0_sys>;
+ vcc5-supply = <&vcc_5v0_sys>;
+ vcc6-supply = <&vcc_5v0_sys>;
+ vcc7-supply = <&vcc_5v0_sys>;
+ vcc8-supply = <&vcc_5v0_sys>;
+ vcc9-supply = <&vcc_5v0_sys>;
+ vcc10-supply = <&vcc_5v0_sys>;
+ vcc11-supply = <&vcc_2v0_pldo_s3>;
+ vcc12-supply = <&vcc_5v0_sys>;
+ vcc13-supply = <&vcc_1v1_nldo_s3>;
+ vcc14-supply = <&vcc_1v1_nldo_s3>;
+ vcca-supply = <&vcc_5v0_sys>;
+
+ rk806_dvs1_null: dvs1-null-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs2_null: dvs2-null-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs3_null: dvs3-null-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs1_slp: dvs1-slp-pins {
+ pins = "gpio_pwrctrl1";
+ function = "pin_fun1";
+ };
+
+ rk806_dvs1_pwrdn: dvs1-pwrdn-pins {
+ pins = "gpio_pwrctrl1";
+ function = "pin_fun2";
+ };
+
+ rk806_dvs1_rst: dvs1-rst-pins {
+ pins = "gpio_pwrctrl1";
+ function = "pin_fun3";
+ };
+
+ rk806_dvs2_slp: dvs2-slp-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun1";
+ };
+
+ rk806_dvs2_pwrdn: dvs2-pwrdn-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun2";
+ };
+
+ rk806_dvs2_rst: dvs2-rst-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun3";
+ };
+
+ rk806_dvs2_dvs: dvs2-dvs-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun4";
+ };
+
+ rk806_dvs2_gpio: dvs2-gpio-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun5";
+ };
+
+
+ rk806_dvs3_slp: dvs3-slp-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun1";
+ };
+
+ rk806_dvs3_pwrdn: dvs3-pwrdn-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun2";
+ };
+
+ rk806_dvs3_rst: dvs3-rst-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun3";
+ };
+
+ rk806_dvs3_dvs: dvs3-dvs-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun4";
+ };
+
+ rk806_dvs3_gpio: dvs3-gpio-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun5";
+ };
+
+ regulators {
+ vdd_cpu_big_s0: dcdc-reg1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+ regulator-name = "vdd_cpu_big_s0";
+ regulator-enable-ramp-delay = <400>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_npu_s0: dcdc-reg2 {
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+ regulator-name = "vdd_npu_s0";
+ regulator-enable-ramp-delay = <400>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_cpu_lit_s0: dcdc-reg3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+ regulator-name = "vdd_cpu_lit_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ regulator-suspend-microvolt = <750000>;
+ };
+ };
+
+ vcc_3v3_s3: dcdc-reg4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc_3v3_s3";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+
+ vdd_gpu_s0: dcdc-reg5 {
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <900000>;
+ regulator-ramp-delay = <12500>;
+ regulator-name = "vdd_gpu_s0";
+ regulator-enable-ramp-delay = <400>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ regulator-suspend-microvolt = <850000>;
+ };
+ };
+
+ vddq_ddr_s0: dcdc-reg6 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vddq_ddr_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_logic_s0: dcdc-reg7 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <800000>;
+ regulator-name = "vdd_logic_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_1v8_s3: dcdc-reg8 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc_1v8_s3";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1800000>;
+ };
+ };
+
+ vdd2_ddr_s3: dcdc-reg9 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vdd2_ddr_s3";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vdd_ddr_s0: dcdc-reg10 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-name = "vdd_ddr_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcca_1v8_s0: pldo-reg1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca_1v8_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcca1v8_pldo2_s0: pldo-reg2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca1v8_pldo2_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda_1v2_s0: pldo-reg3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-name = "vdda_1v2_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcca_3v3_s0: pldo-reg4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcca_3v3_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vccio_sd_s0: pldo-reg5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vccio_sd_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcca1v8_pldo6_s3: pldo-reg6 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca1v8_pldo6_s3";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1800000>;
+ };
+ };
+
+ vdd_0v75_s3: nldo-reg1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <750000>;
+ regulator-name = "vdd_0v75_s3";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <750000>;
+ };
+ };
+
+ vdda_ddr_pll_s0: nldo-reg2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <850000>;
+ regulator-name = "vdda_ddr_pll_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda0v75_hdmi_s0: nldo-reg3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <837500>;
+ regulator-max-microvolt = <837500>;
+ regulator-name = "vdda0v75_hdmi_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda_0v85_s0: nldo-reg4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <850000>;
+ regulator-max-microvolt = <850000>;
+ regulator-name = "vdda_0v85_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda_0v75_s0: nldo-reg5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <750000>;
+ regulator-name = "vdda_0v75_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+ };
+ };
+};
+
+&i2c2 {
+ status = "okay";
+
+ hym8563: rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-output-names = "hym8563";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PA5 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hym8563_int>;
+ wakeup-source;
+ };
+};
+
+&pcie0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie_reset>;
+ reset-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc_3v3_pcie>;
+ status = "okay";
+};
+
+&pinctrl {
+ hdmi {
+ hdmi_con_en: hdmi-con-en {
+ rockchip,pins = <4 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
+ hym8563 {
+ hym8563_int: hym8563-int {
+ rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
+ pcie {
+ pcie_pwr_en: pcie-pwr-en {
+ rockchip,pins = <4 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+
+ pcie_reset: pcie-reset {
+ rockchip,pins = <2 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
+ usb {
+ usb_host_pwr_en: usb-host-pwr-en {
+ rockchip,pins = <1 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ usb_otg0_pwr_en: usb-otg0-pwr-en {
+ rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ usbc0_int: usbc0-int {
+ rockchip,pins = <3 RK_PD4 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+};
+
+&rng {
+ status = "okay";
+};
+
+&saradc {
+ vref-supply = <&vcca_1v8_s0>;
+ status = "okay";
+};
+
+&sdhci {
+ bus-width = <8>;
+ full-pwr-cycle-in-suspend;
+ max-frequency = <200000000>;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ no-sd;
+ no-sdio;
+ non-removable;
+ status = "okay";
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart4m1_xfer &uart4m1_ctsn>;
+ status = "okay";
+};
+
+&u2phy1 {
+ status = "okay";
+};
+
+&u2phy1_otg {
+ phy-supply = <&vcc_5v0_host>;
+ status = "okay";
+};
+
+&usb_drd1_dwc3 {
+ dr_mode = "host";
+ status = "okay";
+};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dts b/arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dts
new file mode 100644
index 000000000000..70d9ec50fe07
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dts
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2024 Rockchip Electronics Co., Ltd.
+ *
+ */
+
+/dts-v1/;
+
+#include "rk3576-luckfox-core3576.dtsi"
+
+/ {
+ model = "Luckfox Omni3576";
+ compatible = "luckfox,omni3576", "rockchip,rk3576";
+
+ aliases {
+ mmc0 = &sdhci;
+ mmc1 = &sdmmc;
+ };
+
+ leds: leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&led_green_pin>;
+
+ green_led: green-led {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_HEARTBEAT;
+ gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&pinctrl {
+ leds {
+ led_green_pin: led-green-pin {
+ rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
+&sdmmc {
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ disable-wp;
+ max-frequency = <200000000>;
+ no-sdio;
+ sd-uhs-sdr104;
+ vmmc-supply = <&vcc_3v3_s3>;
+ vqmmc-supply = <&vccio_sd_s0>;
+ status = "okay";
+};
--
2.39.5
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576
2025-05-06 11:41 [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
` (2 preceding siblings ...)
2025-05-06 11:41 ` [PATCH v3 3/3] arm64: dts: rockchip: Add Luckfox Omni3576 Board support John Clark
@ 2025-05-06 17:05 ` Krzysztof Kozlowski
2025-05-06 17:14 ` John Clark
2025-05-06 18:23 ` Rob Herring (Arm)
4 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-06 17:05 UTC (permalink / raw)
To: John Clark, heiko
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh, conor+dt,
jonas, frattaroli.nicolas, andrew
On 06/05/2025 13:41, John Clark wrote:
> This series adds device tree support for the Luckfox Omni3576
> Carrier Board with the Core3576 Module, powered by the Rockchip
> RK3576 SoC (four Cortex-A72 cores, four Cortex-A53 cores, Mali-G52
> MC3 GPU). It enables essential functionality for booting Linux and
> basic connectivity, with plans for future support of peripherals
> like WiFi, MIPI-DSI, HDMI, and Ethernet.
>
> The series was first posted as v1 at:
> https://lore.kernel.org/linux-rockchip/20250502205533.51744-1-inindev@gmail.com
> v2 at:
> https://lore.kernel.org/linux-rockchip/20250504102447.153551-1-inindev@gmail.com
You got extensive guideline what to do in my reply to avoid exactly the
mistake you did ... yet you ignored the guideline.
I don't understand.
Are you going to ignore also Conor's tags?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576
2025-05-06 17:05 ` [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Krzysztof Kozlowski
@ 2025-05-06 17:14 ` John Clark
2025-05-06 17:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: John Clark @ 2025-05-06 17:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, heiko
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh, conor+dt,
jonas, frattaroli.nicolas, andrew
On 5/6/25 1:05 PM, Krzysztof Kozlowski wrote:
> On 06/05/2025 13:41, John Clark wrote:
>> This series adds device tree support for the Luckfox Omni3576
>> Carrier Board with the Core3576 Module, powered by the Rockchip
>> RK3576 SoC (four Cortex-A72 cores, four Cortex-A53 cores, Mali-G52
>> MC3 GPU). It enables essential functionality for booting Linux and
>> basic connectivity, with plans for future support of peripherals
>> like WiFi, MIPI-DSI, HDMI, and Ethernet.
>>
>> The series was first posted as v1 at:
>> https://lore.kernel.org/linux-rockchip/20250502205533.51744-1-inindev@gmail.com
>> v2 at:
>> https://lore.kernel.org/linux-rockchip/20250504102447.153551-1-inindev@gmail.com
> You got extensive guideline what to do in my reply to avoid exactly the
> mistake you did ... yet you ignored the guideline.
I did not ignore it, I took this to mean:
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets."
that I should not use the "--in-reply-to" on my git submission which
caused the emails to be nested. I see now that you were referring to
adding the urls to my submission.
I realize this is probably painful to go through over and over again
with new contributors as they try to carefully follow all of the linux
submission guidelines and I apologize for my ignorance.
>
> I don't understand.
>
> Are you going to ignore also Conor's tags?
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576
2025-05-06 17:14 ` John Clark
@ 2025-05-06 17:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-06 17:16 UTC (permalink / raw)
To: John Clark, heiko
Cc: linux-arm-kernel, devicetree, linux-rockchip, robh, conor+dt,
jonas, frattaroli.nicolas, andrew
On 06/05/2025 19:14, John Clark wrote:
> On 5/6/25 1:05 PM, Krzysztof Kozlowski wrote:
>> On 06/05/2025 13:41, John Clark wrote:
>>> This series adds device tree support for the Luckfox Omni3576
>>> Carrier Board with the Core3576 Module, powered by the Rockchip
>>> RK3576 SoC (four Cortex-A72 cores, four Cortex-A53 cores, Mali-G52
>>> MC3 GPU). It enables essential functionality for booting Linux and
>>> basic connectivity, with plans for future support of peripherals
>>> like WiFi, MIPI-DSI, HDMI, and Ethernet.
>>>
>>> The series was first posted as v1 at:
>>> https://lore.kernel.org/linux-rockchip/20250502205533.51744-1-inindev@gmail.com
>>> v2 at:
>>> https://lore.kernel.org/linux-rockchip/20250504102447.153551-1-inindev@gmail.com
>> You got extensive guideline what to do in my reply to avoid exactly the
>> mistake you did ... yet you ignored the guideline.
>
> I did not ignore it, I took this to mean:
>
> > Do not attach (thread) your patchsets to some other threads (unrelated
> > or older versions). This buries them deep in the mailbox and might
> > interfere with applying entire sets."
>
> that I should not use the "--in-reply-to" on my git submission which
> caused the emails to be nested. I see now that you were referring to
> adding the urls to my submission.
> I realize this is probably painful to go through over and over again
> with new contributors as they try to carefully follow all of the linux
> submission guidelines and I apologize for my ignorance.
The next instruction, not that one. The instruction saying:
"...because many review tags are being ignored."
with much bigger explanation what is expected now and what should you do.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576
2025-05-06 11:41 [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 John Clark
` (3 preceding siblings ...)
2025-05-06 17:05 ` [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576 Krzysztof Kozlowski
@ 2025-05-06 18:23 ` Rob Herring (Arm)
2025-05-06 21:18 ` Heiko Stübner
4 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2025-05-06 18:23 UTC (permalink / raw)
To: John Clark
Cc: krzysztof.kozlowski, linux-arm-kernel, linux-rockchip,
frattaroli.nicolas, devicetree, heiko, jonas, conor+dt, andrew
On Tue, 06 May 2025 07:41:12 -0400, John Clark wrote:
> This series adds device tree support for the Luckfox Omni3576
> Carrier Board with the Core3576 Module, powered by the Rockchip
> RK3576 SoC (four Cortex-A72 cores, four Cortex-A53 cores, Mali-G52
> MC3 GPU). It enables essential functionality for booting Linux and
> basic connectivity, with plans for future support of peripherals
> like WiFi, MIPI-DSI, HDMI, and Ethernet.
>
> The series was first posted as v1 at:
> https://lore.kernel.org/linux-rockchip/20250502205533.51744-1-inindev@gmail.com
> v2 at:
> https://lore.kernel.org/linux-rockchip/20250504102447.153551-1-inindev@gmail.com
>
> Tested features (on Linux 6.15-rc4):
> - UART: Serial console operational
> - SD card: Mounts and reads/writes successfully
> - PCIe: NVMe SSD detected, mounted, and fully functional
> - USB 2.0: Host ports operational
> - RTC: Timekeeping and wake-up tested
> - LED: Heartbeat trigger functional
> - eMMC: Enabled in device tree, not populated on tested hardware
>
> The series includes three patches:
> 1. dt-bindings: vendor-prefixes: Add Luckfox vendor prefix
> 2. dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
> 3. arm64: dts: rockchip: Add Luckfox Omni3576 board support
>
> The device tree is covered by the existing ROCKCHIP ARCHITECTURE
> entry in MAINTAINERS. I am aware of ongoing RK3576 upstreaming
> efforts (e.g., by Collabora) and welcome feedback or collaboration
> to align with mainline driver development.
>
> Changes in v3:
> - Addressed Jonas Karlman's feedback on patch 3/3
> (Luckfox Omni3576 device tree):
> - Added pinctrl for green LED GPIO (gpio1 RK_PD5) for proper
> pin setup.
> - Reordered regulator node properties for consistent sequence
> (e.g., regulator-name, regulator-min-microvolt,
> regulator-max-microvolt, etc.).
> - Updated regulator nodes (vcc_3v3_pcie, vbus_5v0_typec,
> vcc_5v0_host, vcc_5v0_hdmi) to use 'gpios' property instead
> of deprecated 'gpio'.
> - Removed pmic-power-off pinctrl state and pinctrl-1 from RK806
> PMIC node, as they are vendor-specific and undocumented in
> bindings.
> - Removed pwrkey node from PMIC, as it lacks binding
> documentation.
> - Added blank line between properties and child nodes in i2c2
> node for DT style compliance.
> - Removed no-mmc property from sdmmc node to enable MMC
> support, aligning with RK3576 SD v3.0 and MMC v4.51
> capabilities, allowing TF card slot to support MMC devices
> or eMMC via adapter.
> - Removed Ethernet support (gmac0/gmac1 nodes) per Andrew Lunn's
> feedback, as it relied on the generic PHY driver with incorrect
> RGMII delay settings, which would break with the upcoming
> MAE0621A driver.
> - Addressed Rob Herring's DTB check warnings, other warnings
> (e.g., VOP, PCIe, OTP, HDMI PHY) originate from rk3576.dtsi and
> are outside this patchset scope.
> - Added RNG node to pick up Nicolas Frattaroli's "add RK3576 RNG
> node" patch
>
> Changes in v2:
> - Enabled HDMI node per feedback from Heiko Stuebner and Nicolas
> Frattaroli; untested due to upstream driver issues.
> - Enabled Ethernet 1 node per Heiko's device tree philosophy;
> untested due to suspected PHY driver or configuration issues
> (removed in v3 per Andrew Lunn).
> - Clarified eMMC remains enabled but unpopulated on tested
> board, per Heiko.
>
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
> John Clark (3):
> dt-bindings: vendor-prefixes: Add luckfox prefix
> dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
> arm64: dts: rockchip: Add Luckfox Omni3576 Board support
>
> .../devicetree/bindings/arm/rockchip.yaml | 10 +
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3576-luckfox-core3576.dtsi | 683 ++++++++++++++++++
> .../dts/rockchip/rk3576-luckfox-omni3576.dts | 53 ++
> 5 files changed, 749 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dts
>
> --
> 2.39.5
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250506 (best guess, 2/3 blobs matched)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250506114115.613616-1-inindev@gmail.com:
arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dtb: /soc/rng@2a410000: failed to match any schema with compatible: ['rockchip,rk3576-rng']
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v3 0/3] Add Luckfox Omni3576 Carrier Board support for RK3576
2025-05-06 18:23 ` Rob Herring (Arm)
@ 2025-05-06 21:18 ` Heiko Stübner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2025-05-06 21:18 UTC (permalink / raw)
To: John Clark, Rob Herring (Arm)
Cc: krzysztof.kozlowski, linux-arm-kernel, linux-rockchip,
frattaroli.nicolas, devicetree, jonas, conor+dt, andrew
Am Dienstag, 6. Mai 2025, 20:23:55 Mitteleuropäische Sommerzeit schrieb Rob Herring (Arm):
>
> On Tue, 06 May 2025 07:41:12 -0400, John Clark wrote:
> > This series adds device tree support for the Luckfox Omni3576
> > Carrier Board with the Core3576 Module, powered by the Rockchip
> > RK3576 SoC (four Cortex-A72 cores, four Cortex-A53 cores, Mali-G52
> > MC3 GPU). It enables essential functionality for booting Linux and
> > basic connectivity, with plans for future support of peripherals
> > like WiFi, MIPI-DSI, HDMI, and Ethernet.
> >
> > The series was first posted as v1 at:
> > https://lore.kernel.org/linux-rockchip/20250502205533.51744-1-inindev@gmail.com
> > v2 at:
> > https://lore.kernel.org/linux-rockchip/20250504102447.153551-1-inindev@gmail.com
> >
> > Tested features (on Linux 6.15-rc4):
> > - UART: Serial console operational
> > - SD card: Mounts and reads/writes successfully
> > - PCIe: NVMe SSD detected, mounted, and fully functional
> > - USB 2.0: Host ports operational
> > - RTC: Timekeeping and wake-up tested
> > - LED: Heartbeat trigger functional
> > - eMMC: Enabled in device tree, not populated on tested hardware
> >
> > The series includes three patches:
> > 1. dt-bindings: vendor-prefixes: Add Luckfox vendor prefix
> > 2. dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
> > 3. arm64: dts: rockchip: Add Luckfox Omni3576 board support
> >
> > The device tree is covered by the existing ROCKCHIP ARCHITECTURE
> > entry in MAINTAINERS. I am aware of ongoing RK3576 upstreaming
> > efforts (e.g., by Collabora) and welcome feedback or collaboration
> > to align with mainline driver development.
> >
> > Changes in v3:
> > - Addressed Jonas Karlman's feedback on patch 3/3
> > (Luckfox Omni3576 device tree):
> > - Added pinctrl for green LED GPIO (gpio1 RK_PD5) for proper
> > pin setup.
> > - Reordered regulator node properties for consistent sequence
> > (e.g., regulator-name, regulator-min-microvolt,
> > regulator-max-microvolt, etc.).
> > - Updated regulator nodes (vcc_3v3_pcie, vbus_5v0_typec,
> > vcc_5v0_host, vcc_5v0_hdmi) to use 'gpios' property instead
> > of deprecated 'gpio'.
> > - Removed pmic-power-off pinctrl state and pinctrl-1 from RK806
> > PMIC node, as they are vendor-specific and undocumented in
> > bindings.
> > - Removed pwrkey node from PMIC, as it lacks binding
> > documentation.
> > - Added blank line between properties and child nodes in i2c2
> > node for DT style compliance.
> > - Removed no-mmc property from sdmmc node to enable MMC
> > support, aligning with RK3576 SD v3.0 and MMC v4.51
> > capabilities, allowing TF card slot to support MMC devices
> > or eMMC via adapter.
> > - Removed Ethernet support (gmac0/gmac1 nodes) per Andrew Lunn's
> > feedback, as it relied on the generic PHY driver with incorrect
> > RGMII delay settings, which would break with the upcoming
> > MAE0621A driver.
> > - Addressed Rob Herring's DTB check warnings, other warnings
> > (e.g., VOP, PCIe, OTP, HDMI PHY) originate from rk3576.dtsi and
> > are outside this patchset scope.
> > - Added RNG node to pick up Nicolas Frattaroli's "add RK3576 RNG
> > node" patch
> >
> > Changes in v2:
> > - Enabled HDMI node per feedback from Heiko Stuebner and Nicolas
> > Frattaroli; untested due to upstream driver issues.
> > - Enabled Ethernet 1 node per Heiko's device tree philosophy;
> > untested due to suspected PHY driver or configuration issues
> > (removed in v3 per Andrew Lunn).
> > - Clarified eMMC remains enabled but unpopulated on tested
> > board, per Heiko.
> >
> > Signed-off-by: John Clark <inindev@gmail.com>
> > ---
> > John Clark (3):
> > dt-bindings: vendor-prefixes: Add luckfox prefix
> > dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings
> > arm64: dts: rockchip: Add Luckfox Omni3576 Board support
> >
> > .../devicetree/bindings/arm/rockchip.yaml | 10 +
> > .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../dts/rockchip/rk3576-luckfox-core3576.dtsi | 683 ++++++++++++++++++
> > .../dts/rockchip/rk3576-luckfox-omni3576.dts | 53 ++
> > 5 files changed, 749 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-luckfox-core3576.dtsi
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dts
> >
> > --
> > 2.39.5
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: attempting to guess base-commit...
> Base: tags/next-20250506 (best guess, 2/3 blobs matched)
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250506114115.613616-1-inindev@gmail.com:
>
> arch/arm64/boot/dts/rockchip/rk3576-luckfox-omni3576.dtb: /soc/rng@2a410000: failed to match any schema with compatible: ['rockchip,rk3576-rng']
the binding (and driver) for the rk3576-rng have been merged into the
cryptodev tree yesterday [0], so that issue should hopefully go away with
the next linux-next.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=165ef524bbeb71ccd470e70a4e63f813fa71e7cd
^ permalink raw reply [flat|nested] 14+ messages in thread