Re: [PATCH v3] cpufreq: scmi: Skip SCMI devices that aren't used by the CPUs

Sudeep Holla
2025-05-06T12:10:52Z

On Mon, May 05, 2025 at 06:25:50PM -0700, Mike Tipton wrote:
> On Mon, Apr 28, 2025 at 07:47:28AM -0700, Mike Tipton wrote:
> > Currently, all SCMI devices with performance domains attempt to register
> > a cpufreq driver, even if their performance domains aren't used to
> > control the CPUs. The cpufreq framework only supports registering a
> > single driver, so only the first device will succeed. And if that device
> > isn't used for the CPUs, then cpufreq will scale the wrong domains.
> >
> > To avoid this, return early from scmi_cpufreq_probe() if the probing
> > SCMI device isn't referenced by the CPU device phandles.
> >
> > This keeps the existing assumption that all CPUs are controlled by a
> > single SCMI device.
> >
> > Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
> > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > ---
>
> Hi Sudeep / Viresh,
>
> Any thoughts on this?
>

I have actually queued and forgot to respond. Though I realise the change
is not dependent on any other changes now.

Viresh, hope you are OK with me taking this change or do you prefer to take
it via your tree ? I am fine with that as well.

--
Regards,
Sudeep