From: Sudeep Holla <sudeep.holla@arm.com>
To: <linux-pm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] cpuidle: psci: Avoid initializing faux device if no DT idle states are present
Date: Wed, 7 May 2025 14:55:57 +0100 [thread overview]
Message-ID: <20250507-crouching-lovely-wrasse-f85e90@sudeepholla> (raw)
In-Reply-To: <20250502140119.2578909-1-sudeep.holla@arm.com>
Hi Rafael,
On Fri, May 02, 2025 at 03:01:19PM +0100, Sudeep Holla wrote:
> Commit af5376a77e87 ("cpuidle: psci: Transition to the faux device interface")
> transitioned the PSCI cpuidle driver from using a platform device to the
> faux device framework. However, unlike platform devices, the faux device
> infrastructure logs an error when the probe function fails, even if the
> failure is intentional or expected.
>
> To prevent unnecessary error logs, we can skip creating the faux device
> entirely if there are no PSCI idle states defined in the device tree.
> Introduce a check for DT idle states during initialization and avoid
> setting up the device if none are found.
>
> This ensures cleaner logs and avoids misleading probe failure messages
> when PSCI idle support is intentionally not described in DT.
>
As you pointed out in another similar fix that exist only in the linux-next,
I have also missed to point out that fact here. This is only present in
the next. Let me know if you want me to drop the commit hash reference
and repost it with -next prefix which I generally do and somehow clearly
missed here. Sorry for that.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-05-07 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 14:01 [PATCH] cpuidle: psci: Avoid initializing faux device if no DT idle states are present Sudeep Holla
2025-05-02 15:16 ` Ulf Hansson
2025-05-02 15:50 ` Sudeep Holla
2025-05-07 13:55 ` Sudeep Holla [this message]
2025-05-07 14:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507-crouching-lovely-wrasse-f85e90@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox