Re: [PATCH 1/3] arm64: dts: fvp: Add CPU idle states for Rev C model

[Sudeep Holla <sudeep.holla@arm.com>]

On Thu, May 08, 2025 at 05:09:20PM +0100, Leo Yan wrote:
> Hi Sudeep,
> 
> On Thu, May 08, 2025 at 11:32:23AM +0100, Sudeep Holla wrote:
> > Add CPU idle state definitions to the FVP Rev C device tree to enable
> > support for CPU lower power modes. This allows the system to properly
> > enter low power states during idle. It is disabled by default as it is
> > know to impact performance on the models.
> > 
> > Note that the power_state parameter(arm,psci-suspend-param) doesn't use
> > the Extended StateID format for compatibility reasons on FVP.
> > 
> > Tested on the FVP Rev C model with PSCI support enabled firmware.
> 
> I verified this series and confirmed the CPUIdle states work well (I
> manually removed the status = "disabled" in idle state nodes).
> 
> Tested-by: Leo Yan <leo.yan@arm.com>
> 
> Just a nitpick, we should firstly add the timer node and then add the
> idle state nodes, as CPUIdle is dependent on broadcast timer.
> 
> As the idle states are disabled by default, current patch ordering
> would be fine as well.
>

Good point, I will reverse the order when applying. Thanks for the testing.

-- 
Regards,
Sudeep