Re: [PATCH 2/2] arm64: dts: imx8mp: Add TechNexion EDM-G-IMX8M-PLUS SoM on WB-EDM-G carrier board

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

On Fri, May 09, 2025 at 03:58:32PM +0200, Krzysztof Kozlowski wrote:
> On 09/05/2025 15:21, Krzysztof Kozlowski wrote:
> > 
> > No, that's not a spi controller.
> > 
> > Node names should be generic. See also an explanation and list of
> > examples (not exhaustive) in DT specification:
> > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> > 
> > 
> >> +		compatible = "rohm,dh2228fv";
> > 
> > I doubt that. Drop the node or fix the compatible.
> 
> ... especially that dh2228fv does not exist. There is no such device
> from ROHM. If you claim otherwise, please share this imaginary device
> datasheet.

To be clear, the thing to do if you have some device without a kernel
driver and want to use spidev for it, is to add a binding for the
device and add the device specific compatible to spidev.c.
If it is a simple device with no unusual properties (maybe it has an
interrupt, that's fine) add it to trivial-devices.yaml instead of
writing a dedicated binding.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]