From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Ray Jui <rjui@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Vladimir Zapolskiy <vz@mleia.com>, Keerthy <j-keerthy@ti.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH RFC 5/9] gpio: davinci: Update irq chip data
Date: Fri, 09 May 2025 12:45:36 +0800 [thread overview]
Message-ID: <20250509-gpio-v1-5-639377c98288@nxp.com> (raw)
In-Reply-To: <20250509-gpio-v1-0-639377c98288@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Use "struct davinci_gpio_controller *chips" as irq chip data to prepare
for immutable irq chip, then it will be easy to get gpio_chip pointer in
irq mask/unmask.
No functional change.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/gpio/gpio-davinci.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 3c3b3ed46d9b480eb7916fa2402e5bbcc06cd563..4494acc14630bcc7cb75dc475b5ae7e0a595cc5c 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -68,15 +68,6 @@ static inline u32 __gpio_mask(unsigned gpio)
return 1 << (gpio % 32);
}
-static inline struct davinci_gpio_regs __iomem *irq2regs(struct irq_data *d)
-{
- struct davinci_gpio_regs __iomem *g;
-
- g = (__force struct davinci_gpio_regs __iomem *)irq_data_get_irq_chip_data(d);
-
- return g;
-}
-
static int davinci_gpio_irq_setup(struct platform_device *pdev);
/*--------------------------------------------------------------------------*/
@@ -255,7 +246,9 @@ static int davinci_gpio_probe(struct platform_device *pdev)
static void gpio_irq_mask(struct irq_data *d)
{
- struct davinci_gpio_regs __iomem *g = irq2regs(d);
+ struct davinci_gpio_controller *chips = irq_data_get_irq_chip_data(d);
+ irq_hw_number_t hwirq = irqd_to_hwirq(d);
+ struct davinci_gpio_regs __iomem *g = chips->regs[hwirq / 32];
uintptr_t mask = (uintptr_t)irq_data_get_irq_handler_data(d);
writel_relaxed(mask, &g->clr_falling);
@@ -264,7 +257,9 @@ static void gpio_irq_mask(struct irq_data *d)
static void gpio_irq_unmask(struct irq_data *d)
{
- struct davinci_gpio_regs __iomem *g = irq2regs(d);
+ struct davinci_gpio_controller *chips = irq_data_get_irq_chip_data(d);
+ irq_hw_number_t hwirq = irqd_to_hwirq(d);
+ struct davinci_gpio_regs __iomem *g = chips->regs[hwirq / 32];
uintptr_t mask = (uintptr_t)irq_data_get_irq_handler_data(d);
unsigned status = irqd_get_trigger_type(d);
@@ -399,12 +394,11 @@ davinci_gpio_irq_map(struct irq_domain *d, unsigned int irq,
{
struct davinci_gpio_controller *chips =
(struct davinci_gpio_controller *)d->host_data;
- struct davinci_gpio_regs __iomem *g = chips->regs[hw / 32];
irq_set_chip_and_handler_name(irq, &gpio_irqchip, handle_simple_irq,
"davinci_gpio");
irq_set_irq_type(irq, IRQ_TYPE_NONE);
- irq_set_chip_data(irq, (__force void *)g);
+ irq_set_chip_data(irq, (__force void *)chips);
irq_set_handler_data(irq, (void *)(uintptr_t)__gpio_mask(hw));
return 0;
--
2.37.1
next prev parent reply other threads:[~2025-05-09 4:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 4:45 [PATCH RFC 0/9] gpio: make irq_chip immutable Peng Fan (OSS)
2025-05-09 4:45 ` [PATCH RFC 1/9] gpio: bcm-kona: " Peng Fan (OSS)
2025-05-09 4:45 ` [PATCH RFC 2/9] gpio: grgpio: Make " Peng Fan (OSS)
2025-05-09 4:45 ` [PATCH RFC 3/9] gpio: lpc18xx: " Peng Fan (OSS)
2025-05-09 4:45 ` [PATCH RFC 4/9] gpio: mpc8xxx: " Peng Fan (OSS)
2025-05-09 4:45 ` Peng Fan (OSS) [this message]
2025-05-09 4:45 ` [PATCH RFC 6/9] gpio: davinci: " Peng Fan (OSS)
2025-05-09 4:45 ` [PATCH RFC 7/9] gpio: xgene-sb: " Peng Fan (OSS)
2025-05-09 4:45 ` [PATCH RFC 8/9] gpio: timberdale: " Peng Fan (OSS)
2025-05-10 18:26 ` Andy Shevchenko
2025-05-09 4:45 ` [PATCH RFC 9/9] gpio: pxa: " Peng Fan (OSS)
2025-05-10 18:29 ` [PATCH RFC 0/9] gpio: make " Andy Shevchenko
2025-05-13 13:13 ` Linus Walleij
2025-05-15 15:02 ` Bartosz Golaszewski
2025-05-19 3:56 ` Peng Fan
2025-05-19 11:11 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509-gpio-v1-5-639377c98288@nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=florian.fainelli@broadcom.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=sbranden@broadcom.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).