From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAC2AC3ABC3 for ; Sun, 11 May 2025 08:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To: References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version: Subject:Date:From:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h51LBZaDZp3CApx9/ovuaLN9jgQPl15ML/ibQWQJlwo=; b=qrvPEqOwCYABDY4KXVTCgaI2he BELH2TETTIOQnTlEzLI/wPu+31YfINxATVgngOXD0znVjN9M6EahWM32wyzG8kBNRhIRUP0G6Yo1w YQJW6q7cnd+7jtpR/P1K97B0JG5dtGn1X1On/CdkQrZauHl8Um1JVcU5CM9akSn0DZgSNuHmBpDKk tafxVJS9LB0mO1pthCvqSz82DyKmWFy0CaKqzNTjmiCiU7emKEGKhZho24UprEscIKQSuvEBhHexj oxmtPhLgtmeBMF7kdsZDQ4jx/hnO2FATWo7XZN4SLKSASTyjxPYaTEp+G58qmNMzjiRaZiBfCuCxJ 70tlM35g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uE29s-00000006xAM-2hC4; Sun, 11 May 2025 08:35:40 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uE1tv-00000006vjn-3MOj for linux-arm-kernel@lists.infradead.org; Sun, 11 May 2025 08:19:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B9A1B4A854; Sun, 11 May 2025 08:19:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 3D297C4CEF3; Sun, 11 May 2025 08:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746951549; bh=fyoSR2vLCkN9Of3j5viNH1hbR1jgKe6RpyBqQH/Is+0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=APBZo7dv5F2VZKeWmWhRDizhpN9GcxSb22TGPlLJeaVLaUK5ZD9eVDeNc5JSz63ww b4uA4VK00OmmjgEEGqAIWDk/KKFxfLATKrEH219fbgwADwN1Wcq08hlc274mjprjB0 l/35jM+7H+DbeKlb3PdcCEaxAT5Nqirw7FOsMfbtzPpdU/81XAApoQOPdPwuy+Egig LTjI9CFewESbBJ1MMRispKbJA/6I+ASIkPM/W6AHS21x+ShthdzBku54v+dTlKvikt 0Cj1Fwr+tu3HD/s7qYwQH6jcmN+1tiVcKNjD66LDLlezDC8T7kzvBbA1wY9sN90M4E 14fpLxazoBfQw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336E4C3ABC5; Sun, 11 May 2025 08:19:09 +0000 (UTC) From: Sven Peter via B4 Relay Date: Sun, 11 May 2025 08:18:39 +0000 Subject: [PATCH v5 04/10] soc: apple: rtkit: Make shmem_destroy optional MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250511-smc-6-15-v5-4-f5980bdb18bd@svenpeter.dev> References: <20250511-smc-6-15-v5-0-f5980bdb18bd@svenpeter.dev> In-Reply-To: <20250511-smc-6-15-v5-0-f5980bdb18bd@svenpeter.dev> To: Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Hector Martin , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Lee Jones , Marc Zyngier , "Russell King (Oracle)" Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=891; i=sven@svenpeter.dev; h=from:subject:message-id; bh=d7cJ/m6HJgQ6SMj9oocBKxe7pX9DRz2PYGSqdwBEGoU=; b=owGbwMvMwCHmIlirolUq95LxtFoSQ4ZCbMlNLpf7W188qZ/+d8/jton7lh5fVXLgW0fBjmuvD r+V5GHy6yhlYRDjYJAVU2TZvt/e9MnDN4JLN116DzOHlQlkCAMXpwBM5M1mRoa1QlM3bq+e5qDL G6b4bxOTd3tB9OkZyh6bwpdv2BEobS/B8D9S4kFF3xpvRb7/28U9J/FmGfq/+tgpGtd5vGHvsRv b9nIBAA== X-Developer-Key: i=sven@svenpeter.dev; a=openpgp; fpr=A1E3E34A2B3C820DBC4955E5993B08092F131F93 X-Endpoint-Received: by B4 Relay for sven@svenpeter.dev/default with auth_id=167 X-Original-From: Sven Peter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250511_011911_944437_D7915C99 X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sven@svenpeter.dev Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Sven Peter shmem_destroy isn't always required for coprocessor-managed buffers but we still enforce that it exists. Just relax the check. Signed-off-by: Sven Peter --- drivers/soc/apple/rtkit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c index 5fffd0f003dc2f4f377faf96cce0c1ce4ff0b788..b8d4da147d23f7e99e76eea314e4d976cddbd1c6 100644 --- a/drivers/soc/apple/rtkit.c +++ b/drivers/soc/apple/rtkit.c @@ -279,8 +279,7 @@ static int apple_rtkit_common_rx_get_buffer(struct apple_rtkit *rtk, dev_dbg(rtk->dev, "RTKit: buffer request for 0x%zx bytes at %pad\n", buffer->size, &buffer->iova); - if (buffer->iova && - (!rtk->ops->shmem_setup || !rtk->ops->shmem_destroy)) { + if (buffer->iova && !rtk->ops->shmem_setup) { err = -EINVAL; goto error; } -- 2.34.1