From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Jacky Bai <ping.bai@nxp.com>, NXP S32 Linux Team <s32@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 2/3] pinctrl: imx-scmi: Get daisy register offset from DT
Date: Mon, 12 May 2025 10:14:15 +0800 [thread overview]
Message-ID: <20250512-pin-v1-2-d9f1555a55ad@nxp.com> (raw)
In-Reply-To: <20250512-pin-v1-0-d9f1555a55ad@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Parsing the "nxp,iomuxc-daisy-off" to get the daisy register offset,
then no need to hardcode the register offset in driver for new SoCs.
To keep backwards comatibility, still keep the register offset for i.MX95.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/pinctrl/freescale/pinctrl-imx-scmi.c | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx-scmi.c b/drivers/pinctrl/freescale/pinctrl-imx-scmi.c
index 8f15c4c4dc4412dddb40505699fc3f459fdc0adc..7c15244371c20e0d99b1802e480c39aaeeec495b 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx-scmi.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx-scmi.c
@@ -35,6 +35,7 @@ struct scmi_pinctrl_imx {
struct pinctrl_dev *pctldev;
struct pinctrl_desc pctl_desc;
const struct scmi_pinctrl_proto_ops *ops;
+ uint32_t daisy_off;
};
/* SCMI pin control types, aligned with SCMI firmware */
@@ -57,6 +58,7 @@ static int pinctrl_scmi_imx_dt_node_to_map(struct pinctrl_dev *pctldev,
struct pinctrl_map **map,
unsigned int *num_maps)
{
+ struct scmi_pinctrl_imx *pmx = pinctrl_dev_get_drvdata(pctldev);
struct pinctrl_map *new_map;
const __be32 *list;
unsigned long *configs = NULL;
@@ -65,16 +67,6 @@ static int pinctrl_scmi_imx_dt_node_to_map(struct pinctrl_dev *pctldev,
int mux_reg, conf_reg, input_reg, mux_val, conf_val, input_val;
int i, j;
uint32_t ncfg;
- static uint32_t daisy_off;
-
- if (!daisy_off) {
- if (of_machine_is_compatible("fsl,imx95")) {
- daisy_off = IMX95_DAISY_OFF;
- } else {
- dev_err(pctldev->dev, "platform not support scmi pinctrl\n");
- return -EINVAL;
- }
- }
list = of_get_property(np, "fsl,pins", &size);
if (!list) {
@@ -126,7 +118,7 @@ static int pinctrl_scmi_imx_dt_node_to_map(struct pinctrl_dev *pctldev,
ncfg -= 2;
} else {
cfg[j++] = pinconf_to_config_packed(IMX_SCMI_PIN_DAISY_ID,
- (input_reg - daisy_off) / 4);
+ (input_reg - pmx->daisy_off) / 4);
cfg[j++] = pinconf_to_config_packed(IMX_SCMI_PIN_DAISY_CFG, input_val);
}
@@ -315,6 +307,18 @@ static int scmi_pinctrl_imx_probe(struct scmi_device *sdev)
if (!pmx)
return -ENOMEM;
+ ret = device_property_read_u32(dev, "nxp,iomuxc-daisy-off", &pmx->daisy_off);
+ if (ret) {
+ /*
+ * To keep backwards compatible, new chips should specify
+ * nxp,iomuxc-daisy_off
+ */
+ if (of_machine_is_compatible("fsl,imx95"))
+ pmx->daisy_off = IMX95_DAISY_OFF;
+ else
+ return dev_err_probe(dev, ret, "Failed to get daisy off value\n");
+ }
+
pmx->ph = ph;
pmx->ops = pinctrl_ops;
--
2.37.1
next prev parent reply other threads:[~2025-05-12 2:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 2:14 [PATCH 0/3] pinctrl: imx-scmi: Introdue nxp,iomuxc-daisy-off Peng Fan (OSS)
2025-05-12 2:14 ` [PATCH 1/3] dt-bindings: firmware: nxp,imx95-scmi-pinctrl: Introduce nxp,iomuxc-daisy-off Peng Fan (OSS)
2025-05-12 16:20 ` Conor Dooley
2025-05-13 7:55 ` Peng Fan
2025-05-13 13:20 ` Linus Walleij
2025-05-14 9:27 ` Peng Fan
2025-05-12 2:14 ` Peng Fan (OSS) [this message]
2025-05-12 6:17 ` [PATCH 2/3] pinctrl: imx-scmi: Get daisy register offset from DT Sascha Hauer
2025-05-13 7:56 ` Peng Fan
2025-05-12 2:14 ` [PATCH 3/3] arm64: dts: imx95: Add property nxp,iomuxc-daisy-off Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512-pin-v1-2-d9f1555a55ad@nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).