* [PATCH] firmware: arm_scmi: Fix up turbo frequencies selection
@ 2025-05-14 21:47 Sibi Sankar
2025-06-27 10:01 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Sibi Sankar @ 2025-05-14 21:47 UTC (permalink / raw)
To: sudeep.holla, cristian.marussi, viresh.kumar, d-gole,
quic_mdtipton, avajid
Cc: arm-scmi, linux-arm-kernel, linux-kernel, linux-arm-msm,
Sibi Sankar
Sustained frequency when greater than or equal to 4Ghz on 64-bit devices
currently result in marking all frequencies as turbo. Address the turbo
frequency selection bug by fixing the truncation.
Fixes: a897575e79d7 ("firmware: arm_scmi: Add support for marking certain frequencies as turbo")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
drivers/firmware/arm_scmi/perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
index c7e5a34b254b..683fd9b85c5c 100644
--- a/drivers/firmware/arm_scmi/perf.c
+++ b/drivers/firmware/arm_scmi/perf.c
@@ -892,7 +892,7 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph,
freq = dom->opp[idx].indicative_freq * dom->mult_factor;
/* All OPPs above the sustained frequency are treated as turbo */
- data.turbo = freq > dom->sustained_freq_khz * 1000;
+ data.turbo = freq > dom->sustained_freq_khz * 1000UL;
data.level = dom->opp[idx].perf;
data.freq = freq;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] firmware: arm_scmi: Fix up turbo frequencies selection
2025-05-14 21:47 [PATCH] firmware: arm_scmi: Fix up turbo frequencies selection Sibi Sankar
@ 2025-06-27 10:01 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2025-06-27 10:01 UTC (permalink / raw)
To: cristian.marussi, viresh.kumar, d-gole, quic_mdtipton, avajid,
Sibi Sankar
Cc: Sudeep Holla, arm-scmi, linux-arm-kernel, linux-kernel,
linux-arm-msm
On Thu, 15 May 2025 03:17:19 +0530, Sibi Sankar wrote:
> Sustained frequency when greater than or equal to 4Ghz on 64-bit devices
> currently result in marking all frequencies as turbo. Address the turbo
> frequency selection bug by fixing the truncation.
>
>
Applied to sudeep.holla/linux (for-next/scmi/updates), thanks!
[1/1] firmware: arm_scmi: Fix up turbo frequencies selection
https://git.kernel.org/sudeep.holla/c/ad28fc31dd70
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-27 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-14 21:47 [PATCH] firmware: arm_scmi: Fix up turbo frequencies selection Sibi Sankar
2025-06-27 10:01 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).