From: Conor Dooley <conor@kernel.org>
To: Manikandan Muralidharan <manikandan.m@microchip.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: microchip: rename spi-cs-setup-ns property to spi-cs-setup-delay-ns
Date: Thu, 15 May 2025 16:07:25 +0100 [thread overview]
Message-ID: <20250515-laptop-unfixable-85dca20d1b57@spud> (raw)
In-Reply-To: <20250515103251.210468-1-manikandan.m@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 3144 bytes --]
On Thu, May 15, 2025 at 04:02:51PM +0530, Manikandan Muralidharan wrote:
> The naming scheme for delay properties includes "delay" in the name,
> so renaming spi-cs-setup-ns property to spi-cs-setup-delay-ns to keep
> that consistent.
"to keep that consistent" sounds like some nice cleanup, but these
properties appear nowhere in kernel code and therefore just do not work?
I think the wording should reflect that and there should be a Fixes tag
to the broken commit.
>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
> arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 2 +-
> arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi | 2 +-
> arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi | 2 +-
> arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> index cdc56b53299d..c1ff3248bd8f 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> @@ -609,7 +609,7 @@ flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <104000000>;
> - spi-cs-setup-ns = <7>;
> + spi-cs-setup-delay-ns = <7>;
> spi-tx-bus-width = <4>;
> spi-rx-bus-width = <4>;
> m25p,fast-read;
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
> index 8ac85dac5a96..13c28e92b17e 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi
> @@ -44,7 +44,7 @@ flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <104000000>;
> - spi-cs-setup-ns = <7>;
> + spi-cs-setup-delay-ns = <7>;
> spi-tx-bus-width = <4>;
> spi-rx-bus-width = <4>;
> m25p,fast-read;
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
> index ef11606a82b3..9543214adc9f 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi
> @@ -234,7 +234,7 @@ qspi1_flash: flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <104000000>;
> - spi-cs-setup-ns = <7>;
> + spi-cs-setup-delay-ns = <7>;
> spi-rx-bus-width = <4>;
> spi-tx-bus-width = <4>;
> m25p,fast-read;
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
> index 9fa6f1395aa6..fbae6a9af6c3 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
> @@ -714,7 +714,7 @@ flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <104000000>;
> - spi-cs-setup-ns = <7>;
> + spi-cs-setup-delay-ns = <7>;
> spi-tx-bus-width = <4>;
> spi-rx-bus-width = <4>;
> m25p,fast-read;
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-05-15 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 10:32 [PATCH] ARM: dts: microchip: rename spi-cs-setup-ns property to spi-cs-setup-delay-ns Manikandan Muralidharan
2025-05-15 15:07 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515-laptop-unfixable-85dca20d1b57@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikandan.m@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox