public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] arm64: defconfig: Ensure CRYPTO_CHACHA20_NEON is selected
@ 2025-05-15 15:15 Fabio Estevam
  2025-05-15 15:24 ` Arnd Bergmann
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2025-05-15 15:15 UTC (permalink / raw)
  To: arnd; +Cc: herbert, ebiggers, linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Since commit 17ec3e71ba79 ("crypto: lib/Kconfig - Hide arch options from
user"), the CRYPTO_CHACHA20_NEON option is no longer selected by default
due to changes in how crypto library options are exposed and selected.

To restore the previous behavior and ensure CRYPTO_CHACHA20_NEON is
enabled, explicitly select CONFIG_CRYPTO_CHACHA20 in the defconfig. This
pulls in CRYPTO_LIB_CHACHA_INTERNAL and allows CRYPTO_CHACHA20_NEON to be
selected automatically as before.

Fixes: 17ec3e71ba79 ("crypto: lib/Kconfig - Hide arch options from user")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 04619fe7e22a..7856db7dcfca 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1723,11 +1723,11 @@ CONFIG_NLS_ISO8859_1=y
 CONFIG_SECURITY=y
 CONFIG_CRYPTO_USER=y
 CONFIG_CRYPTO_BENCHMARK=m
+CONFIG_CRYPTO_CHACHA20=m
 CONFIG_CRYPTO_ECHAINIV=y
 CONFIG_CRYPTO_MICHAEL_MIC=m
 CONFIG_CRYPTO_ANSI_CPRNG=y
 CONFIG_CRYPTO_USER_API_RNG=m
-CONFIG_CRYPTO_CHACHA20_NEON=m
 CONFIG_CRYPTO_GHASH_ARM64_CE=y
 CONFIG_CRYPTO_SHA1_ARM64_CE=y
 CONFIG_CRYPTO_SHA512_ARM64_CE=m
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: defconfig: Ensure CRYPTO_CHACHA20_NEON is selected
  2025-05-15 15:15 [PATCH] arm64: defconfig: Ensure CRYPTO_CHACHA20_NEON is selected Fabio Estevam
@ 2025-05-15 15:24 ` Arnd Bergmann
  2025-05-16  9:26   ` Herbert Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2025-05-15 15:24 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Herbert Xu, Eric Biggers, linux-arm-kernel, Fabio Estevam

On Thu, May 15, 2025, at 17:15, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Since commit 17ec3e71ba79 ("crypto: lib/Kconfig - Hide arch options from
> user"), the CRYPTO_CHACHA20_NEON option is no longer selected by default
> due to changes in how crypto library options are exposed and selected.
>
> To restore the previous behavior and ensure CRYPTO_CHACHA20_NEON is
> enabled, explicitly select CONFIG_CRYPTO_CHACHA20 in the defconfig. This
> pulls in CRYPTO_LIB_CHACHA_INTERNAL and allows CRYPTO_CHACHA20_NEON to be
> selected automatically as before.
>
> Fixes: 17ec3e71ba79 ("crypto: lib/Kconfig - Hide arch options from user")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Arnd Bergmann <arnd@arndb.de> 

in case Herbert wants to pick this up as a fix for the crypto tree,
or I can apply this through arm-soc if you send a copy to soc@lists.linux.dev.

      Arnd


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: defconfig: Ensure CRYPTO_CHACHA20_NEON is selected
  2025-05-15 15:24 ` Arnd Bergmann
@ 2025-05-16  9:26   ` Herbert Xu
  0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2025-05-16  9:26 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Fabio Estevam, Eric Biggers, linux-arm-kernel, Fabio Estevam

On Thu, May 15, 2025 at 05:24:09PM +0200, Arnd Bergmann wrote:
>
> in case Herbert wants to pick this up as a fix for the crypto tree,
> or I can apply this through arm-soc if you send a copy to soc@lists.linux.dev.

Going through arm-soc should be fine.  I don't see any changes
in my tree that should create a non-trivial conflict with this.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-16  9:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-15 15:15 [PATCH] arm64: defconfig: Ensure CRYPTO_CHACHA20_NEON is selected Fabio Estevam
2025-05-15 15:24 ` Arnd Bergmann
2025-05-16  9:26   ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox