Re: [PATCH v3 0/2] Add support for Firefly Station-M3/ROC-RK3588S-PC

Heiko Stübner
2025-05-17T18:11:05Z

Am Samstag, 17. Mai 2025, 15:18:25 Mitteleuropäische Sommerzeit schrieb Rob Herring (Arm):
>
> On Fri, 16 May 2025 09:24:00 +0800, Hsun Lai wrote:
> > This series add support for Firefly Station-M3/ROC-RK3588S-PC.
> >
> > Info of device can be found at:
> > https://wiki.t-firefly.com/en/Station-M3/index.html
> >
> > Changes in v3:
> > - Update the name of leds
> > - Add more cpu nodes
> > - Update mdio compatible
> > - Fix the order in the node
> > - Add the default serial port(uart2)
> >
> > Changes in v2:
> > - Fix rgmii delays
> >
> > Changes in v1:
> > - Add support for Firefly ROC-RK3588S-PC
> >
> > Hsun Lai (2):
> > dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC
> > arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC
> >
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../boot/dts/rockchip/rk3588s-roc-pc.dts | 926 ++++++++++++++++++
> > 3 files changed, 932 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts
> >
> > --
> > 2.34.1
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: attempting to guess base-commit...
> Base: remotes/arm-soc/rockchip/dt64-31-ge463625af7f9 (exact match)
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250516012402.580468-1-i@chainsx.cn:
>
> arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dtb: /edp@fdec0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']

hmm, the binding for rockchip,rk3588-edp is in linux-next though [0]

[0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f855146263b14abadd8d5bd0e280e54fbab3bd18