[PATCH 0/3] rockchip: Add GPU support for RK3528

[PATCH 0/3] rockchip: Add GPU support for RK3528

[Jonas Karlman]

This series adds support for the Mali-450 MP2 GPU in the RK3528 SoC.

The clock used for the GPU can use normal PLL to support a rate of 100,
300 or 500 MHz. Or it can use PVTPLL to reach rates up to 800 MHz.

The TF-A SCMI_CLK_GPU is used to switch use between normal PLL and
PVTPLL. When a rate of up to 300 MHz is requested TF-A switch to use
normal PLL, and for rates above 300 MHz the PVTPLL is used.

The PVTPLL can only operate when the power domain, regulators and clocks
are enabled, an opp-suspend for 300 MHz is used to ensure normal PLL is
selected before GPU is PM runtime suspended.

Driver init at boot:

  lima ff700000.gpu: gp - mali450 version major 0 minor 0
  lima ff700000.gpu: pp0 - mali450 version major 0 minor 0
  lima ff700000.gpu: pp1 - mali450 version major 0 minor 0
  lima ff700000.gpu: l2_cache0 8K, 4-way, 64byte cache line, 128bit external bus
  lima ff700000.gpu: l2_cache1 64K, 4-way, 64byte cache line, 128bit external bus
  lima ff700000.gpu: bus rate = 297000000
  lima ff700000.gpu: mod rate = 300000000
  [drm] Initialized lima 1.1.0 for ff700000.gpu n minor 0

glmark2-es2-gbm (cebbb63edfba502905470c904f8e6f1c6ce28ba9):

  =======================================================
      glmark2 2023.01
  =======================================================
      GL_VENDOR:      Mesa
      GL_RENDERER:    Mali450
      GL_VERSION:     OpenGL ES 2.0 Mesa 25.0.4
      Surface Config: buf=32 r=8 g=8 b=8 a=8 depth=24 stencil=0 samples=0
      Surface Size:  800x600 fullscreen
  =======================================================
  [build] use-vbo=false: FPS: 572 FrameTime: 1.751 ms
  [build] use-vbo=true: FPS: 715 FrameTime: 1.400 ms
  [texture] texture-filter=nearest: FPS: 735 FrameTime: 1.361 ms
  [texture] texture-filter=linear: FPS: 744 FrameTime: 1.346 ms
  [texture] texture-filter=mipmap: FPS: 758 FrameTime: 1.320 ms
  [shading] shading=gouraud: FPS: 444 FrameTime: 2.255 ms
  [shading] shading=blinn-phong-inf: FPS: 442 FrameTime: 2.267 ms
  [shading] shading=phong: FPS: 314 FrameTime: 3.186 ms
  [shading] shading=cel: FPS: 258 FrameTime: 3.877 ms
  [bump] bump-render=high-poly: FPS: 98 FrameTime: 10.279 ms
  [bump] bump-render=normals: FPS: 694 FrameTime: 1.443 ms
  [bump] bump-render=height: FPS: 551 FrameTime: 1.818 ms
  [effect2d] kernel=0,1,0;1,-4,1;0,1,0;: FPS: 161 FrameTime: 6.246 ms
  [effect2d] kernel=1,1,1,1,1;1,1,1,1,1;1,1,1,1,1;: FPS: 47 FrameTime: 21.692 ms
  [pulsar] light=false:quads=5:texture=false: FPS: 1031 FrameTime: 0.970 ms
  [desktop] blur-radius=5:effect=blur:passes=1:separable=true:windows=4: FPS: 78 FrameTime: 12.986 ms
  [desktop] effect=shadow:windows=4: FPS: 331 FrameTime: 3.023 ms
  [buffer] columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=map: FPS: 161 FrameTime: 6.220 ms
  [buffer] columns=200:interleave=false:update-dispersion=0.9:update-fraction=0.5:update-method=subdata: FPS: 160 FrameTime: 6.285 ms
  [buffer] columns=200:interleave=true:update-dispersion=0.9:update-fraction=0.5:update-method=map: FPS: 237 FrameTime: 4.231 ms
  [ideas] speed=duration: FPS: 184 FrameTime: 5.461 ms
  [jellyfish] <default>: FPS: 200 FrameTime: 5.006 ms
  Error: SceneTerrain requires Vertex Texture Fetch support, but GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS is 0
  [terrain] <default>: Unsupported
  [shadow] <default>: FPS: 214 FrameTime: 4.691 ms
  [refract] <default>: FPS: 23 FrameTime: 43.776 ms
  [conditionals] fragment-steps=0:vertex-steps=0: FPS: 725 FrameTime: 1.380 ms
  [conditionals] fragment-steps=5:vertex-steps=0: FPS: 356 FrameTime: 2.816 ms
  [conditionals] fragment-steps=0:vertex-steps=5: FPS: 728 FrameTime: 1.375 ms
  [function] fragment-complexity=low:fragment-steps=5: FPS: 482 FrameTime: 2.077 ms
  [function] fragment-complexity=medium:fragment-steps=5: FPS: 233 FrameTime: 4.298 ms
  [loop] fragment-loop=false:fragment-steps=5:vertex-steps=5: FPS: 482 FrameTime: 2.079 ms
  [loop] fragment-steps=5:fragment-uniform=false:vertex-steps=5: FPS: 482 FrameTime: 2.076 ms
  [loop] fragment-steps=5:fragment-uniform=true:vertex-steps=5: FPS: 165 FrameTime: 6.076 ms
  =======================================================
                                    glmark2 Score: 399
  ======================================================

Trying to use a GPU clock rate above 300 MHz when the GPU is PM runtime
suspended may cause the system to freeze or an SError. E.g. trying to
use a different devfreq governor or set min_freq above 300 MHz.

Similar issues also exist on RK3576 and RK3588 when SCMI_CLK_GPU is used
for devfreq, a separate series will be sent to mitigate these issues.

This series depends on patch 1-4 of the series "rockchip: Add power
controller support for RK3528" [1].

[1] https://lore.kernel.org/r/20250518220707.669515-1-jonas@kwiboo.se

Jonas Karlman (3):
  dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible
  arm64: dts: rockchip: Add GPU node for RK3528
  arm64: dts: rockchip: Enable GPU on Radxa E20C

 .../bindings/gpu/arm,mali-utgard.yaml         |  2 +
 .../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  5 ++
 arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 58 +++++++++++++++++++
 3 files changed, 65 insertions(+)

-- 
2.49.0

[PATCH 1/3] dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible

[Jonas Karlman]

Rockchip RK3528 SoC has a Mali-450 MP2. Add a compatible for it.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
index 9318817ea135..c8d0d9192d92 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
@@ -47,6 +47,7 @@ properties:
               - hisilicon,hi6220-mali
               - mediatek,mt7623-mali
               - rockchip,rk3328-mali
+              - rockchip,rk3528-mali
           - const: arm,mali-450
 
       # "arm,mali-300"
@@ -148,6 +149,7 @@ allOf:
               - rockchip,rk3188-mali
               - rockchip,rk3228-mali
               - rockchip,rk3328-mali
+              - rockchip,rk3528-mali
     then:
       required:
         - resets
-- 
2.49.0

[PATCH 2/3] arm64: dts: rockchip: Add GPU node for RK3528

[Jonas Karlman]

Add a GPU node and a opp-table for the Mali-450 MP2 in the RK3528 SoC.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 arch/arm64/boot/dts/rockchip/rk3528.dtsi | 58 ++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
index 791cb9b1e8f1..548ac6d4793f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
@@ -96,6 +96,36 @@ scmi_clk: protocol@14 {
 		};
 	};
 
+	gpu_opp_table: opp-table-gpu {
+		compatible = "operating-points-v2";
+
+		opp-300000000 {
+			opp-hz = /bits/ 64 <300000000>;
+			opp-microvolt = <875000 875000 1000000>;
+			opp-suspend;
+		};
+
+		opp-500000000 {
+			opp-hz = /bits/ 64 <500000000>;
+			opp-microvolt = <875000 875000 1000000>;
+		};
+
+		opp-600000000 {
+			opp-hz = /bits/ 64 <600000000>;
+			opp-microvolt = <875000 875000 1000000>;
+		};
+
+		opp-700000000 {
+			opp-hz = /bits/ 64 <700000000>;
+			opp-microvolt = <900000 900000 1000000>;
+		};
+
+		opp-800000000 {
+			opp-hz = /bits/ 64 <800000000>;
+			opp-microvolt = <950000 950000 1000000>;
+		};
+	};
+
 	psci {
 		compatible = "arm,psci-1.0", "arm,psci-0.2";
 		method = "smc";
@@ -433,6 +463,34 @@ power-domain@RK3528_PD_VPU {
 			};
 		};
 
+		gpu: gpu@ff700000 {
+			compatible = "rockchip,rk3528-mali", "arm,mali-450";
+			reg = <0x0 0xff700000 0x0 0x40000>;
+			assigned-clocks = <&cru ACLK_GPU_MALI>,
+					  <&scmi_clk SCMI_CLK_GPU>;
+			assigned-clock-rates = <297000000>, <300000000>;
+			clocks = <&cru ACLK_GPU_MALI>, <&scmi_clk SCMI_CLK_GPU>;
+			clock-names = "bus", "core";
+			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "gp",
+					  "gpmmu",
+					  "pp",
+					  "pp0",
+					  "ppmmu0",
+					  "pp1",
+					  "ppmmu1";
+			operating-points-v2 = <&gpu_opp_table>;
+			power-domains = <&power RK3528_PD_GPU>;
+			resets = <&cru SRST_A_GPU>;
+			status = "disabled";
+		};
+
 		uart0: serial@ff9f0000 {
 			compatible = "rockchip,rk3528-uart", "snps,dw-apb-uart";
 			reg = <0x0 0xff9f0000 0x0 0x100>;
-- 
2.49.0

[PATCH 3/3] arm64: dts: rockchip: Enable GPU on Radxa E20C

[Jonas Karlman]

Enable the Mali-450 MP2 GPU on the Radxa E20C.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
index 9f6ccd9dd1f7..e4333674a0ec 100644
--- a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
@@ -198,6 +198,11 @@ &gmac1 {
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_logic>;
+	status = "okay";
+};
+
 &i2c1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1m0_xfer>;
-- 
2.49.0

Re: [PATCH 1/3] dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

On Sun, May 18, 2025 at 10:54:11PM +0000, Jonas Karlman wrote:
> Rockchip RK3528 SoC has a Mali-450 MP2. Add a compatible for it.
> 
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: (subset) [PATCH 0/3] rockchip: Add GPU support for RK3528

[Heiko Stuebner]

On Sun, 18 May 2025 22:54:10 +0000, Jonas Karlman wrote:
> This series adds support for the Mali-450 MP2 GPU in the RK3528 SoC.
> 
> The clock used for the GPU can use normal PLL to support a rate of 100,
> 300 or 500 MHz. Or it can use PVTPLL to reach rates up to 800 MHz.
> 
> The TF-A SCMI_CLK_GPU is used to switch use between normal PLL and
> PVTPLL. When a rate of up to 300 MHz is requested TF-A switch to use
> normal PLL, and for rates above 300 MHz the PVTPLL is used.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible
      commit: 6f446bbe412ab3d75651d1cc52e31aaf801dbea8

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: (subset) [PATCH 0/3] rockchip: Add GPU support for RK3528

[Heiko Stuebner]

On Sun, 18 May 2025 22:54:10 +0000, Jonas Karlman wrote:
> This series adds support for the Mali-450 MP2 GPU in the RK3528 SoC.
> 
> The clock used for the GPU can use normal PLL to support a rate of 100,
> 300 or 500 MHz. Or it can use PVTPLL to reach rates up to 800 MHz.
> 
> The TF-A SCMI_CLK_GPU is used to switch use between normal PLL and
> PVTPLL. When a rate of up to 300 MHz is requested TF-A switch to use
> normal PLL, and for rates above 300 MHz the PVTPLL is used.
> 
> [...]

Applied, thanks!

[2/3] arm64: dts: rockchip: Add GPU node for RK3528
      commit: 6b88b8a640fa5d2169e0ce47b88dc30727fc1105
[3/3] arm64: dts: rockchip: Enable GPU on Radxa E20C
      commit: 669080eb7f7c4720aa4e640a49f7490cd928cfcc

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 0/3] rockchip: Add GPU support for RK3528

[Chukun Pan]

Hi,

> Applied, thanks!
>
> [2/3] arm64: dts: rockchip: Add GPU node for RK3528
>       commit: 6b88b8a640fa5d2169e0ce47b88dc30727fc1105
> [3/3] arm64: dts: rockchip: Enable GPU on Radxa E20C
>       commit: 669080eb7f7c4720aa4e640a49f7490cd928cfcc

https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=6b88b8a640fa5d2169e0ce47b88dc30727fc1105

Should the gpu_opp_table node be above the pinctrl node?

Thanks,
Chukun

--
2.25.1

Re: [PATCH 0/3] rockchip: Add GPU support for RK3528

[Heiko Stuebner]

Am Samstag, 21. Juni 2025, 11:00:26 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> Hi,
> 
> > Applied, thanks!
> >
> > [2/3] arm64: dts: rockchip: Add GPU node for RK3528
> >       commit: 6b88b8a640fa5d2169e0ce47b88dc30727fc1105
> > [3/3] arm64: dts: rockchip: Enable GPU on Radxa E20C
> >       commit: 669080eb7f7c4720aa4e640a49f7490cd928cfcc
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=6b88b8a640fa5d2169e0ce47b88dc30727fc1105
> 
> Should the gpu_opp_table node be above the pinctrl node?

yes it should. "o" before "p" :-) .

As tht commit was just from yesterday, I've amended it to move the
table to its correct position now.

Thanks for catching that.
Heiko