[PATCH v2] arm64: dts: amlogic: Update USB hub power and reset properties

[PATCH v2] arm64: dts: amlogic: Update USB hub power and reset properties

[Anand Moon]

Add missing reset-gpios property to the USB 2.0 hub node to
ensure proper reset handling. Also update the vdd-supply for
both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
for consistent power management. Remove usb2_phy1 phy-supply
since now it's managed by the hub reset control.

Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v2: remove usb2_phy1 phy-supply since now it's managed by
the hub reset control.
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 3bca8023638d..d46b6aaef8fa 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
 			compatible = "usb5e3,610";
 			reg = <1>;
 			peer-hub = <&hub_3_0>;
-			vdd-supply = <&usb_pwr_en>;
+			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+			vdd-supply = <&hub_5v>;
 		};
 
 		/* 3.0 hub on port 4 */
@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
 			reg = <2>;
 			peer-hub = <&hub_2_0>;
 			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-			vdd-supply = <&vcc_5v>;
+			vdd-supply = <&hub_5v>;
 		};
 	};
 
@@ -311,8 +312,3 @@ &toacodec {
 &usb {
 	vbus-supply = <&usb_pwr_en>;
 };
-
-&usb2_phy1 {
-	/* Enable the hub which is connected to this port */
-	phy-supply = <&hub_5v>;
-};

base-commit: 4a95bc121ccdaee04c4d72f84dbfa6b880a514b6
-- 
2.49.0

Re: [PATCH v2] arm64: dts: amlogic: Update USB hub power and reset properties

[Anand Moon]

Hi Neil,

On Wed, 21 May 2025 at 13:15, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Add missing reset-gpios property to the USB 2.0 hub node to
> ensure proper reset handling. Also update the vdd-supply for
> both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> for consistent power management. Remove usb2_phy1 phy-supply
> since now it's managed by the hub reset control.
>
> Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v2: remove usb2_phy1 phy-supply since now it's managed by
> the hub reset control.
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 3bca8023638d..d46b6aaef8fa 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -42,7 +42,8 @@ hub_2_0: hub@1 {
>                         compatible = "usb5e3,610";
>                         reg = <1>;
>                         peer-hub = <&hub_3_0>;
> -                       vdd-supply = <&usb_pwr_en>;
> +                       reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> +                       vdd-supply = <&hub_5v>;
>                 };
>
>                 /* 3.0 hub on port 4 */
> @@ -51,7 +52,7 @@ hub_3_0: hub@2 {
>                         reg = <2>;
>                         peer-hub = <&hub_2_0>;
>                         reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> -                       vdd-supply = <&vcc_5v>;
> +                       vdd-supply = <&hub_5v>;
>                 };
>         };
>
> @@ -311,8 +312,3 @@ &toacodec {
>  &usb {
>         vbus-supply = <&usb_pwr_en>;
>  };
> -
> -&usb2_phy1 {
> -       /* Enable the hub which is connected to this port */
> -       phy-supply = <&hub_5v>;
> -};

This is breaking the bring-up of dwc2 in u-boot
so could you consider V1 of the patch?

Thanks
-Anand
>
> base-commit: 4a95bc121ccdaee04c4d72f84dbfa6b880a514b6
> --
> 2.49.0
>