Re: [PATCH 2/5] dt-bindings: media: allegro-dvt: add decoder dt-bindings for Gen3 IP

Nicolas Dufresne
2025-05-27T13:38:05Z

Hi Yassine,

Le lundi 26 mai 2025 à 12:58 +0000, Yassine Ouaissa a écrit :
> On 26.05.2025 14:46, Krzysztof Kozlowski wrote:
> > On 26/05/2025 14:27, Yassine Ouaissa wrote:
> > > On 26.05.2025 12:57, Krzysztof Kozlowski wrote:
> > > > On 26/05/2025 09:25, Yassine Ouaissa wrote:
> > > > > On 23.05.2025 19:13, Krzysztof Kozlowski wrote:
> > > > > > On 23/05/2025 19:11, Krzysztof Kozlowski wrote:
> > > > > > > On 23/05/2025 15:41, Yassine Ouaissa wrote:
> > > > > > > > Add compatible for video decoder on allegrodvt Gen 3 IP.
> > > > > > > >
> > > > > > > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> > > > > > > Please do not send the same patches over and over again. You got review
> > > > > > > which you need to address.
> > > > > > >
> > > > > > > Once address you send NEXT version with proper CHANGELOG for each patch
> > > > > > > or top of cover letter. See submitting patches... or just use b4. This
> > > > > > > should be actually requirement for this work.
> > > > > > >
> > > > > > > Anyway, I see all of previous review ignored so let's be explicit:
> > > > > > >
> > > > > > > NAK
> > > > > > >
> > > > > Hi Krzysztof,
> > > > >
> > > > > Make sure that i'm not ignoring anyone reviews, i sent a new set of
> > > > > patches to start cleanly, and i have sent you an email about this.
> > > >
> > > > It is still v1 - the same? - while you already sent three patchsets before.
> > >
> > > As i mentioned, this patch is sent to start cleanly, so it still v1.
> > > And the previous patchsets should be ignored.
> > This is not how the process works and it is not making reviewers life
> > easier. It makes it impossible for us to compare (try yourself with `b4
> > diff`) and forces to re-review everything every time.
>
> I know that i made a mistake by not respecting the "submitting patches".
> this is why, i prefer to start from a good base ( clean patches ).
>  From this patchsets, You & I can use the b4 or other tools to get the diffs.

For future submissions, once there is a base, don't try and "fix" things, just do
add V2, V3 on future submissions, even if its completely rewritten. Just say so in
your cover letter change log. If everyone was to reset to V1 all the time our work
as reviewer and maintainers would be completely un-manageable. Please understand
and take our explanations for the future. There is no need for you to argue on this,
this is not just personal preference. Same driver, second submission mean v2. That is
even true if you take over someone else series.

regards,
Nicolas

>
> >
> > Best regards,
> > Krzysztof
>
> Best regards,
> Yassine OUAISSA