Re: [PATCH 3/5] MAINTAINERS: Add entry for allegrodvt Gen 3 drivers

Nicolas Dufresne
2025-05-25T21:52:42Z

Hi Yassine,

Le vendredi 23 mai 2025 à 15:41 +0200, Yassine Ouaissa a écrit :
> Add my self as maintainer of the allegrodvt Gen drivers
>
> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e59011a36e6b..9285bb2f43d9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -802,6 +802,7 @@ F: drivers/platform/x86/dell/alienware-wmi*
>
>  ALLEGRO DVT VIDEO IP CORE DRIVER
>  M: Michael Tretter <m.tretter@pengutronix.de>
> +M: Yassine OUAISSA <yassine.ouaissa@allegrodvt.com>
>  R: Pengutronix Kernel Team <kernel@pengutronix.de>
>  L: linux-media@vger.kernel.org
>  S: Maintained

Be aware that I do not endorse Krzysztof style of communication, and this
does not reflect Linux Media values. We strongly encourage both new comers and
contributions coming from the hardware companies. Please, don't get discourage,
simply focus on the facts and the way forward. DT maintainers don't usually deal
with pre-silicon drivers, so we'll have to see what this means for
bindings. But having drivers contributed before the hardware is a clear win
for the Linux kernel, so we should all encourage this and find a way.

In general, don't assume any of the above is known and document it. Its quite possible
your reviewers so far have been thinking this driver is for existing hardware already
running in a known SoC. They cannot guess, you have to make things really clear and
transparent.

Meanwhile, a better approach to maintenance, and the one I expected initially, is to
place yourself under Michael in the hierarchy, and remove yourself from the bindings
path. Bindings should really come from the SoC vendor in practice, so perhaps we should
not provide a generic one. Hopefully we can get proper feedback from DT maintainers on
that aspect.

I'd like to see a focus move onto the driver code, which is at this stage much more
important. In parallel, spend time to re-read the guidelines for submissions and
check some automation tools. 'b4' is really my goto, and will help you avoid some
of the common mistakes.

regards,
Nicolas