Re: [PATCH 5/5] media: allegro-dvt: Add Gen 3 IP stateful decoder driver

kernel test robot
2025-05-24T00:36:53Z

Hi Yassine,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linuxtv-media-pending/master linus/master v6.15-rc7 next-20250523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Yassine-Ouaissa/media-allegro-dvt-Move-the-current-driver-to-a-subdirectory/20250523-214946
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250523134207.68481-6-yassine.ouaissa%40allegrodvt.com
patch subject: [PATCH 5/5] media: allegro-dvt: Add Gen 3 IP stateful decoder driver
config: i386-randconfig-014-20250524 (https://download.01.org/0day-ci/archive/20250524/202505240808.VaN58jYa-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250524/202505240808.VaN58jYa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505240808.VaN58jYa-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/media/platform/allegro-dvt/al300/al_codec_common.c:251:9: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
250 | al_codec_err(dev, "mem check failed for 0x%16llx of size %zu",
| ~~~~~~
| %16x
251 | *paddr, size);
| ^~~~~~
drivers/media/platform/allegro-dvt/al300/al_codec_util.h:82:25: note: expanded from macro 'al_codec_err'
81 | dev_err(&(al_dev)->pdev->dev, "[ALG_CODEC][ERROR] %s():%d: " fmt "\n", \
| ~~~
82 | __func__, __LINE__, ##args)
| ^~~~
include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err'
154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
drivers/media/platform/allegro-dvt/al300/al_codec_common.c:249:22: warning: result of comparison of constant 549755813887 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
249 | if ((*paddr + size) > AL_CODEC_MAX_ADDR) {
| ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
drivers/media/platform/allegro-dvt/al300/al_codec_common.c:508:50: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
508 | al_codec_dbg(dev, "periph address = 0x%016llx", dev->apb);
| ~~~~~~~ ^~~~~~~~
| %016x
drivers/media/platform/allegro-dvt/al300/al_codec_util.h:120:60: note: expanded from macro 'al_codec_dbg'
120 | dev_dbg(&(al_dev)->pdev->dev, "[ALG_CODEC]: " fmt "\n", ##args)
| ~~~ ^~~~
include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
274 | dev, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
248 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
>> drivers/media/platform/allegro-dvt/al300/al_codec_common.c:712:8: warning: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
711 | al_codec_dbg(dev, "Send req to mcu %d : %ld ", req->req_type,
| ~~~
| %zu
712 | req->req_size);
| ^~~~~~~~~~~~~
drivers/media/platform/allegro-dvt/al300/al_codec_util.h:120:60: note: expanded from macro 'al_codec_dbg'
120 | dev_dbg(&(al_dev)->pdev->dev, "[ALG_CODEC]: " fmt "\n", ##args)
| ~~~ ^~~~
include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
274 | dev, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
248 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
4 warnings generated.

vim +712 drivers/media/platform/allegro-dvt/al300/al_codec_common.c

680
681 int al_common_send_req_reply(struct al_codec_dev *dev,
682 struct list_head *cmd_list,
683 struct msg_itf_header *hdr,
684 struct al_common_mcu_req *req)
685 {
686 struct al_codec_cmd *cmd = NULL;
687 int ret;
688
689 hdr->drv_cmd_hdl = 0;
690
691 if (req->reply_size && req->reply) {
692 cmd = al_codec_cmd_create(req->reply_size);
693 if (!cmd)
694 return -ENOMEM;
695
696 hdr->drv_cmd_hdl = al_virt_to_phys(cmd);
697 }
698
699 hdr->drv_ctx_hdl = req->pCtx;
700 hdr->type = req->req_type;
701 hdr->payload_len = req->req_size;
702
703 /* Add the list to the cmd list */
704 if (cmd)
705 list_add(&cmd->list, cmd_list);
706
707 ret = al_common_send(dev, hdr);
708 if (ret)
709 goto remove_cmd;
710
711 al_codec_dbg(dev, "Send req to mcu %d : %ld ", req->req_type,
> 712 req->req_size);
713
714 if (!cmd)
715 return 0;
716
717 ret = wait_for_completion_timeout(&cmd->done, 5 * HZ);
718 if (ret <= 0) {
719 al_codec_err(dev, "cmd %p has %d (%s)", cmd, ret,
720 (ret == 0) ? "failed" : "timedout");
721 ret = -ETIMEDOUT;
722 goto remove_cmd;
723 }
724
725 ret = 0;
726 memcpy(req->reply, cmd->reply, req->reply_size);
727
728 remove_cmd:
729
730 if (cmd) {
731 list_del(&cmd->list);
732 al_codec_cmd_put(cmd);
733 }
734 return ret;
735 }
736

--
0-DAY CI Kernel Test Service