Re: [PATCH 1/1] dt-bindings: soc: Add fsl,imx23-digctl.yaml for i.MX23 and i.MX28

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

On Fri, May 23, 2025 at 04:45:23PM -0400, Frank Li wrote:
> Add fsl,imx23-digctl.yaml for i.MX23 and i.MX28 to fix below CHECK_DTB
> warning:
> 
> arch/arm/boot/dts/nxp/mxs/imx23-sansa.dtb: /apb@80000000/apbh-bus@80000000/digctl@8001c000:
>     failed to match any schema with compatible: ['fsl,imx23-digctl']
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../bindings/soc/fsl/fsl,imx23-digctl.yaml    | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml b/Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml
> new file mode 100644
> index 0000000000000..47f92f763bfa3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas//soc/fsl/fsl,imx23-digctl.yaml#
                                     ^^ I assume it makes no difference,
but you got a double / here.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale mxs digctrl for i.MX23/i.MX28

I have no idea reading this what a "digctrl" is. I think you should add
a description briefly mentioning what it does.

> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - fsl,imx28-digctl
> +          - const: fsl,imx23-digctl
> +      - const: fsl,imx23-digctl
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    digctl@8001c000 {
> +        compatible = "fsl,imx28-digctl", "fsl,imx23-digctl";
> +        reg = <0x8001c000 0x2000>;
> +        interrupts = <89>;
> +    };
> +
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]