linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes
@ 2025-06-03 15:43 André Draszik
  2025-06-03 15:43 ` [PATCH 1/3] clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD André Draszik
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: André Draszik @ 2025-06-03 15:43 UTC (permalink / raw)
  To: Peter Griffin, Tudor Ambarus, Krzysztof Kozlowski,
	Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
	Stephen Boyd, Sam Protsenko
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-clk, linux-kernel, André Draszik, stable

Hi,

The patches fix some errors in the gs101 clock driver as well as a
trivial comment typo in the Exynos E850 clock driver.

Cheers,
Andre

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
André Draszik (3):
      clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD
      clk: samsung: gs101: fix alternate mout_hsi0_usb20_ref parent clock
      clk: samsung: exynos850: fix a comment

 drivers/clk/samsung/clk-exynos850.c | 2 +-
 drivers/clk/samsung/clk-gs101.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
---
base-commit: a0bea9e39035edc56a994630e6048c8a191a99d8
change-id: 20250519-samsung-clk-fixes-a4f5bfb54c73

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD
  2025-06-03 15:43 [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes André Draszik
@ 2025-06-03 15:43 ` André Draszik
  2025-06-03 15:43 ` [PATCH 2/3] clk: samsung: gs101: fix alternate mout_hsi0_usb20_ref parent clock André Draszik
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: André Draszik @ 2025-06-03 15:43 UTC (permalink / raw)
  To: Peter Griffin, Tudor Ambarus, Krzysztof Kozlowski,
	Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
	Stephen Boyd, Sam Protsenko
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-clk, linux-kernel, André Draszik, stable

Use the correct Linux clock ID when instantiating the G3D_BUSD
div_clock.

Fixes: 2c597bb7d66a ("clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support")
Cc: stable@vger.kernel.org
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/clk/samsung/clk-gs101.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
index f9c3d68d449c356019aee569fbe289259624da70..12ee416375ef31deed5f45ea6aaec05fde260dc5 100644
--- a/drivers/clk/samsung/clk-gs101.c
+++ b/drivers/clk/samsung/clk-gs101.c
@@ -1154,7 +1154,7 @@ static const struct samsung_div_clock cmu_top_div_clks[] __initconst = {
 	    CLK_CON_DIV_CLKCMU_G2D_MSCL, 0, 4),
 	DIV(CLK_DOUT_CMU_G3AA_G3AA, "dout_cmu_g3aa_g3aa", "gout_cmu_g3aa_g3aa",
 	    CLK_CON_DIV_CLKCMU_G3AA_G3AA, 0, 4),
-	DIV(CLK_DOUT_CMU_G3D_SWITCH, "dout_cmu_g3d_busd", "gout_cmu_g3d_busd",
+	DIV(CLK_DOUT_CMU_G3D_BUSD, "dout_cmu_g3d_busd", "gout_cmu_g3d_busd",
 	    CLK_CON_DIV_CLKCMU_G3D_BUSD, 0, 4),
 	DIV(CLK_DOUT_CMU_G3D_GLB, "dout_cmu_g3d_glb", "gout_cmu_g3d_glb",
 	    CLK_CON_DIV_CLKCMU_G3D_GLB, 0, 4),

-- 
2.49.0.1204.g71687c7c1d-goog



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] clk: samsung: gs101: fix alternate mout_hsi0_usb20_ref parent clock
  2025-06-03 15:43 [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes André Draszik
  2025-06-03 15:43 ` [PATCH 1/3] clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD André Draszik
@ 2025-06-03 15:43 ` André Draszik
  2025-06-03 15:43 ` [PATCH 3/3] clk: samsung: exynos850: fix a comment André Draszik
  2025-06-10  8:23 ` [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: André Draszik @ 2025-06-03 15:43 UTC (permalink / raw)
  To: Peter Griffin, Tudor Ambarus, Krzysztof Kozlowski,
	Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
	Stephen Boyd, Sam Protsenko
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-clk, linux-kernel, André Draszik, stable

The alternate parent clock for this mux is mout_pll_usb, not the pll
itself.

Fixes: 1891e4d48755 ("clk: samsung: gs101: add support for cmu_hsi0")
Cc: stable@vger.kernel.org
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/clk/samsung/clk-gs101.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
index 12ee416375ef31deed5f45ea6aaec05fde260dc5..70b26db9b95ad0b376d23f637c7683fbc8c8c600 100644
--- a/drivers/clk/samsung/clk-gs101.c
+++ b/drivers/clk/samsung/clk-gs101.c
@@ -2129,7 +2129,7 @@ PNAME(mout_hsi0_usbdpdbg_user_p)	= { "oscclk",
 					    "dout_cmu_hsi0_usbdpdbg" };
 PNAME(mout_hsi0_bus_p)			= { "mout_hsi0_bus_user",
 					    "mout_hsi0_alt_user" };
-PNAME(mout_hsi0_usb20_ref_p)		= { "fout_usb_pll",
+PNAME(mout_hsi0_usb20_ref_p)		= { "mout_pll_usb",
 					    "mout_hsi0_tcxo_user" };
 PNAME(mout_hsi0_usb31drd_p)		= { "fout_usb_pll",
 					    "mout_hsi0_usb31drd_user",

-- 
2.49.0.1204.g71687c7c1d-goog



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] clk: samsung: exynos850: fix a comment
  2025-06-03 15:43 [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes André Draszik
  2025-06-03 15:43 ` [PATCH 1/3] clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD André Draszik
  2025-06-03 15:43 ` [PATCH 2/3] clk: samsung: gs101: fix alternate mout_hsi0_usb20_ref parent clock André Draszik
@ 2025-06-03 15:43 ` André Draszik
  2025-06-10  8:23 ` [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: André Draszik @ 2025-06-03 15:43 UTC (permalink / raw)
  To: Peter Griffin, Tudor Ambarus, Krzysztof Kozlowski,
	Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
	Stephen Boyd, Sam Protsenko
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-clk, linux-kernel, André Draszik, stable

The code below the updated comment is for CMU_CPUCL1, not CMU_CPUCL0.

Fixes: dedf87341ad6 ("clk: samsung: exynos850: Add CMU_CPUCL0 and CMU_CPUCL1")
Cc: stable@vger.kernel.org
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/clk/samsung/clk-exynos850.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/samsung/clk-exynos850.c b/drivers/clk/samsung/clk-exynos850.c
index cf7e08cca78e04e496703b565881bf64dcf979c8..56f27697c76b13276831b151db28074387293077 100644
--- a/drivers/clk/samsung/clk-exynos850.c
+++ b/drivers/clk/samsung/clk-exynos850.c
@@ -1360,7 +1360,7 @@ static const unsigned long cpucl1_clk_regs[] __initconst = {
 	CLK_CON_GAT_GATE_CLK_CPUCL1_CPU,
 };
 
-/* List of parent clocks for Muxes in CMU_CPUCL0 */
+/* List of parent clocks for Muxes in CMU_CPUCL1 */
 PNAME(mout_pll_cpucl1_p)		 = { "oscclk", "fout_cpucl1_pll" };
 PNAME(mout_cpucl1_switch_user_p)	 = { "oscclk", "dout_cpucl1_switch" };
 PNAME(mout_cpucl1_dbg_user_p)		 = { "oscclk", "dout_cpucl1_dbg" };

-- 
2.49.0.1204.g71687c7c1d-goog



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes
  2025-06-03 15:43 [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes André Draszik
                   ` (2 preceding siblings ...)
  2025-06-03 15:43 ` [PATCH 3/3] clk: samsung: exynos850: fix a comment André Draszik
@ 2025-06-10  8:23 ` Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-10  8:23 UTC (permalink / raw)
  To: Peter Griffin, Tudor Ambarus, Krzysztof Kozlowski,
	Sylwester Nawrocki, Chanwoo Choi, Alim Akhtar, Michael Turquette,
	Stephen Boyd, Sam Protsenko, André Draszik
  Cc: linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel,
	stable


On Tue, 03 Jun 2025 16:43:18 +0100, André Draszik wrote:
> The patches fix some errors in the gs101 clock driver as well as a
> trivial comment typo in the Exynos E850 clock driver.
> 
> Cheers,
> Andre
> 
> 
> [...]

Applied, thanks!

[1/3] clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD
      https://git.kernel.org/krzk/linux/c/29a9361f0b50be2b16d308695e30ee030fedea2c
[2/3] clk: samsung: gs101: fix alternate mout_hsi0_usb20_ref parent clock
      https://git.kernel.org/krzk/linux/c/ca243e653f71d8c4724a68c9033923f945b1084d
[3/3] clk: samsung: exynos850: fix a comment
      https://git.kernel.org/krzk/linux/c/320e7efce30e2613c2c7877acc46a8e71192cdcd

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-06-10  8:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-03 15:43 [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes André Draszik
2025-06-03 15:43 ` [PATCH 1/3] clk: samsung: gs101: fix CLK_DOUT_CMU_G3D_BUSD André Draszik
2025-06-03 15:43 ` [PATCH 2/3] clk: samsung: gs101: fix alternate mout_hsi0_usb20_ref parent clock André Draszik
2025-06-03 15:43 ` [PATCH 3/3] clk: samsung: exynos850: fix a comment André Draszik
2025-06-10  8:23 ` [PATCH 0/3] clk: samsung: gs101 & exynos850 fixes Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).