Re: [1/5] clk: mt8189: Porting driver for clk

Re: [1/5] clk: mt8189: Porting driver for clk

[Krzysztof Kozlowski]

On 02/06/2025 10:36, irving.ch.lin wrote:
> From: Irving lin <irving-ch.lin@mediatek.corp-partner.google.com>
> 
> 1. Add mt8189 clk driver
> 2. Fix mux failed
> 3. Add apll12_div_tdmout_b
> 4. Add disable-unused configs


Please do not send the same patch multiple times. This makes reviewing
difficult and causes people to miss discussion. You received feedback
already.

Best regards,
Krzysztof

Re: [1/5] clk: mt8189: Porting driver for clk

[kernel test robot]

Hi irving.ch.lin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linus/master v6.15 next-20250530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/irving-ch-lin/clk-mt8189-Porting-driver-for-clk/20250603-105623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link:    https://lore.kernel.org/r/20250602083624.1849719-1-irving-ch.lin%40mediatek.com
patch subject: [1/5] clk: mt8189: Porting driver for clk
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250603/202506032107.zewlKCY5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250603/202506032107.zewlKCY5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506032107.zewlKCY5-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/clk/mediatek/clk-bringup.c: In function '__bring_up_enable':
   drivers/clk/mediatek/clk-bringup.c:18:50: error: invalid use of undefined type 'struct platform_device'
      18 |         clk_con = of_count_phandle_with_args(pdev->dev.of_node, "clocks",
         |                                                  ^~
   drivers/clk/mediatek/clk-bringup.c:22:38: error: invalid use of undefined type 'struct platform_device'
      22 |                 clk = of_clk_get(pdev->dev.of_node, i);
         |                                      ^~
   drivers/clk/mediatek/clk-bringup.c: In function 'clk_post_ao_probe':
   drivers/clk/mediatek/clk-bringup.c:48:40: error: invalid use of undefined type 'struct platform_device'
      48 |         struct device_node *node = pdev->dev.of_node;
         |                                        ^~
   drivers/clk/mediatek/clk-bringup.c: In function 'bring_up_probe':
   drivers/clk/mediatek/clk-bringup.c:78:51: error: invalid use of undefined type 'struct platform_device'
      78 |         clk_probe = of_device_get_match_data(&pdev->dev);
         |                                                   ^~
   drivers/clk/mediatek/clk-bringup.c:84:17: error: implicit declaration of function 'dev_err' [-Werror=implicit-function-declaration]
      84 |                 dev_err(&pdev->dev,
         |                 ^~~~~~~
   drivers/clk/mediatek/clk-bringup.c:84:30: error: invalid use of undefined type 'struct platform_device'
      84 |                 dev_err(&pdev->dev,
         |                              ^~
   drivers/clk/mediatek/clk-bringup.c:86:29: error: invalid use of undefined type 'struct platform_device'
      86 |                         pdev->name, r);
         |                             ^~
   drivers/clk/mediatek/clk-bringup.c: At top level:
   drivers/clk/mediatek/clk-bringup.c:96:15: error: variable 'bring_up' has initializer but incomplete type
      96 | static struct platform_driver bring_up = {
         |               ^~~~~~~~~~~~~~~
   drivers/clk/mediatek/clk-bringup.c:97:10: error: 'struct platform_driver' has no member named 'probe'
      97 |         .probe          = bring_up_probe,
         |          ^~~~~
   drivers/clk/mediatek/clk-bringup.c:97:27: warning: excess elements in struct initializer
      97 |         .probe          = bring_up_probe,
         |                           ^~~~~~~~~~~~~~
   drivers/clk/mediatek/clk-bringup.c:97:27: note: (near initialization for 'bring_up')
   drivers/clk/mediatek/clk-bringup.c:98:10: error: 'struct platform_driver' has no member named 'remove'
      98 |         .remove         = bring_up_remove,
         |          ^~~~~~
   drivers/clk/mediatek/clk-bringup.c:98:27: warning: excess elements in struct initializer
      98 |         .remove         = bring_up_remove,
         |                           ^~~~~~~~~~~~~~~
   drivers/clk/mediatek/clk-bringup.c:98:27: note: (near initialization for 'bring_up')
   drivers/clk/mediatek/clk-bringup.c:99:10: error: 'struct platform_driver' has no member named 'driver'
      99 |         .driver         = {
         |          ^~~~~~
   drivers/clk/mediatek/clk-bringup.c:99:27: error: extra brace group at end of initializer
      99 |         .driver         = {
         |                           ^
   drivers/clk/mediatek/clk-bringup.c:99:27: note: (near initialization for 'bring_up')
   drivers/clk/mediatek/clk-bringup.c:99:27: warning: excess elements in struct initializer
   drivers/clk/mediatek/clk-bringup.c:99:27: note: (near initialization for 'bring_up')
   drivers/clk/mediatek/clk-bringup.c:106:1: warning: data definition has no type or storage class
     106 | module_platform_driver(bring_up);
         | ^~~~~~~~~~~~~~~~~~~~~~
   drivers/clk/mediatek/clk-bringup.c:106:1: error: type defaults to 'int' in declaration of 'module_platform_driver' [-Werror=implicit-int]
>> drivers/clk/mediatek/clk-bringup.c:106:1: warning: parameter names (without types) in function declaration
   drivers/clk/mediatek/clk-bringup.c:96:31: error: storage size of 'bring_up' isn't known
      96 | static struct platform_driver bring_up = {
         |                               ^~~~~~~~
   drivers/clk/mediatek/clk-bringup.c:96:31: warning: 'bring_up' defined but not used [-Wunused-variable]
   cc1: some warnings being treated as errors


vim +106 drivers/clk/mediatek/clk-bringup.c

   105	
 > 106	module_platform_driver(bring_up);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [1/5] clk: mt8189: Porting driver for clk

[kernel test robot]

Hi irving.ch.lin,

kernel test robot noticed the following build errors:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on linus/master v6.15 next-20250530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/irving-ch-lin/clk-mt8189-Porting-driver-for-clk/20250603-105623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link:    https://lore.kernel.org/r/20250602083624.1849719-1-irving-ch.lin%40mediatek.com
patch subject: [1/5] clk: mt8189: Porting driver for clk
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250604/202506040506.Hrl72R0Q-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250604/202506040506.Hrl72R0Q-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506040506.Hrl72R0Q-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/mediatek/clk-mt8189.c:22:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      22 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-bringup.c:18:43: error: incomplete definition of type 'struct platform_device'
      18 |         clk_con = of_count_phandle_with_args(pdev->dev.of_node, "clocks",
         |                                              ~~~~^
   include/linux/of_platform.h:14:8: note: forward declaration of 'struct platform_device'
      14 | struct platform_device;
         |        ^
   drivers/clk/mediatek/clk-bringup.c:22:24: error: incomplete definition of type 'struct platform_device'
      22 |                 clk = of_clk_get(pdev->dev.of_node, i);
         |                                  ~~~~^
   include/linux/of_platform.h:14:8: note: forward declaration of 'struct platform_device'
      14 | struct platform_device;
         |        ^
   drivers/clk/mediatek/clk-bringup.c:48:33: error: incomplete definition of type 'struct platform_device'
      48 |         struct device_node *node = pdev->dev.of_node;
         |                                    ~~~~^
   include/linux/of_platform.h:14:8: note: forward declaration of 'struct platform_device'
      14 | struct platform_device;
         |        ^
   drivers/clk/mediatek/clk-bringup.c:78:44: error: incomplete definition of type 'struct platform_device'
      78 |         clk_probe = of_device_get_match_data(&pdev->dev);
         |                                               ~~~~^
   include/linux/of_platform.h:14:8: note: forward declaration of 'struct platform_device'
      14 | struct platform_device;
         |        ^
>> drivers/clk/mediatek/clk-bringup.c:84:3: error: call to undeclared function 'dev_err'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      84 |                 dev_err(&pdev->dev,
         |                 ^
   drivers/clk/mediatek/clk-bringup.c:84:16: error: incomplete definition of type 'struct platform_device'
      84 |                 dev_err(&pdev->dev,
         |                          ~~~~^
   include/linux/of_platform.h:14:8: note: forward declaration of 'struct platform_device'
      14 | struct platform_device;
         |        ^
   drivers/clk/mediatek/clk-bringup.c:86:8: error: incomplete definition of type 'struct platform_device'
      86 |                         pdev->name, r);
         |                         ~~~~^
   include/linux/of_platform.h:14:8: note: forward declaration of 'struct platform_device'
      14 | struct platform_device;
         |        ^
>> drivers/clk/mediatek/clk-bringup.c:96:31: error: variable has incomplete type 'struct platform_driver'
      96 | static struct platform_driver bring_up = {
         |                               ^
   drivers/clk/mediatek/clk-bringup.c:96:15: note: forward declaration of 'struct platform_driver'
      96 | static struct platform_driver bring_up = {
         |               ^
>> drivers/clk/mediatek/clk-bringup.c:106:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     106 | module_platform_driver(bring_up);
         | ^
         | int
>> drivers/clk/mediatek/clk-bringup.c:106:24: error: a parameter list without types is only allowed in a function definition
     106 | module_platform_driver(bring_up);
         |                        ^
   10 errors generated.
--
>> drivers/clk/mediatek/clk-mt8189-adsp.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-cam.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-mmsys.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-img.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-iic.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-bus.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-mdpsys.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-mfg.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/clk/mediatek/clk-mt8189-scp.c:15:10: fatal error: 'dt-bindings/clock/mt8189-clk.h' file not found
      15 | #include <dt-bindings/clock/mt8189-clk.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
..


vim +22 drivers/clk/mediatek/clk-mt8189.c

    21	
  > 22	#include <dt-bindings/clock/mt8189-clk.h>
    23	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki