From: Sudeep Holla <sudeep.holla@arm.com>
To: Lukas Bulwahn <lbulwahn@redhat.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] pmdomain: arm: scmi_pm_domain: remove code clutter
Date: Fri, 6 Jun 2025 10:21:29 +0100 [thread overview]
Message-ID: <20250606-charming-aloof-adder-8acc6d@sudeepholla> (raw)
In-Reply-To: <20250606090802.597504-1-lukas.bulwahn@redhat.com>
On Fri, Jun 06, 2025 at 11:08:02AM +0200, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> There is no need to introduce the boolean power_on to select the constant
> value for state. Simply pass the value for state as argument. Just remove
> this code clutter.
>
> No functional change.
>
Nice cleanup. Thanks for doing this.
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Ulf,
I assume you will pick this up when you start collecting patches for
next merge window.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-06-06 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 9:08 [PATCH] pmdomain: arm: scmi_pm_domain: remove code clutter Lukas Bulwahn
2025-06-06 9:21 ` Sudeep Holla [this message]
2025-06-06 9:38 ` Javier Martinez Canillas
2025-06-18 12:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606-charming-aloof-adder-8acc6d@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=javierm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lbulwahn@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).