From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
imx@lists.linux.dev, wahrenst@gmx.net
Subject: Re: [PATCH v2 1/1] dt-bindings: ieee802154: Convert at86rf230.txt yaml format
Date: Thu, 5 Jun 2025 21:11:56 -0500 [thread overview]
Message-ID: <20250606021156.GA3780713-robh@kernel.org> (raw)
In-Reply-To: <20250602151601.948874-1-Frank.Li@nxp.com>
On Mon, Jun 02, 2025 at 11:15:58AM -0400, Frank Li wrote:
> Convert at86rf230.txt yaml format.
>
> Additional changes:
> - Add ref to spi-peripheral-props.yaml.
> - Add parent spi node in examples.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - xtal-trim to uint8
> ---
> .../bindings/net/ieee802154/at86rf230.txt | 27 --------
> .../net/ieee802154/atmel,at86rf233.yaml | 65 +++++++++++++++++++
> 2 files changed, 65 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/ieee802154/at86rf230.txt
> create mode 100644 Documentation/devicetree/bindings/net/ieee802154/atmel,at86rf233.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/ieee802154/at86rf230.txt b/Documentation/devicetree/bindings/net/ieee802154/at86rf230.txt
> deleted file mode 100644
> index 168f1be509126..0000000000000
> --- a/Documentation/devicetree/bindings/net/ieee802154/at86rf230.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -* AT86RF230 IEEE 802.15.4 *
> -
> -Required properties:
> - - compatible: should be "atmel,at86rf230", "atmel,at86rf231",
> - "atmel,at86rf233" or "atmel,at86rf212"
> - - spi-max-frequency: maximal bus speed, should be set to 7500000 depends
> - sync or async operation mode
> - - reg: the chipselect index
> - - interrupts: the interrupt generated by the device. Non high-level
> - can occur deadlocks while handling isr.
> -
> -Optional properties:
> - - reset-gpio: GPIO spec for the rstn pin
> - - sleep-gpio: GPIO spec for the slp_tr pin
> - - xtal-trim: u8 value for fine tuning the internal capacitance
> - arrays of xtal pins: 0 = +0 pF, 0xf = +4.5 pF
> -
> -Example:
> -
> - at86rf231@0 {
> - compatible = "atmel,at86rf231";
> - spi-max-frequency = <7500000>;
> - reg = <0>;
> - interrupts = <19 4>;
> - interrupt-parent = <&gpio3>;
> - xtal-trim = /bits/ 8 <0x06>;
> - };
> diff --git a/Documentation/devicetree/bindings/net/ieee802154/atmel,at86rf233.yaml b/Documentation/devicetree/bindings/net/ieee802154/atmel,at86rf233.yaml
> new file mode 100644
> index 0000000000000..d84e05c133710
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ieee802154/atmel,at86rf233.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ieee802154/atmel,at86rf233.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AT86RF230 IEEE 802.15.4
> +
> +maintainers:
> + - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> + compatible:
> + enum:
> + - atmel,at86rf212
> + - atmel,at86rf230
> + - atmel,at86rf231
> + - atmel,at86rf233
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpio:
> + maxItems: 1
> +
> + sleep-gpio:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 7500000
> +
> + xtal-trim:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: |
> + u8 value for fine tuning the internal capacitance
> + arrays of xtal pins: 0 = +0 pF, 0xf = +4.5 pF
Drop 'u8 value for '
maximum: 0xf
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + zigbee@0 {
> + compatible = "atmel,at86rf231";
> + reg = <0>;
> + spi-max-frequency = <7500000>;
> + interrupts = <19 4>;
> + interrupt-parent = <&gpio3>;
> + xtal-trim = /bits/ 8 <0x06>;
> + };
> + };
> --
> 2.34.1
>
prev parent reply other threads:[~2025-06-06 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 15:15 [PATCH v2 1/1] dt-bindings: ieee802154: Convert at86rf230.txt yaml format Frank Li
2025-06-06 2:11 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606021156.GA3780713-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).