[PATCH v2 0/5] Add support for BeagleBone Green Eco board

[PATCH v2 0/5] Add support for BeagleBone Green Eco board

[Kory Maincent]

SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
(BBG). It has minor differences from the BBG, such as a different PMIC,
a different Ethernet PHY, and a larger eMMC.

Also update the omap.yaml binding to include missing compatible strings
that were previously undocumented.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v2:
- Add patch 1 to 3 to fix binding and devicetree inconsistencies.
- Rename tps node name to generic pmic node name in am335x-bone-common.
- Link to v1: https://lore.kernel.org/r/20250523-bbg-v1-0-ef4a9e57eeee@bootlin.com

---
Kory Maincent (5):
      arm: dts: omap: Remove incorrect compatible strings from device trees
      binding: omap: Add lots of missing omap AM33 compatibles
      arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node
      arm: dts: omap: Add support for BeagleBone Green Eco board
      arm: omap2plus_defconfig: Enable TPS65219 regulator

 Documentation/devicetree/bindings/arm/ti/omap.yaml |  39 +++++
 arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
 arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi  |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 +++++++++++++++++++++
 .../boot/dts/ti/omap/am335x-bonegreen-wireless.dts |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts     |   2 +-
 .../arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts  |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-shc.dts           |   2 +-
 arch/arm/configs/omap2plus_defconfig               |   3 +
 10 files changed, 219 insertions(+), 6 deletions(-)
---
base-commit: e22b9ddaf3afd031abc350c303c7c07a51c569d8
change-id: 20250523-bbg-769018d1f2a7

Best regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible strings from device trees

[Kory Maincent]

Several device trees incorrectly included ti,am335x-bone-black or
ti,am335x-bone in their compatible lists without including the
corresponding bone-black-common or bone-common device tree files.
Remove these incompatible strings to fix the inconsistency.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- New patch
---
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts          | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts     | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts       | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-shc.dts                | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
index a4f5b5262645..fb88eebb8c5d 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
@@ -11,7 +11,7 @@
 
 / {
 	model = "TI AM335x BeagleBone Green Wireless";
-	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone", "ti,am33xx";
 
 	wlan_en_reg: fixedregulator@2 {
 		compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
index 18cc0f49e999..022ecc971476 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
@@ -10,5 +10,5 @@
 
 / {
 	model = "TI AM335x BeagleBone Green";
-	compatible = "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	compatible = "ti,am335x-bone-green", "ti,am335x-bone", "ti,am33xx";
 };
diff --git a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
index d28d39728847..d87ac31a16a9 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
@@ -16,7 +16,7 @@
 
 / {
 	model = "Octavo Systems OSD3358-SM-RED";
-	compatible = "oct,osd3358-sm-refdesign", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	compatible = "oct,osd3358-sm-refdesign", "ti,am33xx";
 };
 
 &ldo3_reg {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
index 78ce860e59b3..0c8a120a1811 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
@@ -12,7 +12,7 @@
 
 / {
 	model = "TI AM335x PocketBeagle";
-	compatible = "ti,am335x-pocketbeagle", "ti,am335x-bone", "ti,am33xx";
+	compatible = "ti,am335x-pocketbeagle", "ti,am33xx";
 
 	chosen {
 		stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-shc.dts b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
index 597482822608..f2393ff3f4d7 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-shc.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
@@ -12,7 +12,7 @@
 
 / {
 	model = "Bosch SHC";
-	compatible = "ti,am335x-shc", "ti,am335x-bone", "ti,am33xx";
+	compatible = "ti,am335x-shc", "ti,am33xx";
 
 	aliases {
 		mmcblk0 = &mmc1;

-- 
2.43.0

[PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Kory Maincent]

Add several compatible strings that were missing from the binding
documentation. Add description for Bone, BoneBlack and BoneGreen
variants.

Add several compatible that were missing from the binding.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- New patch
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index 3603edd7361d..c43fa4f4af81 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -104,12 +104,50 @@ properties:
       - description: TI AM33 based platform
         items:
           - enum:
+              - bosch,am335x-guardian
               - compulab,cm-t335
+              - grinn,am335x-chilisom
+              - gumstix,am335x-pepper
+              - moxa,uc-2101
               - moxa,uc-8100-me-t
+              - myir,myc-am335x
+              - myir,myd-am335x
               - novatech,am335x-lxm
+              - oct,osd3358-sm-refdesign
+              - tcl,am335x-sl50
               - ti,am335x-bone
               - ti,am335x-evm
+              - ti,am335x-evmsk
+              - ti,am335x-pocketbeagle
+              - ti,am335x-shc
               - ti,am3359-icev2
+              - vscom,onrisc
+          - const: ti,am33xx
+
+      - description: TI bone variants based on TI AM335
+        items:
+          - enum:
+              - ti,am335x-bone-black
+              - ti,am335x-bone-green
+              - ti,am335x-pocketbeagle
+          - const: ti,am335x-bone
+          - const: ti,am33xx
+
+      - description: TI bone black variants based on TI AM335
+        items:
+          - enum:
+              - sancloud,am335x-boneenhanced
+              - ti,am335x-bone-black-wireless
+          - const: ti,am335x-bone-black
+          - const: ti,am335x-bone
+          - const: ti,am33xx
+
+      - description: TI bone green variants based on TI AM335
+        items:
+          - enum:
+              - ti,am335x-bone-green-wireless
+          - const: ti,am335x-bone-green
+          - const: ti,am335x-bone
           - const: ti,am33xx
 
       - description: Compulab board variants based on TI AM33

-- 
2.43.0

[PATCH v2 3/5] arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node

[Kory Maincent]

Rename tps@24 to the generic pmic@24 node name.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- New patch.
---
 arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi b/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi
index c400b7b70d0d..ad1e60a9b6fd 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi
@@ -212,7 +212,7 @@ &i2c0 {
 	status = "okay";
 	clock-frequency = <400000>;
 
-	tps: tps@24 {
+	tps: pmic@24 {
 		reg = <0x24>;
 	};
 

-- 
2.43.0

[PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Kory Maincent]

SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
(BBG). It has minor differences from the BBG, such as a different PMIC,
a different Ethernet PHY, and a larger eMMC.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v2:
- Used generic pmic node name.
- Add regulator prefix to fixed regulator node name.
- Add the compatible to omap.yaml binding
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
 arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 +++++++++++++++++++++
 3 files changed, 172 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index c43fa4f4af81..774c13157caa 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -145,6 +145,7 @@ properties:
       - description: TI bone green variants based on TI AM335
         items:
           - enum:
+              - ti,am335x-bone-green-eco
               - ti,am335x-bone-green-wireless
           - const: ti,am335x-bone-green
           - const: ti,am335x-bone
diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
index 95c68135dd0c..1aef60eef671 100644
--- a/arch/arm/boot/dts/ti/omap/Makefile
+++ b/arch/arm/boot/dts/ti/omap/Makefile
@@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
 	am335x-boneblue.dtb \
 	am335x-bonegreen.dtb \
 	am335x-bonegreen-wireless.dtb \
+	am335x-bonegreen-eco.dtb \
 	am335x-chiliboard.dtb \
 	am335x-cm-t335.dtb \
 	am335x-evm.dtb \
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
new file mode 100644
index 000000000000..f2592a3ddbbb
--- /dev/null
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
@@ -0,0 +1,170 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2025 Bootlin
+ */
+/dts-v1/;
+
+#include "am33xx.dtsi"
+#include "am335x-bone-common.dtsi"
+#include "am335x-bonegreen-common.dtsi"
+#include <dt-bindings/net/ti-dp83867.h>
+
+/ {
+	model = "TI AM335x BeagleBone Green Eco";
+	compatible = "ti,am335x-bone-green-eco", "ti,am335x-bone-green",
+		     "ti,am335x-bone", "ti,am33xx";
+
+	cpus {
+		cpu@0 {
+			cpu0-supply = <&buck1>;
+		};
+	};
+
+	sys_5v: regulator-sys-5v {
+		compatible = "regulator-fixed";
+		regulator-name = "sys_5v";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+
+	v3v3: regulator-v3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "v3v3";
+		regulator-always-on;
+	};
+};
+
+&usb0 {
+	interrupts-extended = <&intc 18>;
+	interrupt-names = "mc";
+};
+
+&baseboard_eeprom {
+	vcc-supply = <&v3v3>;
+};
+
+&i2c0 {
+	/delete-node/ pmic@24;
+
+	tps65214: pmic@30 {
+		compatible = "ti,tps65214";
+		reg = <0x30>;
+		buck1-supply = <&sys_5v>;
+		buck2-supply = <&sys_5v>;
+		buck3-supply = <&sys_5v>;
+		ldo1-supply = <&sys_5v>;
+		ldo2-supply = <&sys_5v>;
+
+		interrupt-parent = <&intc>;
+		interrupts = <7>;
+		pinctrl-0 = <&pmic_irq_pins_default>;
+
+		regulators {
+			buck1: buck1 {
+				regulator-name = "vdd_mpu";
+				regulator-min-microvolt = <925000>;
+				regulator-max-microvolt = <1351500>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck2: buck2 {
+				regulator-name = "vdd_core";
+				regulator-min-microvolt = <925000>;
+				regulator-max-microvolt = <1150000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck3: buck3 {
+				regulator-name = "vdds_ddr";
+				regulator-min-microvolt = <1350000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-always-on;
+			};
+
+			ldo1_reg: ldo1 {
+				regulator-name = "vdd_1v8_1";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo2_reg: ldo2 {
+				regulator-name = "vdd_1v8_2";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&cpsw_port1 {
+	phy-mode = "rgmii-id";
+	phy-handle = <&dp83867_0>;
+	ti,dual-emac-pvid = <1>;
+};
+
+&mac_sw {
+	pinctrl-0 = <&cpsw_b_default>;
+	pinctrl-1 = <&cpsw_b_sleep>;
+};
+
+&davinci_mdio_sw {
+	/delete-node/ ethernet-phy@0;
+
+	dp83867_0: ethernet-phy@0 {
+		reg = <0>;
+		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
+		ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
+		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
+		ti,min-output-impedance;
+		ti,dp83867-rxctrl-strap-quirk;
+	};
+};
+
+&am33xx_pinmux {
+	cpsw_b_default: cpsw-b-default-pins {
+		pinctrl-single,pins = <
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_EN, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_DV, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_CLK, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD0, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD1, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD2, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD3, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD0, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD1, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD2, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD3, PIN_INPUT_PULLDOWN, MUX_MODE2)
+		>;
+	};
+
+	cpsw_b_sleep: cpsw-b-sleep-pins {
+		pinctrl-single,pins = <
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_EN, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_DV, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD0, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD1, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD2, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD3, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD0, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD1, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD2, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD3, PIN_INPUT_PULLDOWN, MUX_MODE7)
+		>;
+	};
+
+	pmic_irq_pins_default: pmic-irq-default-pins {
+		pinctrl-single,pins = <
+			AM33XX_IOPAD(AM335X_PIN_NNMI, PIN_INPUT_PULLUP | MUX_MODE0)
+		>;
+	};
+};

-- 
2.43.0

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2850 bytes --]

On Mon, Jun 09, 2025 at 05:43:52PM +0200, Kory Maincent wrote:
> Add several compatible strings that were missing from the binding
> documentation. Add description for Bone, BoneBlack and BoneGreen
> variants.
> 
> Add several compatible that were missing from the binding.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - New patch
> ---
>  Documentation/devicetree/bindings/arm/ti/omap.yaml | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> index 3603edd7361d..c43fa4f4af81 100644
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -104,12 +104,50 @@ properties:
>        - description: TI AM33 based platform
>          items:
>            - enum:
> +              - bosch,am335x-guardian
>                - compulab,cm-t335
> +              - grinn,am335x-chilisom
> +              - gumstix,am335x-pepper
> +              - moxa,uc-2101
>                - moxa,uc-8100-me-t
> +              - myir,myc-am335x
> +              - myir,myd-am335x
>                - novatech,am335x-lxm
> +              - oct,osd3358-sm-refdesign
> +              - tcl,am335x-sl50
>                - ti,am335x-bone
>                - ti,am335x-evm
> +              - ti,am335x-evmsk
> +              - ti,am335x-pocketbeagle
> +              - ti,am335x-shc
>                - ti,am3359-icev2
> +              - vscom,onrisc
> +          - const: ti,am33xx
> +
> +      - description: TI bone variants based on TI AM335

"bone variant" sounds like some shortand or nickname. Are the boards not
called "beaglebone green" and "beaglebone black"? Whatever about the
compatible, the description should use the full name I think.

> +        items:
> +          - enum:
> +              - ti,am335x-bone-black
> +              - ti,am335x-bone-green
> +              - ti,am335x-pocketbeagle
> +          - const: ti,am335x-bone
> +          - const: ti,am33xx
> +
> +      - description: TI bone black variants based on TI AM335
> +        items:
> +          - enum:
> +              - sancloud,am335x-boneenhanced
> +              - ti,am335x-bone-black-wireless
> +          - const: ti,am335x-bone-black
> +          - const: ti,am335x-bone
> +          - const: ti,am33xx
> +
> +      - description: TI bone green variants based on TI AM335
> +        items:
> +          - enum:
> +              - ti,am335x-bone-green-wireless
> +          - const: ti,am335x-bone-green
> +          - const: ti,am335x-bone
>            - const: ti,am33xx
>  
>        - description: Compulab board variants based on TI AM33
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote:
> SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> (BBG). It has minor differences from the BBG, such as a different PMIC,
> a different Ethernet PHY, and a larger eMMC.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Changes in v2:
> - Used generic pmic node name.
> - Add regulator prefix to fixed regulator node name.
> - Add the compatible to omap.yaml binding
> ---
>  Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
>  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170 +++++++++++++++++++++
>  3 files changed, 172 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> index c43fa4f4af81..774c13157caa 100644
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -145,6 +145,7 @@ properties:
>        - description: TI bone green variants based on TI AM335
>          items:
>            - enum:
> +              - ti,am335x-bone-green-eco
>                - ti,am335x-bone-green-wireless
>            - const: ti,am335x-bone-green
>            - const: ti,am335x-bone

Why is this hunk here?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Andreas Kemnade]

Am Mon, 9 Jun 2025 18:03:05 +0100
schrieb Conor Dooley <conor@kernel.org>:

> > +      - description: TI bone variants based on TI AM335  
> 
> "bone variant" sounds like some shortand or nickname. Are the boards not
> called "beaglebone green" and "beaglebone black"? Whatever about the
> compatible, the description should use the full name I think.
> 
we have an enum below it listing all those variants. So "variants"
makes sense here, but better "TI Beaglebone variants"

> > +        items:
> > +          - enum:
> > +              - ti,am335x-bone-black
> > +              - ti,am335x-bone-green
> > +              - ti,am335x-pocketbeagle
> > +          - const: ti,am335x-bone
> > +          - const: ti,am33xx
> > +

Regards,
Andreas

Re: [PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible strings from device trees

[Andreas Kemnade]

Am Mon, 09 Jun 2025 17:43:51 +0200
schrieb Kory Maincent <kory.maincent@bootlin.com>:

> Several device trees incorrectly included ti,am335x-bone-black or
> ti,am335x-bone in their compatible lists without including the
> corresponding bone-black-common or bone-common device tree files.
> Remove these incompatible strings to fix the inconsistency.
> 
thanks for cleaning up some mess.

> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - New patch
> ---
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts          | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts     | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts       | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-shc.dts                | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> index a4f5b5262645..fb88eebb8c5d 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> @@ -11,7 +11,7 @@
>  
>  / {
>  	model = "TI AM335x BeagleBone Green Wireless";
> -	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone", "ti,am33xx";
>  
this looks like too much cleanup, also according your omap.yaml stuff,
ti,am335x-bone-green should still be included.

Regards,
Andreas

Re: [PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible strings from device trees

[Kory Maincent]

Le Mon, 9 Jun 2025 22:08:09 +0200,
Andreas Kemnade <andreas@kemnade.info> a écrit :

> Am Mon, 09 Jun 2025 17:43:51 +0200
> schrieb Kory Maincent <kory.maincent@bootlin.com>:
> 
> > Several device trees incorrectly included ti,am335x-bone-black or
> > ti,am335x-bone in their compatible lists without including the
> > corresponding bone-black-common or bone-common device tree files.
> > Remove these incompatible strings to fix the inconsistency.
> >   
> thanks for cleaning up some mess.
> 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > 
> > Change in v2:
> > - New patch
> > ---
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts          | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts     | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts       | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-shc.dts                | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> > b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts index
> > a4f5b5262645..fb88eebb8c5d 100644 ---
> > a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts +++
> > b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts @@ -11,7 +11,7 @@
> >  
> >  / {
> >  	model = "TI AM335x BeagleBone Green Wireless";
> > -	compatible = "ti,am335x-bone-green-wireless",
> > "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone",
> > "ti,am33xx";
> > +	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone",
> > "ti,am33xx"; 
> this looks like too much cleanup, also according your omap.yaml stuff,
> ti,am335x-bone-green should still be included.

Oh indeed! Thanks.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Kory Maincent]

Le Mon, 9 Jun 2025 18:04:01 +0100,
Conor Dooley <conor@kernel.org> a écrit :

> On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote:
> > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> > (BBG). It has minor differences from the BBG, such as a different PMIC,
> > a different Ethernet PHY, and a larger eMMC.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > 
> > Changes in v2:
> > - Used generic pmic node name.
> > - Add regulator prefix to fixed regulator node name.
> > - Add the compatible to omap.yaml binding
> > ---
> >  Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
> >  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170
> > +++++++++++++++++++++ 3 files changed, 172 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > c43fa4f4af81..774c13157caa 100644 ---
> > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@
> > properties:
> >        - description: TI bone green variants based on TI AM335
> >          items:
> >            - enum:
> > +              - ti,am335x-bone-green-eco
> >                - ti,am335x-bone-green-wireless
> >            - const: ti,am335x-bone-green
> >            - const: ti,am335x-bone  
> 
> Why is this hunk here?

Do you mean that the binding change should be in another patch?

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Andreas Kemnade]

Am Mon, 9 Jun 2025 22:45:02 +0200
schrieb Kory Maincent <kory.maincent@bootlin.com>:

> Le Mon, 9 Jun 2025 18:04:01 +0100,
> Conor Dooley <conor@kernel.org> a écrit :
> 
> > On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote:  
> > > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> > > (BBG). It has minor differences from the BBG, such as a different PMIC,
> > > a different Ethernet PHY, and a larger eMMC.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > > ---
> > > 
> > > Changes in v2:
> > > - Used generic pmic node name.
> > > - Add regulator prefix to fixed regulator node name.
> > > - Add the compatible to omap.yaml binding
> > > ---
> > >  Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
> > >  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
> > >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170
> > > +++++++++++++++++++++ 3 files changed, 172 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > c43fa4f4af81..774c13157caa 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@
> > > properties:
> > >        - description: TI bone green variants based on TI AM335
> > >          items:
> > >            - enum:
> > > +              - ti,am335x-bone-green-eco
> > >                - ti,am335x-bone-green-wireless
> > >            - const: ti,am335x-bone-green
> > >            - const: ti,am335x-bone    
> > 
> > Why is this hunk here?  
> 
> Do you mean that the binding change should be in another patch?
> 
Usually binding changes are in a separate patch. Maybe you can merge it
with Patch 2. The lonely enum looks a bit strange there, so if these
things are merged, it will look more natural.

Regards,
Andreas

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Andrew Davis]

On 6/9/25 10:43 AM, Kory Maincent wrote:
> Add several compatible strings that were missing from the binding
> documentation. Add description for Bone, BoneBlack and BoneGreen
> variants.
> 
> Add several compatible that were missing from the binding.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - New patch
> ---
>   Documentation/devicetree/bindings/arm/ti/omap.yaml | 38 ++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> index 3603edd7361d..c43fa4f4af81 100644
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -104,12 +104,50 @@ properties:
>         - description: TI AM33 based platform
>           items:
>             - enum:
> +              - bosch,am335x-guardian
>                 - compulab,cm-t335
> +              - grinn,am335x-chilisom
> +              - gumstix,am335x-pepper
> +              - moxa,uc-2101
>                 - moxa,uc-8100-me-t
> +              - myir,myc-am335x
> +              - myir,myd-am335x
>                 - novatech,am335x-lxm
> +              - oct,osd3358-sm-refdesign
> +              - tcl,am335x-sl50
>                 - ti,am335x-bone
>                 - ti,am335x-evm
> +              - ti,am335x-evmsk
> +              - ti,am335x-pocketbeagle
> +              - ti,am335x-shc
>                 - ti,am3359-icev2
> +              - vscom,onrisc
> +          - const: ti,am33xx
> +
> +      - description: TI bone variants based on TI AM335

Do we really need these "bone variants" split out from the above
list of TI AM33 based boards? We don't do that for any of the other
boards, you get a SoC and a Board compatible, every classification
in-between is just unneeded.

Andrew

> +        items:
> +          - enum:
> +              - ti,am335x-bone-black
> +              - ti,am335x-bone-green
> +              - ti,am335x-pocketbeagle
> +          - const: ti,am335x-bone
> +          - const: ti,am33xx
> +
> +      - description: TI bone black variants based on TI AM335
> +        items:
> +          - enum:
> +              - sancloud,am335x-boneenhanced
> +              - ti,am335x-bone-black-wireless
> +          - const: ti,am335x-bone-black
> +          - const: ti,am335x-bone
> +          - const: ti,am33xx
> +
> +      - description: TI bone green variants based on TI AM335
> +        items:
> +          - enum:
> +              - ti,am335x-bone-green-wireless
> +          - const: ti,am335x-bone-green
> +          - const: ti,am335x-bone
>             - const: ti,am33xx
>   
>         - description: Compulab board variants based on TI AM33
> 

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Kory Maincent]

Le Mon, 9 Jun 2025 18:34:10 -0500,
Andrew Davis <afd@ti.com> a écrit :

> On 6/9/25 10:43 AM, Kory Maincent wrote:
> > Add several compatible strings that were missing from the binding
> > documentation. Add description for Bone, BoneBlack and BoneGreen
> > variants.
> > 
> > Add several compatible that were missing from the binding.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > 
> > Change in v2:
> > - New patch
> > ---
> >   Documentation/devicetree/bindings/arm/ti/omap.yaml | 38
> > ++++++++++++++++++++++ 1 file changed, 38 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > 3603edd7361d..c43fa4f4af81 100644 ---
> > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -104,12 +104,50 @@
> > properties:
> >         - description: TI AM33 based platform
> >           items:
> >             - enum:
> > +              - bosch,am335x-guardian
> >                 - compulab,cm-t335
> > +              - grinn,am335x-chilisom
> > +              - gumstix,am335x-pepper
> > +              - moxa,uc-2101
> >                 - moxa,uc-8100-me-t
> > +              - myir,myc-am335x
> > +              - myir,myd-am335x
> >                 - novatech,am335x-lxm
> > +              - oct,osd3358-sm-refdesign
> > +              - tcl,am335x-sl50
> >                 - ti,am335x-bone
> >                 - ti,am335x-evm
> > +              - ti,am335x-evmsk
> > +              - ti,am335x-pocketbeagle
> > +              - ti,am335x-shc
> >                 - ti,am3359-icev2
> > +              - vscom,onrisc
> > +          - const: ti,am33xx
> > +
> > +      - description: TI bone variants based on TI AM335  
> 
> Do we really need these "bone variants" split out from the above
> list of TI AM33 based boards? We don't do that for any of the other
> boards, you get a SoC and a Board compatible, every classification
> in-between is just unneeded.

As omap maintainers prefer. I did that to have the least amount of change in
the devicetree. We could have U-boot using these compatible but after a quick
check it seems not.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Jason Kridner]

On Mon, Jun 9, 2025 at 1:03 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Mon, Jun 09, 2025 at 05:43:52PM +0200, Kory Maincent wrote:
> > Add several compatible strings that were missing from the binding
> > documentation. Add description for Bone, BoneBlack and BoneGreen
> > variants.
> >
> > Add several compatible that were missing from the binding.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> >
> > Change in v2:
> > - New patch
> > ---
> >  Documentation/devicetree/bindings/arm/ti/omap.yaml | 38 ++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > index 3603edd7361d..c43fa4f4af81 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > @@ -104,12 +104,50 @@ properties:
> >        - description: TI AM33 based platform
> >          items:
> >            - enum:
> > +              - bosch,am335x-guardian
> >                - compulab,cm-t335
> > +              - grinn,am335x-chilisom
> > +              - gumstix,am335x-pepper
> > +              - moxa,uc-2101
> >                - moxa,uc-8100-me-t
> > +              - myir,myc-am335x
> > +              - myir,myd-am335x
> >                - novatech,am335x-lxm
> > +              - oct,osd3358-sm-refdesign
> > +              - tcl,am335x-sl50
> >                - ti,am335x-bone

What is the convention here? "beagle" is a vendor, so not sure why
this continues to be "ti". The owner of the brand for this board is
"The BeagleBoard.org Foundation". Not sure if it is reasonable to fix
this.

> >                - ti,am335x-evm
> > +              - ti,am335x-evmsk
> > +              - ti,am335x-pocketbeagle

This one is also "beagle", not "ti".

> > +              - ti,am335x-shc
> >                - ti,am3359-icev2
> > +              - vscom,onrisc
> > +          - const: ti,am33xx
> > +
> > +      - description: TI bone variants based on TI AM335
>
> "bone variant" sounds like some shortand or nickname. Are the boards not
> called "beaglebone green" and "beaglebone black"? Whatever about the
> compatible, the description should use the full name I think.

I'm not sure this is really needed. There is some desire to fall-back
to a building block level of functionality around these derivatives of
"BeagleBoard.org BeagleBone", including compatibility with the
expansion headers, but I don't think that will happen at this level.
In u-boot, it is possible to make the determination to utilize a
less-complete devicetree, but it seems impractical here.

What are the objections to just listing these all as TI AM33 based platforms?

>
> > +        items:
> > +          - enum:
> > +              - ti,am335x-bone-black

"beagle"

> > +              - ti,am335x-bone-green

This is a Seeed Technology Co., Ltd. board that licenses the
BeagleBone brand from the BeagleBoard.org Foundation, so "seeed", not
"ti".

> > +              - ti,am335x-pocketbeagle

Not sure why this one is repeated. Also, it very much begs the
definition of being a BeagleBone derivative outside of usage of the
PMIC.

> > +          - const: ti,am335x-bone
> > +          - const: ti,am33xx
> > +
> > +      - description: TI bone black variants based on TI AM335

There are lots of derivatives of BeagleBoard.org BeagleBone Black and
falling back to a compatible makes some sense, but I don't think it is
of practical benefit here the way things have worked out. The smarts
have to be in the bootloader based off of the board IDs and the kernel
is just going to do what it is told.

Now, if we had some practical overlays performed by the kernel, this
would all make some sense as patches between these variants provide
useful fallback operation, but this is otherwise confusing. I
appreciate the credit given to BeagleBoard.org for them being
variants, but this really isn't the place.

> > +        items:
> > +          - enum:
> > +              - sancloud,am335x-boneenhanced

Note that this one is correct to be "sancloud", who licenses the
BeagleBone brand from the BeagleBoard.org Foundation.

> > +              - ti,am335x-bone-black-wireless

"beagle"

> > +          - const: ti,am335x-bone-black
> > +          - const: ti,am335x-bone
> > +          - const: ti,am33xx
> > +
> > +      - description: TI bone green variants based on TI AM335
> > +        items:
> > +          - enum:
> > +              - ti,am335x-bone-green-wireless

"seeed"

> > +          - const: ti,am335x-bone-green
> > +          - const: ti,am335x-bone
> >            - const: ti,am33xx
> >
> >        - description: Compulab board variants based on TI AM33
> >
> > --
> > 2.43.0
> >


-- 
Learn about me and setup a meeting at
https://beagleboard.org/about/jkridner - a 501c3 non-profit educating
around open hardware computing

Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

On Mon, Jun 09, 2025 at 10:45:02PM +0200, Kory Maincent wrote:
> Le Mon, 9 Jun 2025 18:04:01 +0100,
> Conor Dooley <conor@kernel.org> a écrit :
> 
> > On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote:
> > > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> > > (BBG). It has minor differences from the BBG, such as a different PMIC,
> > > a different Ethernet PHY, and a larger eMMC.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > > ---
> > > 
> > > Changes in v2:
> > > - Used generic pmic node name.
> > > - Add regulator prefix to fixed regulator node name.
> > > - Add the compatible to omap.yaml binding
> > > ---
> > >  Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
> > >  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
> > >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170
> > > +++++++++++++++++++++ 3 files changed, 172 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > c43fa4f4af81..774c13157caa 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@
> > > properties:
> > >        - description: TI bone green variants based on TI AM335
> > >          items:
> > >            - enum:
> > > +              - ti,am335x-bone-green-eco
> > >                - ti,am335x-bone-green-wireless
> > >            - const: ti,am335x-bone-green
> > >            - const: ti,am335x-bone  
> > 
> > Why is this hunk here?
> 
> Do you mean that the binding change should be in another patch?

Yes, you have a binding change hidden away in a dts patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Mon, Jun 09, 2025 at 09:50:44PM +0200, Andreas Kemnade wrote:
> Am Mon, 9 Jun 2025 18:03:05 +0100
> schrieb Conor Dooley <conor@kernel.org>:
> 
> > > +      - description: TI bone variants based on TI AM335  
> > 
> > "bone variant" sounds like some shortand or nickname. Are the boards not
> > called "beaglebone green" and "beaglebone black"? Whatever about the
> > compatible, the description should use the full name I think.
> > 
> we have an enum below it listing all those variants. So "variants"
> makes sense here, but better "TI Beaglebone variants"

Yes, this was a comment on calling it a "bone", when that's not what the
boards are called in their marketing material etc, not objecting to the
word variant.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Krzysztof Kozlowski]

On Mon, Jun 09, 2025 at 05:43:52PM GMT, Kory Maincent wrote:
> Add several compatible strings that were missing from the binding
> documentation. Add description for Bone, BoneBlack and BoneGreen
> variants.
> 
> Add several compatible that were missing from the binding.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Subject prefix is: dt-bindings.

https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof

Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator

[Andrew Davis]

On 6/9/25 10:43 AM, Kory Maincent wrote:
> Enable the TPS65219 regulator in the defconfig, as the TPS65214
> variant is used by the newly introduced BeagleBoard Green Eco board.
> 
> Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>   arch/arm/configs/omap2plus_defconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 9f9780c8e62a..2ad669f7b202 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig

Why omap2plus_defconfig? OMAP3 and newer are all ARMv7 and
boards with those can/should use multi_v7_defconfig.

OMAP1 and OMAP2 are the only devices that cannot use multi_v7_defconfig
as they are not ARMv7. So I'd almost recommend we rename
omap2plus_defconfig to just omap2_defconfig to avoid more confusion.
Then we would have:

OMAP1:  ARMv4/5: omap1_defconfig
OMAP2:  ARMv6:   omap2_defconfig
OMAP3+: ARMv7:   multi_v7_defconfig

Any issue with that I'm missing?

Andrew

> @@ -385,6 +385,7 @@ CONFIG_TOUCHSCREEN_TSC2007=m
>   CONFIG_INPUT_MISC=y
>   CONFIG_INPUT_CPCAP_PWRBUTTON=m
>   CONFIG_INPUT_TPS65218_PWRBUTTON=m
> +CONFIG_INPUT_TPS65219_PWRBUTTON=m
>   CONFIG_INPUT_TWL4030_PWRBUTTON=m
>   CONFIG_INPUT_UINPUT=m
>   CONFIG_INPUT_PALMAS_PWRBUTTON=m
> @@ -454,6 +455,7 @@ CONFIG_MFD_TPS65217=y
>   CONFIG_MFD_TI_LP873X=y
>   CONFIG_MFD_TI_LP87565=y
>   CONFIG_MFD_TPS65218=y
> +CONFIG_MFD_TPS65219=y
>   CONFIG_MFD_TPS65910=y
>   CONFIG_TWL6040_CORE=y
>   CONFIG_REGULATOR_CPCAP=y
> @@ -470,6 +472,7 @@ CONFIG_REGULATOR_TPS65023=y
>   CONFIG_REGULATOR_TPS6507X=y
>   CONFIG_REGULATOR_TPS65217=y
>   CONFIG_REGULATOR_TPS65218=y
> +CONFIG_REGULATOR_TPS65219=y
>   CONFIG_REGULATOR_TPS65910=y
>   CONFIG_REGULATOR_TWL4030=y
>   CONFIG_RC_CORE=m
> 

Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator

[Andreas Kemnade]

Am Wed, 11 Jun 2025 16:13:05 -0500
schrieb Andrew Davis <afd@ti.com>:

> On 6/9/25 10:43 AM, Kory Maincent wrote:
> > Enable the TPS65219 regulator in the defconfig, as the TPS65214
> > variant is used by the newly introduced BeagleBoard Green Eco board.
> > 
> > Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> >   arch/arm/configs/omap2plus_defconfig | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 9f9780c8e62a..2ad669f7b202 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig  
> 
> Why omap2plus_defconfig? OMAP3 and newer are all ARMv7 and
> boards with those can/should use multi_v7_defconfig.
> 
if there are enough drivers enabled there, it would work, but it is not.
So there need to be a bunch of patches to add the missing stuff.
omap2plus_defconfig is there and support for boards are added.

So I think until multi_v7_defconfig is really usable for OMAP3+, we
should stick with the name omap2plus_defconfig and add stuff.
If we rename omap2plus_defconfig to omap2_defconfig, we should imho
disable OMAP3/4/5 there to avoid confusion.

Regards,
Andreas

Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator

[Andrew Davis]

On 6/12/25 1:12 AM, Andreas Kemnade wrote:
> Am Wed, 11 Jun 2025 16:13:05 -0500
> schrieb Andrew Davis <afd@ti.com>:
> 
>> On 6/9/25 10:43 AM, Kory Maincent wrote:
>>> Enable the TPS65219 regulator in the defconfig, as the TPS65214
>>> variant is used by the newly introduced BeagleBoard Green Eco board.
>>>
>>> Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
>>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>>> ---
>>>    arch/arm/configs/omap2plus_defconfig | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>>> index 9f9780c8e62a..2ad669f7b202 100644
>>> --- a/arch/arm/configs/omap2plus_defconfig
>>> +++ b/arch/arm/configs/omap2plus_defconfig
>>
>> Why omap2plus_defconfig? OMAP3 and newer are all ARMv7 and
>> boards with those can/should use multi_v7_defconfig.
>>
> if there are enough drivers enabled there, it would work, but it is not.
> So there need to be a bunch of patches to add the missing stuff.
> omap2plus_defconfig is there and support for boards are added.
> 

Yes multi_v7 is still missing stuff for some boards we want to
support, and we are working on adding those needed modules now.

We won't get feature parity in multi_v7 if we keep adding new
boards to the old omap2plus_defconfig. For this patch series
how about we add support to both defconfigs?

> So I think until multi_v7_defconfig is really usable for OMAP3+, we
> should stick with the name omap2plus_defconfig and add stuff.
> If we rename omap2plus_defconfig to omap2_defconfig, we should imho
> disable OMAP3/4/5 there to avoid confusion.
> 

Yes, that was part of the plan, right now these SoCs are enabled
in both configs, so new boards often get enabled in one or the other
but rarely both.

Andrew

> Regards,
> Andreas

Re: [PATCH v2 5/5] arm: omap2plus_defconfig: Enable TPS65219 regulator

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

On Thu, Jun 12, 2025 at 08:09:59AM -0500, Andrew Davis wrote:
> On 6/12/25 1:12 AM, Andreas Kemnade wrote:

> > So there need to be a bunch of patches to add the missing stuff.
> > omap2plus_defconfig is there and support for boards are added.

> Yes multi_v7 is still missing stuff for some boards we want to
> support, and we are working on adding those needed modules now.

> We won't get feature parity in multi_v7 if we keep adding new
> boards to the old omap2plus_defconfig. For this patch series
> how about we add support to both defconfigs?

Keeping the more specific defconfigs around is handy as they're much
smaller and therefore faster to build, but I do agree that the
multi_vX_defconfigs should also work.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Andreas Kemnade]

Am Mon, 9 Jun 2025 18:34:10 -0500
schrieb Andrew Davis <afd@ti.com>:

> On 6/9/25 10:43 AM, Kory Maincent wrote:
> > Add several compatible strings that were missing from the binding
> > documentation. Add description for Bone, BoneBlack and BoneGreen
> > variants.
> > 
> > Add several compatible that were missing from the binding.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > 
> > Change in v2:
> > - New patch
> > ---
> >   Documentation/devicetree/bindings/arm/ti/omap.yaml | 38 ++++++++++++++++++++++
> >   1 file changed, 38 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > index 3603edd7361d..c43fa4f4af81 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > @@ -104,12 +104,50 @@ properties:
> >         - description: TI AM33 based platform
> >           items:
> >             - enum:
> > +              - bosch,am335x-guardian
> >                 - compulab,cm-t335
> > +              - grinn,am335x-chilisom
> > +              - gumstix,am335x-pepper
> > +              - moxa,uc-2101
> >                 - moxa,uc-8100-me-t
> > +              - myir,myc-am335x
> > +              - myir,myd-am335x
> >                 - novatech,am335x-lxm
> > +              - oct,osd3358-sm-refdesign
> > +              - tcl,am335x-sl50
> >                 - ti,am335x-bone
> >                 - ti,am335x-evm
> > +              - ti,am335x-evmsk
> > +              - ti,am335x-pocketbeagle
> > +              - ti,am335x-shc
> >                 - ti,am3359-icev2
> > +              - vscom,onrisc
> > +          - const: ti,am33xx
> > +
> > +      - description: TI bone variants based on TI AM335  
> 
> Do we really need these "bone variants" split out from the above
> list of TI AM33 based boards? We don't do that for any of the other
> boards, you get a SoC and a Board compatible, every classification
> in-between is just unneeded.
> 

We have something like this for the Pandaboards models. But
e.g. the i.MX Udoo Neo stuff which just differs in what is populated
does not have this. So I do not see a clear pattern. It could be useful
for userspace to store some board-specific configurations which might be
the same for a family of boards. So if people shout out loud that these
are needs, lets kep them.

Regards,
Andreas

Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Krzysztof Kozlowski]

On Mon, Jun 09, 2025 at 10:45:02PM GMT, Kory Maincent wrote:
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > c43fa4f4af81..774c13157caa 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@
> > > properties:
> > >        - description: TI bone green variants based on TI AM335
> > >          items:
> > >            - enum:
> > > +              - ti,am335x-bone-green-eco
> > >                - ti,am335x-bone-green-wireless
> > >            - const: ti,am335x-bone-green
> > >            - const: ti,am335x-bone  
> > 
> > Why is this hunk here?
> 
> Do you mean that the binding change should be in another patch?

Yes, as requested by checkpatch and documented in DT submitting patches.
Your question above, suggests you did not run checkpatch, so please
confirm you run it before posting new versions.

Best regards,
Krzysztof

Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

[Rob Herring]

On Tue, Jun 10, 2025 at 10:05:44AM +0200, Kory Maincent wrote:
> Le Mon, 9 Jun 2025 18:34:10 -0500,
> Andrew Davis <afd@ti.com> a écrit :
> 
> > On 6/9/25 10:43 AM, Kory Maincent wrote:
> > > Add several compatible strings that were missing from the binding
> > > documentation. Add description for Bone, BoneBlack and BoneGreen
> > > variants.
> > > 
> > > Add several compatible that were missing from the binding.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > > ---
> > > 
> > > Change in v2:
> > > - New patch
> > > ---
> > >   Documentation/devicetree/bindings/arm/ti/omap.yaml | 38
> > > ++++++++++++++++++++++ 1 file changed, 38 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > 3603edd7361d..c43fa4f4af81 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -104,12 +104,50 @@
> > > properties:
> > >         - description: TI AM33 based platform
> > >           items:
> > >             - enum:
> > > +              - bosch,am335x-guardian
> > >                 - compulab,cm-t335
> > > +              - grinn,am335x-chilisom
> > > +              - gumstix,am335x-pepper
> > > +              - moxa,uc-2101
> > >                 - moxa,uc-8100-me-t
> > > +              - myir,myc-am335x
> > > +              - myir,myd-am335x
> > >                 - novatech,am335x-lxm
> > > +              - oct,osd3358-sm-refdesign
> > > +              - tcl,am335x-sl50
> > >                 - ti,am335x-bone
> > >                 - ti,am335x-evm
> > > +              - ti,am335x-evmsk
> > > +              - ti,am335x-pocketbeagle
> > > +              - ti,am335x-shc
> > >                 - ti,am3359-icev2
> > > +              - vscom,onrisc
> > > +          - const: ti,am33xx
> > > +
> > > +      - description: TI bone variants based on TI AM335  
> > 
> > Do we really need these "bone variants" split out from the above
> > list of TI AM33 based boards? We don't do that for any of the other
> > boards, you get a SoC and a Board compatible, every classification
> > in-between is just unneeded.
> 
> As omap maintainers prefer. I did that to have the least amount of change in
> the devicetree. We could have U-boot using these compatible but after a quick
> check it seems not.

I agree with both. The intermediate compatibles that TI in particular 
went crazy on have proven to be not useful. However, between having to 
fix existing .dts files and keeping them, I would just keep them.

Rob