From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16E60C71135 for ; Thu, 12 Jun 2025 02:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FaCqKPIs2f0ylRS6bTSnQ5BqgfESWCqO1Av05E42Aq8=; b=oh0h2qXiY4GWpiF4ZPpXMztFT5 TfubKBxYsfX2QhwcSgS4YBPHnPy5TR7KPKJhpsZVrRSuEt13tjDHaCR/ocQs3uYY/5KjT3ib1u3As NyoRClb6yjV6CPIDeS9kpBjBPD7Q3wqAWhQFeyNNPMicqX+urnDPu5ZzB9RjQmRp/W3qcqp2K9jXS 9t9MLeonUMetabmmYF1dNAYFxKxpC41jxsM5t2v1AwlsPArFI8KJeeiY8WjGyjGU2v3tPQwXZGBwy TpzJceR/LoIvEBDkpSdj9TqGdGzYo7mzennZC8fAuFwhmDjiOTnDX128+kYsGOcC7bqek4crXd+/o hYCVS6+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPXsB-0000000BzQ2-1xSg; Thu, 12 Jun 2025 02:40:59 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPU9h-0000000BVbs-0Lig for linux-arm-kernel@lists.infradead.org; Wed, 11 Jun 2025 22:42:50 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-401f6513cb2so776394b6e.0 for ; Wed, 11 Jun 2025 15:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749681768; x=1750286568; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FaCqKPIs2f0ylRS6bTSnQ5BqgfESWCqO1Av05E42Aq8=; b=gmqzokRNHopwKGrsotW/mI5/IBxAOLAjxMvXP4XG5e4CDEIRVQNuPzFit7RNbzoSPO KvFbeDjwSovT6fldvy6FbD3fhQ+Atf4YG+oK8C3HUNtUKcp8SGR7uVtEm8d1rM0hIuy2 GyTG75wac2H1bS7T/hLOmcCMPsfNGTdd2bwS8X6hsqAm8hWSM60NSBuo1WoJv8UJzvTv qGtKqswW3vN3LA6cSQ/0gGRmYGTlSj/ydc6khIVR9+7uP6wBmsL76WUfKqlXpEJUuk0Y /8NK53jJvOkuFSYGeB1kow+iCaVLcYvJhMuyi3LSyokq0JkWQu/9WVzPW9IvvHh0Hkw4 /OHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749681768; x=1750286568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FaCqKPIs2f0ylRS6bTSnQ5BqgfESWCqO1Av05E42Aq8=; b=WQ0X2jHfCMJ5ZLZxkLlvTFRu2Vl8JGhdVjKrvyFturg4EBde1KomFoaL2dtPHGPZcc Ywmx9a1X9Hu//S3BgcjpZ5Lm2Q2z0E9DvNcSMbjnEqZXGFq7UdJuQB37y5ef+3eZQfwa OqS9Bss1BBXyAU3G/jnGE5yUSftmh5RQIs7bwe5nIZ9TSqlobro0COFhT212PFhnaLkz N16IuXKn+xJPXCAB+BReYjhmOQXcGZ3ThrvaXHSqRQB/4EtDVwX2sS3rmRcy0qThue7B pwdrACip1CN1bwl/+TsSNtAynUneNR4BOzhd/scGBHzt/ytloPo4gIYmpN3aJMBGX6Tz SljA== X-Forwarded-Encrypted: i=1; AJvYcCUvCp/2mF9nSPISPV8CFPXGC8B3Ke+BPLvIjpgnYHgvI4sMSf9rghwUOKDpjYYt7fKpTLLq0PHYN+QggyUJW6l7@lists.infradead.org X-Gm-Message-State: AOJu0Yxdzxc4JkFgOncJUq2WBkOFzin8YeG74EcNULn8zoQG8sHGVUfF KvGLIYnn1pCUxZXvJKV2IiKIYTIHez57LuhNJrS5ZV7Bza7TkaPG5Ef1NqZs1kJGsIg= X-Gm-Gg: ASbGncsNry5rVNBiuHPztdqQSnyc8CZL4i1g2KTLgJy6aRqC8iHJHyK87xZwqn50wG1 AjLJTtKma01t6Gehr0UYNURGpQtRNKMigu08VkZLAWksOxzwX+BWHHaSL9qZWV+SFwbnE7w9VlD bvAjoriDtI5O8cK0Vt2ug61jKd8fh9a0PvE37hAsbo1MBIA+N9TxOr+FoCjkYFbBBMNbNPqZVVW ScIx+hB6443WaQl6G56IYfUoVw0urV2QN6rP0Ff2tBIEQUB64E6oAw9q+vY0p5ER89pYkccA0tc FHiNg2qj5tTiBA7rIh7UuJv9GI508gmUZqBlWT6f9914YyZlxfdyZbny3eB6wWNbI02h X-Google-Smtp-Source: AGHT+IEqBdswhJxFab3cfPWoCt/XhvSdy8p4DMoA4oBrcj8i32O67dKlBd9w/Xt2c78Lmmmu54g1yQ== X-Received: by 2002:a05:6808:3403:b0:407:a0ea:a233 with SMTP id 5614622812f47-40a66081d10mr892925b6e.10.1749681768360; Wed, 11 Jun 2025 15:42:48 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a682fbf05sm24684b6e.32.2025.06.11.15.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 15:42:47 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 17:39:08 -0500 Subject: [PATCH 16/28] iio: imu: inv_icm42600: use = { } instead of memset() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250611-iio-zero-init-stack-with-instead-of-memset-v1-16-ebb2d0a24302@baylibre.com> References: <20250611-iio-zero-init-stack-with-instead-of-memset-v1-0-ebb2d0a24302@baylibre.com> In-Reply-To: <20250611-iio-zero-init-stack-with-instead-of-memset-v1-0-ebb2d0a24302@baylibre.com> To: Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno , Heiko Stuebner , Maxime Coquelin , Alexandre Torgue , Francesco Dolcini , =?utf-8?q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , =?utf-8?q?Leonard_G=C3=B6hrs?= , kernel@pengutronix.de, Oleksij Rempel , Roan van Dijk , Tomasz Duszynski , Jacopo Mondi , Jean-Baptiste Maneyrol , Mudit Sharma , Javier Carrasco , =?utf-8?q?Ond=C5=99ej_Jirman?= , Andreas Klinger , Petre Rodan Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2716; i=dlechner@baylibre.com; h=from:subject:message-id; bh=fAkKApzgvKKCY+4XB2hNM39jEFCTxF0PElDrgzvAlfA=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSgXt+4nZ+zbyhmjJNdPfIxZOtXs2Bk8+N21Ob xic8BlFYmWJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEoF7QAKCRDCzCAB/wGP wIUNB/48BoC8ymocKlLoNu3v5QYdcqupR0Gl4uhHgWI4Jt4Brgahbb5SfPq/3olqkbiy+T1Ookv DWyixFwL+PnlcdEYgsS3FtkBM77VlMTSo6KPDdiudRl4FOE1D8dxwHWMFTSURf17zsYwE+dDLHp YZRLNMo9fWgXqlnqEsBGDUgu2l57aaQxB6TaIlukki2lYZmsUTkPQsTN9JnX1WWTeNubNgf9d9W 0ZUaDpZW1pcDF8oQsk1+HVaB1pWPs5UwKNoW9xGgFt43NyStIN8Eb/T84MFJaOOu+ikBdQENY1a Diwzxh8L7c4dTlMajUB9DvjbZGuzAcjh6/xW+3qRtK6/KKlM X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250611_154249_123837_941F035F X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use { } instead of memset() to zero-initialize stack memory to simplify the code. Signed-off-by: David Lechner --- drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 5 ++--- drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c index e6cd9dcb0687d19554e63a69dc60f065c58d70ee..dbd315ad3c4d2bd5085f7cd3cdc6de4391b1c896 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c @@ -902,7 +902,8 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev) const int8_t *temp; unsigned int odr; int64_t ts_val; - struct inv_icm42600_accel_buffer buffer; + /* buffer is copied to userspace, zeroing it to avoid any data leak */ + struct inv_icm42600_accel_buffer buffer = { }; /* parse all fifo packets */ for (i = 0, no = 0; i < st->fifo.count; i += size, ++no) { @@ -921,8 +922,6 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev) inv_sensors_timestamp_apply_odr(ts, st->fifo.period, st->fifo.nb.total, no); - /* buffer is copied to userspace, zeroing it to avoid any data leak */ - memset(&buffer, 0, sizeof(buffer)); memcpy(&buffer.accel, accel, sizeof(buffer.accel)); /* convert 8 bits FIFO temperature in high resolution format */ buffer.temp = temp ? (*temp * 64) : 0; diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c index b4d7ce1432a4f4d096599877040a89ede0625e0b..4058eca076d8b03a2290535eedffa0a74098d739 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c @@ -806,7 +806,8 @@ int inv_icm42600_gyro_parse_fifo(struct iio_dev *indio_dev) const int8_t *temp; unsigned int odr; int64_t ts_val; - struct inv_icm42600_gyro_buffer buffer; + /* buffer is copied to userspace, zeroing it to avoid any data leak */ + struct inv_icm42600_gyro_buffer buffer = { }; /* parse all fifo packets */ for (i = 0, no = 0; i < st->fifo.count; i += size, ++no) { @@ -825,8 +826,6 @@ int inv_icm42600_gyro_parse_fifo(struct iio_dev *indio_dev) inv_sensors_timestamp_apply_odr(ts, st->fifo.period, st->fifo.nb.total, no); - /* buffer is copied to userspace, zeroing it to avoid any data leak */ - memset(&buffer, 0, sizeof(buffer)); memcpy(&buffer.gyro, gyro, sizeof(buffer.gyro)); /* convert 8 bits FIFO temperature in high resolution format */ buffer.temp = temp ? (*temp * 64) : 0; -- 2.43.0