* [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
@ 2025-06-10 19:19 Sven Peter
2025-06-11 20:48 ` Janne Grunau
2025-06-13 14:38 ` Sven Peter
0 siblings, 2 replies; 3+ messages in thread
From: Sven Peter @ 2025-06-10 19:19 UTC (permalink / raw)
To: Janne Grunau, Alyssa Rosenzweig, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel, Sven Peter
Fix the following warning by dropping #{address,size}-cells from the SPI
NOR node which only has a single child node without reg property:
spi1-nvram.dtsi:19.10-38.4: Warning (avoid_unnecessary_addr_size): /soc/spi@235104000/flash@0: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
Fixes: 3febe9de5ca5 ("arm64: dts: apple: Add SPI NOR nvram partition to all devices")
Signed-off-by: Sven Peter <sven@kernel.org>
---
arch/arm64/boot/dts/apple/spi1-nvram.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
index 3df2fd3993b52884d7c00b65099c88d830a7a4c3..9740fbf200f0bcd0e7d1b81885fe9d9ff8f04fdc 100644
--- a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
+++ b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
@@ -20,8 +20,6 @@ flash@0 {
compatible = "jedec,spi-nor";
reg = <0x0>;
spi-max-frequency = <25000000>;
- #address-cells = <1>;
- #size-cells = <1>;
partitions {
compatible = "fixed-partitions";
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250530-apple-dts-warnings-8bb373367b54
Best regards,
--
Sven Peter <sven@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
2025-06-10 19:19 [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR Sven Peter
@ 2025-06-11 20:48 ` Janne Grunau
2025-06-13 14:38 ` Sven Peter
1 sibling, 0 replies; 3+ messages in thread
From: Janne Grunau @ 2025-06-11 20:48 UTC (permalink / raw)
To: Sven Peter
Cc: Alyssa Rosenzweig, Neal Gompa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, asahi, linux-arm-kernel, devicetree, linux-kernel
On Tue, Jun 10, 2025 at 07:19:24PM +0000, Sven Peter wrote:
> Fix the following warning by dropping #{address,size}-cells from the SPI
> NOR node which only has a single child node without reg property:
>
> spi1-nvram.dtsi:19.10-38.4: Warning (avoid_unnecessary_addr_size): /soc/spi@235104000/flash@0: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
>
> Fixes: 3febe9de5ca5 ("arm64: dts: apple: Add SPI NOR nvram partition to all devices")
> Signed-off-by: Sven Peter <sven@kernel.org>
> ---
> arch/arm64/boot/dts/apple/spi1-nvram.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
> index 3df2fd3993b52884d7c00b65099c88d830a7a4c3..9740fbf200f0bcd0e7d1b81885fe9d9ff8f04fdc 100644
> --- a/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
> +++ b/arch/arm64/boot/dts/apple/spi1-nvram.dtsi
> @@ -20,8 +20,6 @@ flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-max-frequency = <25000000>;
> - #address-cells = <1>;
> - #size-cells = <1>;
>
> partitions {
> compatible = "fixed-partitions";
>
Reviewed-by: Janne Grunau <j@jannau.net>
Janne
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
2025-06-10 19:19 [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR Sven Peter
2025-06-11 20:48 ` Janne Grunau
@ 2025-06-13 14:38 ` Sven Peter
1 sibling, 0 replies; 3+ messages in thread
From: Sven Peter @ 2025-06-13 14:38 UTC (permalink / raw)
To: Janne Grunau, Alyssa Rosenzweig, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sven Peter
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel
On Tue, 10 Jun 2025 19:19:24 +0000, Sven Peter wrote:
> Fix the following warning by dropping #{address,size}-cells from the SPI
> NOR node which only has a single child node without reg property:
>
> spi1-nvram.dtsi:19.10-38.4: Warning (avoid_unnecessary_addr_size): /soc/spi@235104000/flash@0: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
>
>
Applied, thanks!
[1/1] arm64: dts: apple: Drop {address,size}-cells from SPI NOR
commit: 811a909978bf59caa25359e0aca4e30500dcff26
Best regards,
--
Sven Peter <sven@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-13 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-10 19:19 [PATCH] arm64: dts: apple: Drop {address,size}-cells from SPI NOR Sven Peter
2025-06-11 20:48 ` Janne Grunau
2025-06-13 14:38 ` Sven Peter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).