* [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts
@ 2025-06-11 15:18 Sven Peter
2025-06-11 21:49 ` Janne Grunau
2025-06-13 14:38 ` Sven Peter
0 siblings, 2 replies; 3+ messages in thread
From: Sven Peter @ 2025-06-11 15:18 UTC (permalink / raw)
To: Janne Grunau, Alyssa Rosenzweig, Neal Gompa
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sasha Finkelstein,
Nick Chan, asahi, linux-arm-kernel, devicetree, linux-kernel,
Sven Peter
Move the {address,size}-cells property from the (disabled) touchbar screen
mipi node inside the dtsi file to the model-specific dts file where it's
enabled to fix the following W=1 warnings:
t8103.dtsi:404.34-433.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@228600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
t8112.dtsi:419.34-448.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@228600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
Fixes: 7275e795e520 ("arm64: dts: apple: Add touchbar screen nodes")
Signed-off-by: Sven Peter <sven@kernel.org>
---
arch/arm64/boot/dts/apple/t8103-j293.dts | 2 ++
arch/arm64/boot/dts/apple/t8103.dtsi | 2 --
arch/arm64/boot/dts/apple/t8112-j493.dts | 2 ++
arch/arm64/boot/dts/apple/t8112.dtsi | 2 --
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
index e2d9439397f71a93c28b75a7eea589f4bcb3e374..5b3c42e9f0e6776241bf746d3458766e44e3639a 100644
--- a/arch/arm64/boot/dts/apple/t8103-j293.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
@@ -100,6 +100,8 @@ dfr_mipi_out_panel: endpoint@0 {
&displaydfr_mipi {
status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
dfr_panel: panel@0 {
compatible = "apple,j293-summit", "apple,summit";
diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
index 20faf0c0d80927b2e18dd966a61b5507b322c72f..3a204845b85befb093dd470b4280e778c2894b09 100644
--- a/arch/arm64/boot/dts/apple/t8103.dtsi
+++ b/arch/arm64/boot/dts/apple/t8103.dtsi
@@ -405,8 +405,6 @@ displaydfr_mipi: dsi@228600000 {
compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi";
reg = <0x2 0x28600000 0x0 0x100000>;
power-domains = <&ps_mipi_dsi>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
ports {
diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
index be86d34c6696cb47d31696541266e504cee8ce10..fb8ad7d4c65a8fe7966f5541f24f03a379143cfb 100644
--- a/arch/arm64/boot/dts/apple/t8112-j493.dts
+++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
@@ -63,6 +63,8 @@ dfr_mipi_out_panel: endpoint@0 {
&displaydfr_mipi {
status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
dfr_panel: panel@0 {
compatible = "apple,j493-summit", "apple,summit";
diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
index e95711d8337f6cea898e88a3d564caf2c4f94404..f68354194355807dae9b5922bb8aff74da3c29e6 100644
--- a/arch/arm64/boot/dts/apple/t8112.dtsi
+++ b/arch/arm64/boot/dts/apple/t8112.dtsi
@@ -420,8 +420,6 @@ displaydfr_mipi: dsi@228600000 {
compatible = "apple,t8112-display-pipe-mipi", "apple,h7-display-pipe-mipi";
reg = <0x2 0x28600000 0x0 0x100000>;
power-domains = <&ps_mipi_dsi>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
ports {
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250611-display-pipe-mipi-warning-6609513ae5c7
Best regards,
--
Sven Peter <sven@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts
2025-06-11 15:18 [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts Sven Peter
@ 2025-06-11 21:49 ` Janne Grunau
2025-06-13 14:38 ` Sven Peter
1 sibling, 0 replies; 3+ messages in thread
From: Janne Grunau @ 2025-06-11 21:49 UTC (permalink / raw)
To: Sven Peter
Cc: Alyssa Rosenzweig, Neal Gompa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sasha Finkelstein, Nick Chan, asahi,
linux-arm-kernel, devicetree, linux-kernel
On Wed, Jun 11, 2025 at 03:18:53PM +0000, Sven Peter wrote:
> Move the {address,size}-cells property from the (disabled) touchbar screen
> mipi node inside the dtsi file to the model-specific dts file where it's
> enabled to fix the following W=1 warnings:
>
> t8103.dtsi:404.34-433.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@228600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> t8112.dtsi:419.34-448.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@228600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
>
> Fixes: 7275e795e520 ("arm64: dts: apple: Add touchbar screen nodes")
> Signed-off-by: Sven Peter <sven@kernel.org>
> ---
> arch/arm64/boot/dts/apple/t8103-j293.dts | 2 ++
> arch/arm64/boot/dts/apple/t8103.dtsi | 2 --
> arch/arm64/boot/dts/apple/t8112-j493.dts | 2 ++
> arch/arm64/boot/dts/apple/t8112.dtsi | 2 --
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index e2d9439397f71a93c28b75a7eea589f4bcb3e374..5b3c42e9f0e6776241bf746d3458766e44e3639a 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -100,6 +100,8 @@ dfr_mipi_out_panel: endpoint@0 {
>
> &displaydfr_mipi {
> status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> dfr_panel: panel@0 {
> compatible = "apple,j293-summit", "apple,summit";
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index 20faf0c0d80927b2e18dd966a61b5507b322c72f..3a204845b85befb093dd470b4280e778c2894b09 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -405,8 +405,6 @@ displaydfr_mipi: dsi@228600000 {
> compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi";
> reg = <0x2 0x28600000 0x0 0x100000>;
> power-domains = <&ps_mipi_dsi>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
>
> ports {
> diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
> index be86d34c6696cb47d31696541266e504cee8ce10..fb8ad7d4c65a8fe7966f5541f24f03a379143cfb 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j493.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
> @@ -63,6 +63,8 @@ dfr_mipi_out_panel: endpoint@0 {
>
> &displaydfr_mipi {
> status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> dfr_panel: panel@0 {
> compatible = "apple,j493-summit", "apple,summit";
> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index e95711d8337f6cea898e88a3d564caf2c4f94404..f68354194355807dae9b5922bb8aff74da3c29e6 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
> @@ -420,8 +420,6 @@ displaydfr_mipi: dsi@228600000 {
> compatible = "apple,t8112-display-pipe-mipi", "apple,h7-display-pipe-mipi";
> reg = <0x2 0x28600000 0x0 0x100000>;
> power-domains = <&ps_mipi_dsi>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
>
> ports {
>
This looks a little odd and the two qcom devicetrees I've looked at have
the same "issue". Fixing warnings is welcome and the resulting dtbs are
unchanged.
Reviewed-by: Janne Grunau <j@jannau.net>
Janne
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts
2025-06-11 15:18 [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts Sven Peter
2025-06-11 21:49 ` Janne Grunau
@ 2025-06-13 14:38 ` Sven Peter
1 sibling, 0 replies; 3+ messages in thread
From: Sven Peter @ 2025-06-13 14:38 UTC (permalink / raw)
To: Janne Grunau, Alyssa Rosenzweig, Neal Gompa, Sven Peter
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sasha Finkelstein,
Nick Chan, asahi, linux-arm-kernel, devicetree, linux-kernel
On Wed, 11 Jun 2025 15:18:53 +0000, Sven Peter wrote:
> Move the {address,size}-cells property from the (disabled) touchbar screen
> mipi node inside the dtsi file to the model-specific dts file where it's
> enabled to fix the following W=1 warnings:
>
> t8103.dtsi:404.34-433.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@228600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> t8112.dtsi:419.34-448.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@228600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
>
> [...]
Applied, thanks!
[1/1] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts
commit: 08a0d93c353bd55de8b5fb77b464d89425be0215
Best regards,
--
Sven Peter <sven@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-13 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-11 15:18 [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts Sven Peter
2025-06-11 21:49 ` Janne Grunau
2025-06-13 14:38 ` Sven Peter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).