From: Luo Jie <quic_luoj@quicinc.com>
To: Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Julia Lawall <Julia.Lawall@inria.fr>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <cocci@inria.fr>,
<linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
<andrew@lunn.ch>, <quic_kkumarcs@quicinc.com>,
<quic_linchen@quicinc.com>, <quic_leiwei@quicinc.com>,
<quic_suruchia@quicinc.com>, <quic_pavir@quicinc.com>,
Luo Jie <quic_luoj@quicinc.com>
Subject: [PATCH v4 0/5] Add FIELD_MODIFY() helper
Date: Thu, 12 Jun 2025 21:46:07 +0800 [thread overview]
Message-ID: <20250612-field_modify-v4-0-ae4f74da45a6@quicinc.com> (raw)
Add the helper FIELD_MODIFY() to the FIELD_XXX family of bitfield
macros. It is functionally similar as xxx_replace_bits(), but adds
the compile time checking to catch incorrect parameter type errors.
This series also converts the four instances of opencoded FIELD_MODIFY()
that are found in the core kernel files, to instead use the new
FIELD_MODIFY() macro. This is achieved with Coccinelle, by adding
the script field_modify.cocci.
The changes are validated on IPQ9574 SoC which uses ARM64 architecture.
Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
Changes in v4:
- Add org, report and context mode for coccinelle script.
- Fix other comments on coccinelle script patch.
- Remove the FIELD_MODIFY patch as it is merged.
- Link to v3: https://lore.kernel.org/r/20250417-field_modify-v3-0-6f7992aafcb7@quicinc.com
Changes in v3:
- Correct the order of header files included.
- Add the Coccinelle script field_modify.cocci..
- Convert the opencoded FIELD_MODIFY() variants inside arm64 directory,
identified by field_modify.cocci.
- Link to v2: https://lore.kernel.org/all/20250410131048.2054791-1-quic_luoj@quicinc.com/
Changes in v2:
- Update the documented example for FIELD_MODIFY().
- Improve the commit message to describe the need for the change.
- Link to v1: https://lore.kernel.org/all/20250318071526.1836194-1-quic_luoj@quicinc.com/
---
Luo Jie (5):
coccinelle: misc: Add field_modify script
arm64: tlb: Convert the opencoded field modify
arm64: nvhe: Convert the opencoded field modify
arm64: kvm: Convert the opencoded field modify
arm64: mm: Convert the opencoded field modify
arch/arm64/include/asm/tlbflush.h | 3 +-
arch/arm64/kvm/hyp/include/nvhe/memory.h | 3 +-
arch/arm64/kvm/vgic/vgic-mmio-v3.c | 6 +--
arch/arm64/mm/context.c | 3 +-
scripts/coccinelle/misc/field_modify.cocci | 61 ++++++++++++++++++++++++++++++
5 files changed, 66 insertions(+), 10 deletions(-)
---
base-commit: 0bb71d301869446810a0b13d3da290bd455d7c78
change-id: 20250612-field_modify-27139f673881
Best regards,
--
Luo Jie <quic_luoj@quicinc.com>
next reply other threads:[~2025-06-12 19:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 13:46 Luo Jie [this message]
2025-06-12 13:46 ` [PATCH v4 1/5] coccinelle: misc: Add field_modify script Luo Jie
2025-06-12 16:48 ` [cocci] " Markus Elfring
2025-06-16 10:28 ` Luo Jie
2025-06-12 13:46 ` [PATCH v4 2/5] arm64: tlb: Convert the opencoded field modify Luo Jie
2025-06-12 20:15 ` [cocci] " Markus Elfring
2025-06-16 10:37 ` Luo Jie
2025-06-16 10:41 ` Will Deacon
2025-06-16 16:19 ` Luo Jie
2025-06-16 13:52 ` [cocci] [v4 " Markus Elfring
2025-06-16 16:19 ` Luo Jie
2025-06-12 13:46 ` [PATCH v4 3/5] arm64: nvhe: " Luo Jie
2025-06-12 13:46 ` [PATCH v4 4/5] arm64: kvm: " Luo Jie
2025-06-12 13:46 ` [PATCH v4 5/5] arm64: mm: " Luo Jie
2025-06-12 14:11 ` [PATCH v4 0/5] Add FIELD_MODIFY() helper Marc Zyngier
2025-06-16 10:06 ` Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612-field_modify-v4-0-ae4f74da45a6@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=Julia.Lawall@inria.fr \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=cocci@inria.fr \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maz@kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=oliver.upton@linux.dev \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).