Re: [PATCH net-next] net: ti: icssg-prueth: Read firmware-names from device tree

Jakub Kicinski
2025-06-12T19:43:19Z

On Thu, 12 Jun 2025 10:49:17 +0530 MD Danish Anwar wrote:
> > You seem to be deleting the old constants. Is there no need to keep
> > backward compatibility with DT blobs which don't have the firmware-name
> > properties ?
>
> ICSSG-PRUETH driver is only supported by AM65x and AM64x and both the
> DTs have the firmware name property. So I don't think there is any need
> to maintain the older hard coded values.
>
> AM65x -
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso#n28:~:text=pru2_1%3E%2C%20%3C%26rtu2_1%3E%2C%20%3C%26tx_pru2_1%3E%3B-,firmware%2Dname,-%3D%20%22ti%2Dpruss/am65x
>
> AM64x -
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/arch/arm64/boot/dts/ti/k3-am642-evm.dts#:~:text=tx_pru1_1%3E%3B-,firmware%2Dname,-%3D%20%22ti%2Dpruss
>
> Let me know if this is okay.

IDK much about embedded but what you say sounds convincing to me :)
Just also add that paragraph to the commit msg? (without the links)