Re: [PATCH v2 03/17] dmaengine: ti: k3-udma: move static inline helper functions to header file

Adivi, Sai Sree Kartheek
2025-06-18T08:14:11Z

Hi Siddharth,

On 6/12/2025 4:35 PM, Siddharth Vadapalli wrote:
> On Thu, Jun 12, 2025 at 12:45:07PM +0530, Sai Sree Kartheek Adivi wrote:
>> Move static inline helper functions in k3-udma.c to k3-udma.h header
>> file for better separation and re-use.
>>
>> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
>> ---
>> drivers/dma/ti/k3-udma.c | 108 --------------------------------------
>> drivers/dma/ti/k3-udma.h | 109 +++++++++++++++++++++++++++++++++++++++
>
> Since this patch and the previous two patches seem to have the same
> objective of moving contents from "k3-udma.c" to "k3-udma.h" for the
> purpose of re-use, could they be squashed?

I split them up to make the changes easier to review, bisect or revert
if needed. They're logically distinct changes even if the overall goal
is similar.

If there's a strong preference to squash them, I can do that but I'd
prefer keeping them separate.

>
> Regards,
> Siddharth.