From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Pritam Manohar Sutar <pritam.sutar@samsung.com>,
vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
alim.akhtar@samsung.com, andre.draszik@linaro.org,
peter.griffin@linaro.org, kauschluss@disroot.org,
ivo.ivanov.ivanov1@gmail.com, m.szyprowski@samsung.com,
s.nawrocki@samsung.com, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com,
dev.tailor@samsung.com, faraz.ata@samsung.com,
muhammed.ali@samsung.com, selvarasu.g@samsung.com
Subject: Re: [PATCH v3 9/9] arm64: dts: exynos: ExynosAutov920: add USB and USB SS combo phy nodes
Date: Mon, 16 Jun 2025 10:09:10 +0200 [thread overview]
Message-ID: <20250616-perfect-fervent-robin-a1bc3c@kuoka> (raw)
In-Reply-To: <9455a4e1-6352-4832-ac9f-2816f889c3a4@linaro.org>
On Fri, Jun 13, 2025 at 11:12:26AM GMT, neil.armstrong@linaro.org wrote:
> On 13/06/2025 07:56, Pritam Manohar Sutar wrote:
> > usbdrd31_hsphy: phy@16490000 {
> > compatible = "samsung,exynosautov920-usbdrd-hsphy";
> > reg = <0x16490000 0x0200>;
> > @@ -1109,8 +1120,8 @@ usbdrd31_dwc3: usb@0 {
> > <&cmu_hsi1 CLK_MOUT_HSI1_USBDRD>;
> > clock-names = "ref", "susp_clk";
> > interrupts = <GIC_SPI 491 IRQ_TYPE_LEVEL_HIGH>;
> > - phys = <&usbdrd31_hsphy 0>;
> > - phy-names = "usb2-phy";
> > + phys = <&usbdrd31_hsphy 0>, <&usbdrd31_ssphy 0>;
> > + phy-names = "usb2-phy", "usb3-phy";
> > snps,has-lpm-erratum;
> > snps,dis_u2_susphy_quirk;
> > snps,dis_u3_susphy_quirk;
>
> I think at least patch 6 & 9 should be squashed.
Yes. Changing lines which were just added is a strong hint, that
patchset is incorrectly organized.
>
> Neil
next prev parent reply other threads:[~2025-06-16 8:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250613055037epcas5p1ce00fda1b535dbeb9a98458d1f0a28ee@epcas5p1.samsung.com>
2025-06-13 5:56 ` [PATCH v3 0/9] initial usbdrd phy support for Exynosautov920 soc Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 1/9] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible Pritam Manohar Sutar
2025-06-16 8:12 ` Krzysztof Kozlowski
2025-06-16 8:15 ` Krzysztof Kozlowski
2025-06-17 17:52 ` Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 2/9] phy: exyons5-usbdrd: support HS phy for ExynosAutov920 Pritam Manohar Sutar
2025-06-13 9:09 ` neil.armstrong
2025-06-16 8:12 ` Krzysztof Kozlowski
2025-06-17 17:36 ` Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 3/9] arm64: dts: exynos: ExynosAutov920: add USB and USB-phy nodes Pritam Manohar Sutar
2025-06-16 8:13 ` Krzysztof Kozlowski
2025-06-17 17:49 ` Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 4/9] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo HS phy Pritam Manohar Sutar
2025-06-16 8:15 ` Krzysztof Kozlowski
2025-06-17 18:04 ` Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 5/9] phy: exyons5-usbdrd: support HS combo phy for ExynosAutov920 Pritam Manohar Sutar
2025-06-13 9:11 ` neil.armstrong
2025-06-16 8:17 ` Krzysztof Kozlowski
2025-06-17 18:14 ` Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 6/9] arm64: dts: exynos: ExynosAutov920: add USB and USB HS combo phy nodes Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 7/9] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo SS phy Pritam Manohar Sutar
2025-06-13 5:56 ` [PATCH v3 8/9] phy: exyons5-usbdrd: support SS combo phy for ExynosAutov920 Pritam Manohar Sutar
2025-06-13 9:11 ` neil.armstrong
2025-06-13 5:56 ` [PATCH v3 9/9] arm64: dts: exynos: ExynosAutov920: add USB and USB SS combo phy nodes Pritam Manohar Sutar
2025-06-13 9:12 ` neil.armstrong
2025-06-16 8:09 ` Krzysztof Kozlowski [this message]
2025-06-17 17:24 ` Pritam Manohar Sutar
2025-06-17 17:10 ` Pritam Manohar Sutar
2025-06-16 21:46 ` [PATCH v3 0/9] initial usbdrd phy support for Exynosautov920 soc Rob Herring (Arm)
2025-06-17 18:20 ` Pritam Manohar Sutar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616-perfect-fervent-robin-a1bc3c@kuoka \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=kauschluss@disroot.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=muhammed.ali@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=pritam.sutar@samsung.com \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=selvarasu.g@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox