From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F7FFC71136 for ; Tue, 17 Jun 2025 13:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bMoUi4cuL4Udgs4T48YUDRqAwuLLsrWE2yiMKniBN8Q=; b=TYmc1kfU9gJxRY2qnTP96DKgHE CGAWkdri82RuMi+EiruJ7SFwNvYgdlcJufh5xkmUszaLjXxRrJUqQ2xcXEp1p+Gm67W3j/ZUjmsw1 87sA33IIzX8bbompn3Xj4jQKnVBA0e21pe/S+1J7bsS4GWXRCNEJzzG/JvP/vdb8jUXVdcdze6/Ro i55eAhGiWp3bko6ro/8Av7Pg86RXwGjSVmqil7HDnl+MHIbgNAUHUwLlFDF50xnyPeOOPruQGJzhY Iw7Es7TG+MpnQ0+1RJB0OFFKesLTixFMkRq3fc8/BK9vJq0WVZ5LpZMKIxMnmEjyMlRDUXo52b7gR pYu5ZlDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRWSx-00000007NO5-44kh; Tue, 17 Jun 2025 13:35:07 +0000 Received: from fllvem-ot04.ext.ti.com ([198.47.19.246]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRVzl-00000007HOr-0l4K for linux-arm-kernel@lists.infradead.org; Tue, 17 Jun 2025 13:04:58 +0000 Received: from lelvem-sh02.itg.ti.com ([10.180.78.226]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 55HD4OSn014423; Tue, 17 Jun 2025 08:04:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1750165464; bh=bMoUi4cuL4Udgs4T48YUDRqAwuLLsrWE2yiMKniBN8Q=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=iOPUzq/Wv/zVI915DrZDgofpMJTW9L4QqExXTyKz1FejMUYdWg4LQ/AHhrXt7ypdb ktgvBsoWBF5nZCatCoTKHFpjX0J0tzQU3MKo2tEH9srz0Ss8BC2Y2Hw36TNwC8Qor/ nscAi77V/8rxjryCvbG/6ddP6GJoiuDrQEZc7Alk= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelvem-sh02.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 55HD4OA53625511 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 17 Jun 2025 08:04:24 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 17 Jun 2025 08:04:24 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 17 Jun 2025 08:04:23 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 55HD4O6R1941963; Tue, 17 Jun 2025 08:04:24 -0500 Date: Tue, 17 Jun 2025 08:04:23 -0500 From: Nishanth Menon To: "Jiri Slaby (SUSE)" CC: , , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Maxime Coquelin , Alexandre Torgue , Tero Kristo , Santosh Shilimkar , , , Subject: Re: [PATCH] irqchip: Use dev_fwnode() Message-ID: <20250617130423.nrqcprlpdxdmddbo@truck> References: <20250611104348.192092-1-jirislaby@kernel.org> <20250611104348.192092-10-jirislaby@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250611104348.192092-10-jirislaby@kernel.org> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250617_060457_477188_E34E0AE9 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:43-20250611, Jiri Slaby (SUSE) wrote: > irq_domain_create_simple() takes fwnode as the first argument. It can be > extracted from the struct device using dev_fwnode() helper instead of > using of_node with of_fwnode_handle(). > > So use the dev_fwnode() helper. > > Signed-off-by: Jiri Slaby (SUSE) > Cc: Thomas Gleixner > > --- > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Sebastian Hesselbarth > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Nishanth Menon > Cc: Tero Kristo > Cc: Santosh Shilimkar > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > --- > drivers/irqchip/irq-imgpdc.c | 2 +- > drivers/irqchip/irq-imx-irqsteer.c | 2 +- > drivers/irqchip/irq-keystone.c | 4 ++-- > drivers/irqchip/irq-mvebu-pic.c | 2 +- > drivers/irqchip/irq-pruss-intc.c | 2 +- > drivers/irqchip/irq-renesas-intc-irqpin.c | 6 ++---- > drivers/irqchip/irq-renesas-irqc.c | 2 +- > drivers/irqchip/irq-renesas-rza1.c | 5 ++--- > drivers/irqchip/irq-renesas-rzg2l.c | 5 ++--- > drivers/irqchip/irq-renesas-rzv2h.c | 2 +- > drivers/irqchip/irq-stm32mp-exti.c | 4 +--- > drivers/irqchip/irq-ti-sci-inta.c | 3 +-- > drivers/irqchip/irq-ti-sci-intr.c | 3 +-- > drivers/irqchip/irq-ts4800.c | 2 +- > 14 files changed, 18 insertions(+), 26 deletions(-) > [..] > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index 7de59238e6b0..01963d36cfaf 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -701,8 +701,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev) > if (ret) > return ret; > > - domain = irq_domain_create_linear(of_fwnode_handle(dev_of_node(dev)), > - ti_sci_get_num_resources(inta->vint), > + domain = irq_domain_create_linear(dev_fwnode(dev), ti_sci_get_num_resources(inta->vint), > &ti_sci_inta_irq_domain_ops, inta); > if (!domain) { > dev_err(dev, "Failed to allocate IRQ domain\n"); > diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c > index 07fff5ae5ce0..354613e74ad0 100644 > --- a/drivers/irqchip/irq-ti-sci-intr.c > +++ b/drivers/irqchip/irq-ti-sci-intr.c > @@ -274,8 +274,7 @@ static int ti_sci_intr_irq_domain_probe(struct platform_device *pdev) > return PTR_ERR(intr->out_irqs); > } > > - domain = irq_domain_create_hierarchy(parent_domain, 0, 0, > - of_fwnode_handle(dev_of_node(dev)), > + domain = irq_domain_create_hierarchy(parent_domain, 0, 0, dev_fwnode(dev), > &ti_sci_intr_irq_domain_ops, intr); > if (!domain) { > dev_err(dev, "Failed to allocate IRQ domain\n"); [..] For the ti-sci irqchip drivers: Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D