From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B11DEC7115E for ; Thu, 19 Jun 2025 08:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=DlVzHKouOZ+Nft9/Crwi+7ddsd J4X1b371DmPzg3SfXYLoFtiStNW6N1KpJCYP7xRkWLHBrU6ZmX+YCzXrIrGDlZKa8N6BoTiay/KgW qRWnHHlvQ3Qav/rXwA7Y0AAGP900RTf5n+Oo+RV4GcQUnakjV223R9T4jH3+Jp47BPLyKekkBU0us UgQkWP++Mav3YgdE5MJG2apJEPpMPGrTP9IiiedOq6LkESmtCYCJTgQO9UrVzsIULsT1EA0MwniNb aaDRMyPOxuL5VMfttARfeEFrvGa7jTExtWWMiunNZHhBwFJMNuZ0yxsax8KNNRa0iFSKE/OwlO4qh b8aqz9GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSB14-0000000CVLH-1ijI; Thu, 19 Jun 2025 08:53:02 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSAi9-0000000CRGR-1MzN for linux-arm-kernel@lists.infradead.org; Thu, 19 Jun 2025 08:33:30 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3a52874d593so525600f8f.0 for ; Thu, 19 Jun 2025 01:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322008; x=1750926808; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=vv3oyMY9QwcJrnniYpQUoyAN15OK4TZZkVFgKN7XljaQ92IlU14KxJ183KMvTKEIDc 6RtqQ0OmQDjqyshSSkNNwTZHAe6w7lXFFLnQhFU7rR/7pofu1dHoHpjz0lyYv0TXN92h trKnNgeSsL1Y/FjHk22HAxNbZCj7gftO5JMvXIIfWIkx1ErNYZWCZjAltDceGRmEgmWS w1j3rr+6MVwHdGZT8dp26l9w9xVgwFcpxMx/Mrn1SffWJSzES6Fda1OGgJSFg0cm5gNN +boLNNkm9E772nWePYJdlQg6njHK8C4TWRmP6GU+UmrGOrC6kFWHZTvgdwMFMkC8ANQg 1gLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322008; x=1750926808; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=WmStp2RV1nrecb903q1Ans60PEEYU5Z5Kvb5kMG43seaA6n2hUfIQQAudIDJWMMT7Y WFaOIaufcDnbAkNUxJgFl3bl4QZ1z6NO54zd6kmgBZQjTJ9lgIzaVsM8CsXJeLj6vPTc AYSq9yMLalcwkNpbeqS0Zf8FuELPj/FWPFdYk5G3oa6sjH4n5n3qdb68Jrr3FYzx7nyz s5QnzJt0P2s/2k8Ix/qc2wYXIlRYM011PS6iv8mKOrVskKcaUyv6/JewqQKhg5nmCgOb ANrkTSBsBd2LLu6+pHCvfW6rIt5Wp+shjKxfaTbdS3l9tC8+tCZjtnlt5sANHaBkVo9+ XJug== X-Forwarded-Encrypted: i=1; AJvYcCVXl0Goo6khTxj95NSRWVrg/LXevNb1jujBYcQ6pVRC7fMORP8TGmaMKlTMJNDqYU39qeYUGOgYFfJXyRqihf0D@lists.infradead.org X-Gm-Message-State: AOJu0Yy3qTs6DGfvBxDxXu5E4UHbtpzLsOraMxL7X6vs0z+raaWONL++ X6pPCCp1MTLLdaW3M0PnwRxbXifChJjhw6FfZWSrAhP2hd6B/pZ7VyC5o7WRZVqnGRY= X-Gm-Gg: ASbGncudW+uJqVCki7G4IW1QsiCUEfBHe4XwsacaHSZiKwLfNJ7/4Tfx0Tc0W1C2FHL 7I7X7gcEyk5gFEYN3QoX+qMbhMRwlHva3zb4u4WaPHzRF1LjDIS1CHdXQegikl0CIrbKz0quEbq IsUR2LuAfqsB0L1Zn4SaXcFuLTncIEwjzi1WndhvH36hofSxja7rrcfjimdBvHVoFxU99v68WqY LDDkPM/j05PCbPz+R1depQml3YVCXm0Mgf6+CQ2VVOuEuTql6Mwm0UnOVgA+gtZuIausn0+/QYD NaK0/sek0e+q4clrSZCqyaknypSTWnxxXGhCeVAKr6B6KWH6Eno2fGoO X-Google-Smtp-Source: AGHT+IHe4d+B/hxUOK2bnJFDnHeb97EwrHtnkLvTycjD/SAz+yoFSaaQYQmyOZJ3t+SenurZC+RZOA== X-Received: by 2002:a5d:64c2:0:b0:3a4:e6c6:b8bf with SMTP id ffacd0b85a97d-3a572e562abmr17981536f8f.52.1750322007770; Thu, 19 Jun 2025 01:33:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:26 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:15 +0200 Subject: [PATCH v2 02/12] gpio: pcf857x: use new GPIO line value setter callbacks MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250619-gpiochip-set-rv-gpio-v2-2-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2108; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=UjdVhHBdj/MT105x/Q2pFxBb2AP6k98PFv96j+C3ycI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tRUaVjYB8TCH13E8mcMXqkCPZfRtBR4qqWH /WUoQsvQ8iJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUQAKCRARpy6gFHHX coGSEACHErXifEnqqKpybQk8gmcrD11FOI6ZnQC3xR1I1k7gBjHsTrsAjYbi1LE8fZKHMWwo0/k lnk2USAJIOjDaSZNWlaynNQIEUCVwXFmrWv59D2ceVNX+veJh+sri3z66LQYoKQu1Ay9Vno4ujR VqBQm3VrVuWWhfTqPgaHS0nk9tAd1ABJZBTnpfvvG8JQVLmkW6HRnuIdmSpjFZb9XdQyZS4rNhz I3C4BGnGt0/X5kBcVbQcYJCRZw4A4iHOXR+U/BWhAsULDAiSSNISKyziUj/v9zOUi1qEQYqGXer WtKHJgZbLTB/DTZF+KEPI7MU2cDMDO5qfMzLCHqmLwZmdbCM5m/LAAjJ1281UDkrQbuThv883ow 9AppTsR/koSlX8YaZX09dkZW3HE9U8YRRAZmV7xkMCG67CW7l2K/viC6O+umZlgTwFN0YWjpKxN EKEJeL4rZrJqT41/WsCmnPE3e7xoZIEDNf1viV2O2QgapMzLmKLhCbZL3tAgVGRGaGvJFPE75I6 nfyEebW2KfZU1XPbwL84kSd2+iAXvmOMmj23Z/rpcsmFPXZqHelBfIra2Ei4bs2JEXaMmxHxjbI W+rgA+Y+lzcjQyj45sI19sIvRzuPUr3OyAdpVYyiXD6DISVH0BUL86iT7yIkuoReDqqdohECXIL d7uhlxLNix+8Agw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250619_013329_357578_527CF2EF X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pcf857x.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c index 2e5f5d7f886598318b753304e7e0efca54ff8b69..a042036803336439d8e164fcfbd0263b0e84f3a4 100644 --- a/drivers/gpio/gpio-pcf857x.c +++ b/drivers/gpio/gpio-pcf857x.c @@ -171,21 +171,24 @@ static int pcf857x_output(struct gpio_chip *chip, unsigned int offset, int value return status; } -static void pcf857x_set(struct gpio_chip *chip, unsigned int offset, int value) +static int pcf857x_set(struct gpio_chip *chip, unsigned int offset, int value) { - pcf857x_output(chip, offset, value); + return pcf857x_output(chip, offset, value); } -static void pcf857x_set_multiple(struct gpio_chip *chip, unsigned long *mask, - unsigned long *bits) +static int pcf857x_set_multiple(struct gpio_chip *chip, unsigned long *mask, + unsigned long *bits) { struct pcf857x *gpio = gpiochip_get_data(chip); + int status; mutex_lock(&gpio->lock); gpio->out &= ~*mask; gpio->out |= *bits & *mask; - gpio->write(gpio->client, gpio->out); + status = gpio->write(gpio->client, gpio->out); mutex_unlock(&gpio->lock); + + return status; } /*-------------------------------------------------------------------------*/ @@ -292,8 +295,8 @@ static int pcf857x_probe(struct i2c_client *client) gpio->chip.owner = THIS_MODULE; gpio->chip.get = pcf857x_get; gpio->chip.get_multiple = pcf857x_get_multiple; - gpio->chip.set = pcf857x_set; - gpio->chip.set_multiple = pcf857x_set_multiple; + gpio->chip.set_rv = pcf857x_set; + gpio->chip.set_multiple_rv = pcf857x_set_multiple; gpio->chip.direction_input = pcf857x_input; gpio->chip.direction_output = pcf857x_output; gpio->chip.ngpio = (uintptr_t)i2c_get_match_data(client); -- 2.48.1