From: Frank Wunderlich <linux@fw-web.de>
To: Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Frank Wunderlich <frank-w@public-files.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Simon Horman <horms@kernel.org>,
Daniel Golle <daniel@makrotopia.org>,
arinc.unal@arinc9.com
Subject: [net-next v6 0/4] rework IRQ handling in mtk_eth_soc
Date: Thu, 19 Jun 2025 15:21:20 +0200 [thread overview]
Message-ID: <20250619132125.78368-1-linux@fw-web.de> (raw)
From: Frank Wunderlich <frank-w@public-files.de>
This series introduces named IRQs while keeping the index based way
for older dts.
Further it makes some cleanup like adding consts for index access and
avoids loading first IRQ which was not used on non SHARED_INT SoCs.
changes:
v6:
- change irq names from tx/rx to fe1/fe2 because reserved irqs
are usable and not bound to specific function
- dropped Simons RB because of this
- updated description of patch "skip first IRQ if not used" and
use MTK_FE_IRQ_SHARED instead of 0 in condition too
- add "only use legacy mode on missing IRQ name" patch
v5:
- fixed typo in patch 1
- moved comments from previous patch #3 to patch #1 with changes suggested by simon
- rename consts to be compatible with upcoming RSS/LRO changes
MTK_ETH_IRQ_SHARED => MTK_FE_IRQ_SHARED
MTK_ETH_IRQ_TX => MTK_FE_IRQ_TX
MTK_ETH_IRQ_RX => MTK_FE_IRQ_RX
MTK_ETH_IRQ_MAX => MTK_FE_IRQ_NUM
- change commit title and description in patch 3
v4:
- calculate max from last (rx) irq index and use it for array size too
- drop >2 condition as max is already 2 and drop the else continue
- update comment to explain which IRQs are taken in legacy way
v3:
added patches
- #2 (add constants for irq index)
- #3 (skip first IRQ on ! MTK_SHARED_INT)
to the v2 non-series patch
https://patchwork.kernel.org/project/netdevbpf/patch/20250615084521.32329-1-linux@fw-web.de/
Tested on BPI-R4/mt7988 with IRQ names and BPI-R2/mt7623 and BPI-R3/mt7986 with upstreamed
dts via index-mode.
I do not have any MTK_SHARED_INT (mt7621/mt7628) boards to testing.
Frank Wunderlich (4):
net: ethernet: mtk_eth_soc: support named IRQs
net: ethernet: mtk_eth_soc: add consts for irq index
net: ethernet: mtk_eth_soc: skip first IRQ if not used
net: ethernet: mtk_eth_soc: only use legacy mode on missing IRQ name
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 69 ++++++++++++++++-----
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 7 ++-
2 files changed, 58 insertions(+), 18 deletions(-)
--
2.43.0
next reply other threads:[~2025-06-19 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 13:21 Frank Wunderlich [this message]
2025-06-19 13:21 ` [net-next v6 1/4] net: ethernet: mtk_eth_soc: support named IRQs Frank Wunderlich
2025-06-20 20:12 ` Simon Horman
2025-06-19 13:21 ` [net-next v6 2/4] net: ethernet: mtk_eth_soc: add consts for irq index Frank Wunderlich
2025-06-19 13:21 ` [net-next v6 3/4] net: ethernet: mtk_eth_soc: skip first IRQ if not used Frank Wunderlich
2025-06-19 13:21 ` [net-next v6 4/4] net: ethernet: mtk_eth_soc: only use legacy mode on missing IRQ name Frank Wunderlich
2025-06-20 20:05 ` Simon Horman
2025-06-24 1:20 ` [net-next v6 0/4] rework IRQ handling in mtk_eth_soc patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619132125.78368-1-linux@fw-web.de \
--to=linux@fw-web.de \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).