From: Peng Fan <peng.fan@oss.nxp.com>
To: Philip Radford <philip.radford@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
sudeep.holla@arm.com, cristian.marussi@arm.com,
luke.parkin@arm.com
Subject: Re: [PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace
Date: Fri, 20 Jun 2025 16:46:34 +0800 [thread overview]
Message-ID: <20250620084634.GB27519@nxa18884-linux> (raw)
In-Reply-To: <20250619122004.3705976-1-philip.radford@arm.com>
On Thu, Jun 19, 2025 at 12:20:00PM +0000, Philip Radford wrote:
>Hi all,
>
>This series adds a new counter to the Arm SCMI firmware driver to track
>the number of in-flight message transfers during debug and trace. This
>will be useful for examining behaviour under a large load with regards
>to concurrent messages being sent and received. As the counter only gives
>a live value, printing the value in trace allows logging of the in-flight
>xfers.
Just a general question, is this counter count in flight messages
for a scmi instance or it is per transport? I ask because
one scmi instance could have multiple mailboxes. If counting based
on scmi instance, it may not be that accurate.
Thanks,
Peng
>
>The series is divided into four small patches:
>Patch [1/4]
> - Adds a fuction to decrement debug counters, similar to the existing
> counter to increment debug counters
>Patch [2/4]
> - Adds a new xfers_inflight debug counter to track active transfers
>Patch [3/4]
> - Enhances two tracepoints (scmi_xfer_begin and scmi_xfer_end) to
> include the number of in-flight transfers, setting default values
> of 0
>Patch [4/4]
> - Adds a function (scmi_inflight_count) that retrieves the current
> in-flight count for use in tracing
>
>Based on v6.16-rc2
>
>Regards,
>Phil
>
>Philip Radford (4):
> firmware: arm_scmi: Add debug decrement counter
> firmware: arm_scmi: Add xfer_inflight counter
> include: trace: Add inflight_xfer counter tracepoint
> firmware: arm_scmi: Add new inflight tracing functionality
>
> drivers/firmware/arm_scmi/common.h | 8 ++++++++
> drivers/firmware/arm_scmi/driver.c | 28 ++++++++++++++++++++++++++--
> drivers/firmware/arm_scmi/raw_mode.c | 6 ++++--
> include/trace/events/scmi.h | 24 ++++++++++++++----------
> 4 files changed, 52 insertions(+), 14 deletions(-)
>
>--
>2.25.1
>
next prev parent reply other threads:[~2025-06-20 7:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 12:20 [PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace Philip Radford
2025-06-19 12:20 ` [PATCH 1/4] firmware: arm_scmi: Add debug decrement counter Philip Radford
2025-06-19 14:32 ` Dan Carpenter
2025-06-26 11:10 ` Cristian Marussi
2025-06-19 12:20 ` [PATCH 2/4] firmware: arm_scmi: Add xfer_inflight counter Philip Radford
2025-06-26 11:15 ` Cristian Marussi
2025-06-19 12:20 ` [PATCH 3/4] include: trace: Add inflight_xfer counter tracepoint Philip Radford
2025-06-19 12:20 ` [PATCH 4/4] firmware: arm_scmi: Add new inflight tracing functionality Philip Radford
2025-06-19 14:37 ` Dan Carpenter
2025-06-26 11:17 ` Cristian Marussi
2025-06-20 8:46 ` Peng Fan [this message]
2025-06-20 9:27 ` [PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace Philip Radford
2025-06-24 4:22 ` Peng Fan
2025-06-26 11:37 ` Cristian Marussi
2025-06-30 2:00 ` Peng Fan
2025-06-26 11:18 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620084634.GB27519@nxa18884-linux \
--to=peng.fan@oss.nxp.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.parkin@arm.com \
--cc=philip.radford@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox