From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B917C77B7F for ; Tue, 24 Jun 2025 22:44:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v7M9kkIPbnh/oS2WYgoA/uL9BgJMPVXdHT1CB9dd2lY=; b=PDUKaPVJ7X42HWkmu8RVKON4sA rUCCiriLjGDCtaPLHlH45byJ+2DfAa+ULLov61xwbqMha02GxtXyTFlhYCfTrC8mjhWXjmFAjdImK 86eMWBfAeYaDNOXLGFrW2XTcZaKlgezXksPOGbcUESWSdPByQyFr5jmCKidBpBS4cWfLoziv4cmT7 P8dHshPONVrLpAWEKO05v5mSLZOF9SrH3Ff9vvV0dbQ9d/YQoeVKFX6Vu8nBlrECDILsHuow1lKqj GsOt/KmwHvDg6TZC9cCyPO6hQMDdh268MvZo75tl7CPfSYGe5s+OKDHitjNDTLPYeLXAUgx6yPSrm pyc/VQGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUCN5-000000070u0-1bMc; Tue, 24 Jun 2025 22:44:07 +0000 Received: from mx.denx.de ([89.58.32.78]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUB6Q-00000006rlo-1QUf for linux-arm-kernel@lists.infradead.org; Tue, 24 Jun 2025 21:22:51 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 36229102779C2; Tue, 24 Jun 2025 23:22:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=mx-20241105; t=1750800167; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=v7M9kkIPbnh/oS2WYgoA/uL9BgJMPVXdHT1CB9dd2lY=; b=GqOUvYk7TRdIkVJDpPiZDuKGtqtlMRl2kkdo7d/15nVe1UhvWsvIhXn0XtMPgnB9m8HrPH lXgSUa/HEMsYm0XJo2z0VZSaZtb/ne+sUx0MkOtfrjGAVT2JxRriHvx0A+8nn3USZgT3DT 9/uSg6TBp8ogoeixA+5p0hP1DgLParzBkQtgapXsA+BBjb8j9bRec6Wp0G/dN6yiae/CpZ iYzV4am/wTeAPwsso4A+QHdafNKLn7x3gBxINxC0HBq5htbOgfjFfD8WiboATxxq7vEpfI rXj/pgnC656VMAQ8GpXG8D5ekRo8b/za4uJ1zzzkYGvvkOoWx6bm6PNw9IQLVw== Date: Tue, 24 Jun 2025 23:22:42 +0200 From: Lukasz Majewski To: Paolo Abeni Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Cochran , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Simon Horman , Andrew Lunn Subject: Re: [net-next v13 04/11] net: mtip: The L2 switch driver for imx287 Message-ID: <20250624232242.3448f562@wsk> In-Reply-To: <17f789c6-cf64-4940-ac7b-0107b7b96031@redhat.com> References: <20250622093756.2895000-1-lukma@denx.de> <20250622093756.2895000-5-lukma@denx.de> <17f789c6-cf64-4940-ac7b-0107b7b96031@redhat.com> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_//EaqhMPzixC8PHpwvxTq/F2"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250624_142250_532412_9259324E X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --Sig_//EaqhMPzixC8PHpwvxTq/F2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Paolo, > On 6/22/25 11:37 AM, Lukasz Majewski wrote: > > +static void mtip_adjust_link(struct net_device *dev) > > +{ > > + struct mtip_ndev_priv *priv =3D netdev_priv(dev); > > + struct switch_enet_private *fep =3D priv->fep; > > + struct phy_device *phy_dev; > > + int status_change =3D 0, idx; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&fep->hw_lock, flags); =20 >=20 > The above kind of lock look incorrect. In later patch you use > spin_lock_bh(), and the context here is never irq. >=20 > Should be spin_lock_bh() Thanks for spotting. I've changed it. >=20 > /P >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_//EaqhMPzixC8PHpwvxTq/F2 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmhbFyIACgkQAR8vZIA0 zr3xWggAzTnSLZzTWSc88/uiBjWC76JrODXHyufYi/Zi5poA968/HtfY2nMHkXks 1LOlDCRdmC2uRuMoaTqiET752MWjddsQKLhXZkw6D8JVm79cbQEibtyFrnQZtRMe n3EioNBNQyM6HXi/eF5U3P7tDSpVi4XJQgfJ60cQdTJx0ddbmSKcgVNgZOuAbi+a 6kppME91cWcsbaw6hP/v9JcZ8dy8UEIGQtyLnAzezD9xVZUnJosy68HMTQcutXqQ NnAVV0lmAerViHBV2nNufEGEklk9ZjDZknm0bEat2Ymex9JtWmhCziYm9r097bAP z+A9f8Mkm5P8N0FOqOdMd5RyeT8Eww== =5WA7 -----END PGP SIGNATURE----- --Sig_//EaqhMPzixC8PHpwvxTq/F2--