From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0BF0C7EE2A for ; Wed, 25 Jun 2025 22:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ylR3k2y7+4LIBfXUWA/QuAF6NOSRbJi4lKR7STfDHNI=; b=FpSl4AfjqYF9oh8y5/XGc6GB3e zzp9pG/xaYADgjlQcoJm+NrM4eYRUovClmSe3L4M5t3CR/b3U6JMTUIbXEC+G0RcQ40PwZxu54C71 xs+a5Hzl5dH0SDevZR9zLV3+55fcGApM0q8Ec8UmcV2hHrQ6YCGmlIRmt3CqBZEsSI/PKrWfmwH34 RIqfiG1SeU26q50yNcME2w8jHxrVEk7OZS0x1OVKX/ra6oWEUwZSvDPai38wL9djZR4Ldkp2caDdt B8RgrNodfIf6YFZU1krcnM0nzi2TjVGTq5tvoBaXPnLEmVag6X/dhvwU4ynfu24c10ysIu0Te3PxM +kzhTyFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUYkJ-0000000A5DX-0eDk; Wed, 25 Jun 2025 22:37:35 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUWxK-00000009uBO-0dxv for linux-arm-kernel@lists.infradead.org; Wed, 25 Jun 2025 20:42:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 329C461425; Wed, 25 Jun 2025 20:42:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9EEDC4CEEA; Wed, 25 Jun 2025 20:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750884172; bh=TQ2yeYtVxpuEcSzjUBWcAiYEI/WKnqX64t4Owb5qOrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U5TLu1SR2eFmHmjOKeSx3aKCAWxa4XTEYdF8wwxUrjql02hOZ09fD7Ik0plJ4vBoe AS237xzFgsf5hfHMH/KUE+PxIcr73d6Ck6KTq68abVVJFDYB9fbHdhtDY2GtiEz7cA WTTKhgFQPy9PRD1aYqTPsqRAUc+/riXd10J7jTDsMCYQNLLBoxmbWajwTq4B5LIaiO VcXlESrEBruI46HNCXmJYbHDMNwwPVyfv2R7LrpEpvvSPgk+boj603uMj71yJU7nf0 D4DYtZjhSYagenKy+5N3BLKiht1FthT8rNrUABrxCkP932kq32xsVcyOaIZgj2ogdq 3eQ/kT5FUWLgQ== Date: Wed, 25 Jun 2025 15:42:52 -0500 From: Rob Herring To: Andrew Jeffery Cc: Ryan Chen , Catalin Marinas , soc@lists.linux.dev, Mo Elbadry , Arnd Bergmann , William Kennington , Taniya Das , linux-kernel@vger.kernel.org, spuranik@nvidia.com, Eric Biggers , Joel Stanley , linux-aspeed@lists.ozlabs.org, Will Deacon , Conor Dooley , Krzysztof Kozlowski , Nishanth Menon , Lad Prabhakar , nfraprado@collabora.com, linux-arm-kernel@lists.infradead.org, Kuninori Morimoto , Rom Lemarchand , devicetree@vger.kernel.org, Geert Uytterhoeven , leohu@nvidia.com, Bjorn Andersson , Yuxiao Zhang , dkodihalli@nvidia.com, wthai@nvidia.com Subject: Re: [PATCH v0 0/5] Add initial AST2700 SoC support Message-ID: <20250625204252.GA2143810-robh@kernel.org> References: <20250612100933.3007673-1-ryan_chen@aspeedtech.com> <174975871838.2916138.1953670783794758715.robh@kernel.org> <7b3be5c104b1fe1033570f2f3e2391991b6d9d42.camel@codeconstruct.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7b3be5c104b1fe1033570f2f3e2391991b6d9d42.camel@codeconstruct.com.au> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 13, 2025 at 02:59:43PM +0930, Andrew Jeffery wrote: > On Thu, 2025-06-12 at 15:12 -0500, Rob Herring (Arm) wrote: > > > > On Thu, 12 Jun 2025 18:09:28 +0800, Ryan Chen wrote: > > > This patch series introduces initial support for the Aspeed AST2700 SoC > > > and the AST2700 Evaluation Board (EVB) to the Linux kernel. The AST2700 > > > is the 7th generation Baseboard Management Controller (BMC) SoC from Aspeed, > > > featuring improved performance, enhanced security, and expanded I/O > > > capabilities compared to previous generations. > > > > > > The patchset includes the following changes: > > > - Device tree bindings for AST2700 boards. > > > - Addition of the AST2700 platform to the Kconfig menu. > > > - Basic device tree for the AST2700 SoC. > > > - Device tree for the AST2700-EVB. > > > - Updated defconfig to enable essential options for AST2700. > > > > > > Ryan Chen (5): > > >   dt-bindings: arm: aspeed: Add AST2700 board compatible > > >   arm64: Kconfig: Add Aspeed SoC family (ast2700) platform option > > >   arm64: dts: aspeed: Add initial AST2700 SoC device tree > > >   arm64: dts: aspeed: Add AST2700 EVB device tree > > >   arm64: configs: Update defconfig for AST2700 platform support > > > > > >  .../bindings/arm/aspeed/aspeed.yaml           |   5 + > > >  arch/arm64/Kconfig.platforms                  |   6 + > > >  arch/arm64/boot/dts/Makefile                  |   1 + > > >  arch/arm64/boot/dts/aspeed/Makefile           |   4 + > > >  arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi     | 380 ++++++++++++++++++ > > >  arch/arm64/boot/dts/aspeed/ast2700-evb.dts    |  54 +++ > > >  arch/arm64/configs/defconfig                  |   1 + > > >  7 files changed, 451 insertions(+) > > >  create mode 100644 arch/arm64/boot/dts/aspeed/Makefile > > >  create mode 100644 arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi > > >  create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts > > > > > > -- > > > 2.34.1 > > > > > > > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > > series. > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > > are fixed by another series. Ultimately, it is up to the platform > > maintainer whether these warnings are acceptable or not. No need to reply > > unless the platform maintainer has comments. > > > > If you already ran DT checks and didn't see these error(s), then > > make sure dt-schema is up to date: > > > >   pip3 install dtschema --upgrade > > > > > > This patch series was applied (using b4) to base: > >  Base: attempting to guess base-commit... > >  Base: tags/v6.16-rc1 (exact match) > > > > If this is not the correct base, please add 'base-commit' tag > > (or use b4 which does this automatically) > > > > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/aspeed/' for 20250612100933.3007673-1-ryan_chen@aspeedtech.com: > > > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: serial@14c33b00 (ns16550a): 'pinctrl-0' is a dependency of 'pinctrl-names' > >         from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml# > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@100 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 0, 3844]] is too short > >         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@110 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 1, 3844]] is too short > >         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@120 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 2, 3844]] is too short > >         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@130 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 3, 3844]] is too short > >         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@140 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 4, 3844]] is too short > >         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > > arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@150 (aspeed,ast2700-intc-ic): interrupts-extended: [[6, 5, 3844]] is too short > >         from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml# > > > > To draw a line in the sand here: while the existing Aspeed devicetrees > (AST2600 and below) produce warnings, I won't accept devicetree patches > for the AST2700 and related boards unless they are warning-free. Thank you. If you hadn't said it, I would have. Hopefully there's some IP reuse that will get the older stuff fixed (if the fix is in the schema). Rob